Whamcloud - gitweb
LU-17301 utils: l_getidentity build fix 91/53191/6
authorAlexander Zarochentsev <alexander.zarochentsev@hpe.com>
Tue, 21 Nov 2023 23:15:06 +0000 (23:15 +0000)
committerOleg Drokin <green@whamcloud.com>
Wed, 13 Dec 2023 12:22:54 +0000 (12:22 +0000)
The extra shared libs dependencies have an effect on
the l_getidentity libtool wrapper script created
in the source directory. The wrapper script fails
if it is executed as an identity upcall by a Lustre
md server, as it uses some of the core linux utilities
from /bin:

l_getidentity: line 150: ls: command not found
l_getidentity: line 197: rm: command not found
l_getidentity: line 211: rm: command not found
l_getidentity: line 212: mv: command not found
l_getidentity: line 213: rm: command not found

Removing the unnecessary build dependencies fixes
the issue.

Test-Parameters: trivial
Fixes: 5f9f92454e ("LU-16901 utils: l_getidentity with nss module support")
Signed-off-by: Alexander Zarochentsev <alexander.zarochentsev@hpe.com>
Change-Id: Ib8b83d5610a4d91ebb556406b563ca16e59dce76
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/53191
Reviewed-by: Alexander Boyko <alexander.boyko@hpe.com>
Reviewed-by: Timothy Day <timday@amazon.com>
Reviewed-by: Shaun Tancheff <shaun.tancheff@hpe.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
Reviewed-by: Arshad Hussain <arshad.hussain@aeoncomputing.com>
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
lustre/utils/Makefile.am

index bee65a1..31e2302 100644 (file)
@@ -245,9 +245,9 @@ l_foreign_symlink_LDADD := $(top_builddir)/libcfs/libcfs/libcfs.la
 l_foreign_symlink_DEPENDENCIES := $(top_builddir)/libcfs/libcfs/libcfs.la
 
 l_getidentity_SOURCES = l_getidentity.c
-l_getidentity_LDADD := $(top_builddir)/libcfs/libcfs/libcfs.la liblustreapi.la $(LIBPTLCTL)
+l_getidentity_LDADD := $(top_builddir)/libcfs/libcfs/libcfs.la
 l_getidentity_LDFLAGS = -ldl
-l_getidentity_DEPENDENCIES := $(top_builddir)/libcfs/libcfs/libcfs.la liblustreapi.la $(LIBPTLCTL)
+l_getidentity_DEPENDENCIES := $(top_builddir)/libcfs/libcfs/libcfs.la
 
 lhsmtool_posix_SOURCES = lhsmtool_posix.c pid_file.c pid_file.h
 lhsmtool_posix_LDADD := liblustreapi.la $(PTHREAD_LIBS) \