Whamcloud - gitweb
LU-15981 tests: add missing close in cascading_rw 23/47823/3
authorVladimir Saveliev <vladimir.saveliev@hpe.com>
Mon, 1 Apr 2024 12:00:18 +0000 (15:00 +0300)
committerOleg Drokin <green@whamcloud.com>
Mon, 8 Apr 2024 15:36:57 +0000 (15:36 +0000)
ONLY=cascading_rw OSTSIZE=200000 SLOW=yes sh parallel-scale.sh used to
fail due to lack of space.

cascading_rw missed a close before unlink, so disk space got consumed
by open unlinked files.

Add the missing close().

Change-Id: I9a8b3bfb9ff00e604ae0439433599b5050191b8e
HPE-bug-id: LUS-10753
Test-Parameters: testlist=trivial testlist=parallel-scale envdefinitions=ONLY=cascading_rw
Signed-off-by: Vladimir Saveliev <vladimir.saveliev@hpe.com>
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/47823
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Reviewed-by: Alex Zhuravlev <bzzz@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
lustre/tests/mpi/cascading_rw.c

index 6c9d4f6..d69fd23 100644 (file)
@@ -221,6 +221,8 @@ void rw_file(char *name, long stride, unsigned int seed)
                        errno = 0;
                        FAILF("Error: diff data read from %s", filename);
                }
+               if (close(fd) == -1)
+                       FAILF("close of file %s", filename);
        }
 
        MPI_Barrier(MPI_COMM_WORLD);