Whamcloud - gitweb
git://git.whamcloud.com
/
tools
/
e2fsprogs.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
6a26b38
)
libext2fs: fix a broken close() test
author
Darrick J. Wong
<darrick.wong@oracle.com>
Thu, 12 Dec 2013 18:17:58 +0000
(13:17 -0500)
committer
Theodore Ts'o
<tytso@mit.edu>
Thu, 12 Dec 2013 18:17:59 +0000
(13:17 -0500)
Zero is a valid file descriptor, so close it.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
lib/ext2fs/mkjournal.c
patch
|
blob
|
history
diff --git
a/lib/ext2fs/mkjournal.c
b/lib/ext2fs/mkjournal.c
index
09ca412
..
69ac135
100644
(file)
--- a/
lib/ext2fs/mkjournal.c
+++ b/
lib/ext2fs/mkjournal.c
@@
-595,7
+595,7
@@
errcode_t ext2fs_add_journal_inode(ext2_filsys fs, blk_t num_blocks, int flags)
ext2fs_mark_super_dirty(fs);
return 0;
errout:
- if (fd > 0)
+ if (fd >
=
0)
close(fd);
return retval;
}