Whamcloud - gitweb
LU-17000 utils: handle_yaml_no_op() has wrong signature 18/60018/2 master
authorJames Simmons <jsimmons@infradead.org>
Wed, 2 Jul 2025 13:14:20 +0000 (09:14 -0400)
committerOleg Drokin <green@whamcloud.com>
Tue, 8 Jul 2025 04:00:39 +0000 (04:00 +0000)
The liblnetconfig library uses struct lookup_cmd_hdlr_tbl
as a function lookup table. Those callbacks have a specific
prototype but handle_yaml_no_op() is not define that way.
Newer compilers will fail due to this mismatch.

Test-Parameters: trivial
Change-Id: Ib62664538939fcbedca936afd2edb3e8c68a182f
Signed-off-by: James Simmons <jsimmons@infradead.org>
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/60018
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Timothy Day <timday@amazon.com>
Reviewed-by: Arshad Hussain <arshad.hussain@aeoncomputing.com>
Reviewed-by: Shaun Tancheff <shaun.tancheff@hpe.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
lnet/utils/lnetconfig/liblnetconfig.c

index c6dbbb9..05dc094 100644 (file)
@@ -6269,7 +6269,8 @@ static int handle_yaml_discover(struct cYAML *tree, struct cYAML **show_rc,
                                        show_rc, err_rc);
 }
 
-static int handle_yaml_no_op()
+static int handle_yaml_no_op(struct cYAML *tree, struct cYAML **show_rc,
+                            struct cYAML **err_rc)
 {
        return LUSTRE_CFG_RC_NO_ERR;
 }