Whamcloud - gitweb
LU-1606 idl: remove LASSERT/CLASSERT from lustre_idl.h 82/5682/3
authorAndreas Dilger <adilger@whamcloud.com>
Thu, 22 Nov 2012 21:40:29 +0000 (14:40 -0700)
committerOleg Drokin <oleg.drokin@intel.com>
Thu, 1 Aug 2013 05:54:37 +0000 (05:54 +0000)
commiteb5923c2d24f40a4116495c1c59eb9a6e2ed55a1
treec06fc24ba3dfb978f2f261598936c5d2a06fa1bd
parent0a0a5589d7092b9c276731e6cea3d5d08d0ea27d
LU-1606 idl: remove LASSERT/CLASSERT from lustre_idl.h

Remove the usage of LASSERT() and CLASSERT() from lustre_idl.h, so
that it is usable from userspace programs if needed.  These have
crept in over the years, but are not intended to be there.

The CLASSERT() checks for fid swabbing were largely redundant, and
have been moved to lustre/fid/fid_handler.c.

The fid_is_sane() macro has been modified to remove the check that
f_ver == 0, since this will eventually not be true, and the client
or server should not crash if it sees such a FID during usage.

There are still a few LASSERTs that need to be removed when FID-on-OST
is landed, but I don't want to remove them before that code lands.

There are also uses of CERROR() that could be removed at that time.

Signed-off-by: Andreas Dilger <adilger@whamcloud.com>
Signed-off-by: John L. Hammond <john.hammond@intel.com>
Change-Id: I04901d7713dc31b489685d4639e7bf857decab07
Reviewed-on: http://review.whamcloud.com/5682
Tested-by: Hudson
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Maloo <whamcloud.maloo@gmail.com>
Reviewed-by: Christopher J. Morrone <chris.morrone.llnl@gmail.com>
lustre/fid/fid_handler.c
lustre/include/lustre/lustre_idl.h