Whamcloud - gitweb
LU-1540 e2fsck: add missing symlink NUL terminator
authorAndreas Dilger <andreas.dilger@intel.com>
Sat, 14 Jul 2012 02:33:01 +0000 (20:33 -0600)
committerLi Dongyang <dongyangli@ddn.com>
Fri, 17 Jan 2025 02:23:15 +0000 (13:23 +1100)
commit17d716ae3bbfd5f5229ef78ea5b0d6a69d0997da
tree74dfce298163ee98270c18876ad4456d66fea85d
parente89568af33322fd84e0d920b51b6114e0fdfce35
LU-1540 e2fsck: add missing symlink NUL terminator

If a long symbolic link target is written into an external block
without a NUL terminator, its length is decided by the inode's size.
Make symlink check add a NUL termination in such cases if needed.

Such faulty symlinks were generated by osd-ldiskfs on the MDS until
Lustre 2.1.3 and Lustre 2.3.  The in-kernel code would handle such
unterminated symlinks correctly, since it used the inode size to
determine the symlink length, but e2fsck would assume the symlink
is broken if there wasn't a trailing NUL.

Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Change-Id: I4419b30f1adb4a7d273796a936427aa351510213
e2fsck/e2fsck.h
e2fsck/pass1.c
e2fsck/pass2.c
e2fsck/problem.c
e2fsck/problem.h
tests/f_badsymlinks/expect.1
tests/f_badsymlinks/expect.2
tests/f_badsymlinks2/expect.1
tests/f_badsymlinks2/expect.2