*/
/*
* This file is part of Lustre, http://www.lustre.org/
- * Lustre is a trademark of Sun Microsystems, Inc.
*
* lustre/ptlrpc/sec_lproc.c
*
static int sptlrpc_info_lprocfs_seq_show(struct seq_file *seq, void *v)
{
- struct obd_device *dev = seq->private;
- struct client_obd *cli = &dev->u.cli;
- struct ptlrpc_sec *sec = NULL;
- char str[32];
+ struct obd_device *obd = seq->private;
+ struct client_obd *cli = &obd->u.cli;
+ struct ptlrpc_sec *sec = NULL;
+ char str[32];
- LASSERT(strcmp(dev->obd_type->typ_name, LUSTRE_OSC_NAME) == 0 ||
- strcmp(dev->obd_type->typ_name, LUSTRE_MDC_NAME) == 0 ||
- strcmp(dev->obd_type->typ_name, LUSTRE_MGC_NAME) == 0 ||
- strcmp(dev->obd_type->typ_name, LUSTRE_LWP_NAME) == 0 ||
- strcmp(dev->obd_type->typ_name, LUSTRE_OSP_NAME) == 0);
+ LASSERT(strcmp(obd->obd_type->typ_name, LUSTRE_OSC_NAME) == 0 ||
+ strcmp(obd->obd_type->typ_name, LUSTRE_MDC_NAME) == 0 ||
+ strcmp(obd->obd_type->typ_name, LUSTRE_MGC_NAME) == 0 ||
+ strcmp(obd->obd_type->typ_name, LUSTRE_LWP_NAME) == 0 ||
+ strcmp(obd->obd_type->typ_name, LUSTRE_OSP_NAME) == 0);
- if (cli->cl_import)
- sec = sptlrpc_import_sec_ref(cli->cl_import);
- if (sec == NULL)
- goto out;
+ if (cli->cl_import)
+ sec = sptlrpc_import_sec_ref(cli->cl_import);
+ if (sec == NULL)
+ goto out;
- sec_flags2str(sec->ps_flvr.sf_flags, str, sizeof(str));
+ sec_flags2str(sec->ps_flvr.sf_flags, str, sizeof(str));
seq_printf(seq, "rpc flavor: %s\n",
sptlrpc_flavor2name_base(sec->ps_flvr.sf_rpc));
sptlrpc_sec_put(sec);
out:
- return 0;
+ return 0;
}
-LPROC_SEQ_FOPS_RO(sptlrpc_info_lprocfs);
+LDEBUGFS_SEQ_FOPS_RO(sptlrpc_info_lprocfs);
static int sptlrpc_ctxs_lprocfs_seq_show(struct seq_file *seq, void *v)
{
- struct obd_device *dev = seq->private;
- struct client_obd *cli = &dev->u.cli;
- struct ptlrpc_sec *sec = NULL;
+ struct obd_device *obd = seq->private;
+ struct client_obd *cli = &obd->u.cli;
+ struct ptlrpc_sec *sec = NULL;
- LASSERT(strcmp(dev->obd_type->typ_name, LUSTRE_OSC_NAME) == 0 ||
- strcmp(dev->obd_type->typ_name, LUSTRE_MDC_NAME) == 0 ||
- strcmp(dev->obd_type->typ_name, LUSTRE_MGC_NAME) == 0 ||
- strcmp(dev->obd_type->typ_name, LUSTRE_LWP_NAME) == 0 ||
- strcmp(dev->obd_type->typ_name, LUSTRE_OSP_NAME) == 0);
+ LASSERT(strcmp(obd->obd_type->typ_name, LUSTRE_OSC_NAME) == 0 ||
+ strcmp(obd->obd_type->typ_name, LUSTRE_MDC_NAME) == 0 ||
+ strcmp(obd->obd_type->typ_name, LUSTRE_MGC_NAME) == 0 ||
+ strcmp(obd->obd_type->typ_name, LUSTRE_LWP_NAME) == 0 ||
+ strcmp(obd->obd_type->typ_name, LUSTRE_OSP_NAME) == 0);
- if (cli->cl_import)
- sec = sptlrpc_import_sec_ref(cli->cl_import);
- if (sec == NULL)
- goto out;
+ if (cli->cl_import)
+ sec = sptlrpc_import_sec_ref(cli->cl_import);
+ if (sec == NULL)
+ goto out;
- if (sec->ps_policy->sp_cops->display)
- sec->ps_policy->sp_cops->display(sec, seq);
+ if (sec->ps_policy->sp_cops->display)
+ sec->ps_policy->sp_cops->display(sec, seq);
- sptlrpc_sec_put(sec);
+ sptlrpc_sec_put(sec);
out:
- return 0;
+ return 0;
}
-LPROC_SEQ_FOPS_RO(sptlrpc_ctxs_lprocfs);
+LDEBUGFS_SEQ_FOPS_RO(sptlrpc_ctxs_lprocfs);
+
+#if LUSTRE_VERSION_CODE < OBD_OCD_VERSION(2, 16, 53, 0)
+static ssize_t sepol_seq_write_old(struct obd_device *obd,
+ const char __user *buffer, size_t count)
+{
+ struct client_obd *cli = &obd->u.cli;
+ struct obd_import *imp = cli->cl_import;
+ struct sepol_downcall_data_old *param;
+ size_t maxlen = sizeof(imp->imp_sec->ps_sepol);
+ size_t size = sizeof(*param);
+ size_t maxparam = sizeof(*param) + maxlen;
+ int len;
+ int rc = 0;
+
+ if (count <= size) {
+ rc = -EINVAL;
+ CERROR("%s: invalid data count %zu <= size %zu: rc = %d\n",
+ obd->obd_name, count, size, rc);
+ return rc;
+ }
+
+ OBD_ALLOC(param, maxparam);
+ if (!param)
+ return -ENOMEM;
+
+ if (copy_from_user(param, buffer, min(count, maxparam))) {
+ rc = -EFAULT;
+ CERROR("%s: bad sepol data: rc = %d\n", obd->obd_name, rc);
+ GOTO(out, rc);
+ }
+
+ if (param->sdd_magic != SEPOL_DOWNCALL_MAGIC_OLD) {
+ rc = -EINVAL;
+ CERROR("%s: sepol downcall bad magic %#08x != %#08x: rc = %d\n",
+ obd->obd_name, param->sdd_magic,
+ SEPOL_DOWNCALL_MAGIC_OLD, rc);
+ GOTO(out, rc);
+ }
+
+ len = param->sdd_sepol_len;
+ if (len == 0 || len >= maxlen) {
+ rc = -EINVAL;
+ CERROR("%s: bad sepol len %u >= maxlen %zu: rc = %d\n",
+ obd->obd_name, len, maxlen, rc);
+ GOTO(out, rc);
+ }
+ size = offsetof(typeof(*param), sdd_sepol[len]);
+
+ if (count < size) {
+ rc = -EINVAL;
+ CERROR("%s: bad sepol count %zu < total size %zu: rc = %d\n",
+ obd->obd_name, count, size, rc);
+ GOTO(out, rc);
+ }
+
+ spin_lock(&imp->imp_sec->ps_lock);
+ memcpy(imp->imp_sec->ps_sepol, param->sdd_sepol, len);
+ imp->imp_sec->ps_sepol[len + 1] = '\0';
+ imp->imp_sec->ps_sepol_mtime = ktime_set(param->sdd_sepol_mtime, 0);
+ spin_unlock(&imp->imp_sec->ps_lock);
+
+out:
+ OBD_FREE(param, maxparam);
+
+ return rc ?: count;
+}
+#endif
static ssize_t
-lprocfs_sptlrpc_sepol_seq_write(struct file *file, const char __user *buffer,
- size_t count, void *data)
+ldebugfs_sptlrpc_sepol_seq_write(struct file *file, const char __user *buffer,
+ size_t count, void *data)
{
struct seq_file *seq = file->private_data;
- struct obd_device *dev = seq->private;
- struct client_obd *cli = &dev->u.cli;
+ struct obd_device *obd = seq->private;
+ struct client_obd *cli = &obd->u.cli;
struct obd_import *imp = cli->cl_import;
struct sepol_downcall_data *param;
- int size = sizeof(*param);
+ size_t maxlen = sizeof(imp->imp_sec->ps_sepol);
+ size_t size = sizeof(*param);
+ size_t maxparam = size + maxlen;
+ int len;
int rc = 0;
- if (count < size) {
- CERROR("%s: invalid data count = %lu, size = %d\n",
- dev->obd_name, (unsigned long) count, size);
- return -EINVAL;
+ if (count <= size) {
+ rc = -EINVAL;
+ CERROR("%s: invalid data count %zu <= size %zu: rc = %d\n",
+ obd->obd_name, count, size, rc);
+ return rc;
+ }
+
+#if LUSTRE_VERSION_CODE < OBD_OCD_VERSION(2, 16, 53, 0)
+ {
+ __u32 magic;
+
+ if (copy_from_user(&magic, buffer, sizeof(magic))) {
+ rc = -EFAULT;
+ CERROR("%s: bad sepol magic data: rc = %d\n",
+ obd->obd_name, rc);
+ return rc;
+ }
+
+ if (unlikely(magic == SEPOL_DOWNCALL_MAGIC_OLD))
+ return sepol_seq_write_old(obd, buffer, count);
}
+#endif
- OBD_ALLOC(param, size);
- if (param == NULL)
+ OBD_ALLOC(param, maxparam);
+ if (!param)
return -ENOMEM;
- if (copy_from_user(param, buffer, size)) {
- CERROR("%s: bad sepol data\n", dev->obd_name);
- GOTO(out, rc = -EFAULT);
+ if (copy_from_user(param, buffer, min(count, maxparam))) {
+ rc = -EFAULT;
+ CERROR("%s: bad sepol data: rc = %d\n", obd->obd_name, rc);
+ GOTO(out, rc);
}
if (param->sdd_magic != SEPOL_DOWNCALL_MAGIC) {
- CERROR("%s: sepol downcall bad params\n",
- dev->obd_name);
- GOTO(out, rc = -EINVAL);
+ rc = -EINVAL;
+ CERROR("%s: sepol downcall bad magic %#08x != %#08x: rc = %d\n",
+ obd->obd_name, param->sdd_magic,
+ SEPOL_DOWNCALL_MAGIC, rc);
+ GOTO(out, rc);
}
- if (param->sdd_sepol_len == 0 ||
- param->sdd_sepol_len >= sizeof(imp->imp_sec->ps_sepol)) {
- CERROR("%s: invalid sepol data returned\n",
- dev->obd_name);
- GOTO(out, rc = -EINVAL);
+ len = param->sdd_sepol_len;
+ if (len == 0 || len >= maxlen) {
+ rc = -EINVAL;
+ CERROR("%s: bad sepol len %u >= maxlen %zu: rc = %d\n",
+ obd->obd_name, len, maxlen, rc);
+ GOTO(out, rc);
}
- rc = param->sdd_sepol_len; /* save sdd_sepol_len */
- OBD_FREE(param, size);
- size = offsetof(struct sepol_downcall_data,
- sdd_sepol[rc]);
-
- /* alloc again with real size */
- rc = 0;
- OBD_ALLOC(param, size);
- if (param == NULL)
- return -ENOMEM;
+ size = offsetof(typeof(*param), sdd_sepol[len]);
- if (copy_from_user(param, buffer, size)) {
- CERROR("%s: bad sepol data\n", dev->obd_name);
- GOTO(out, rc = -EFAULT);
+ if (count < size) {
+ rc = -EINVAL;
+ CERROR("%s: bad sepol count %zu < total size %zu: rc = %d\n",
+ obd->obd_name, count, size, rc);
+ GOTO(out, rc);
}
spin_lock(&imp->imp_sec->ps_lock);
- snprintf(imp->imp_sec->ps_sepol, param->sdd_sepol_len + 1, "%s",
- param->sdd_sepol);
- imp->imp_sec->ps_sepol_mtime = param->sdd_sepol_mtime;
+ memcpy(imp->imp_sec->ps_sepol, param->sdd_sepol, len);
+ imp->imp_sec->ps_sepol[len + 1] = '\0';
+ imp->imp_sec->ps_sepol_mtime = ktime_set(param->sdd_sepol_mtime, 0);
spin_unlock(&imp->imp_sec->ps_lock);
out:
- if (param != NULL)
- OBD_FREE(param, size);
+ OBD_FREE(param, maxparam);
- return rc ? rc : count;
+ return rc ?: count;
}
-LPROC_SEQ_FOPS_WR_ONLY(srpc, sptlrpc_sepol);
+LDEBUGFS_FOPS_WR_ONLY(srpc, sptlrpc_sepol);
-int sptlrpc_lprocfs_cliobd_attach(struct obd_device *dev)
+int sptlrpc_lprocfs_cliobd_attach(struct obd_device *obd)
{
- int rc;
-
- if (strcmp(dev->obd_type->typ_name, LUSTRE_OSC_NAME) != 0 &&
- strcmp(dev->obd_type->typ_name, LUSTRE_MDC_NAME) != 0 &&
- strcmp(dev->obd_type->typ_name, LUSTRE_MGC_NAME) != 0 &&
- strcmp(dev->obd_type->typ_name, LUSTRE_LWP_NAME) != 0 &&
- strcmp(dev->obd_type->typ_name, LUSTRE_OSP_NAME) != 0) {
+ if (strcmp(obd->obd_type->typ_name, LUSTRE_OSC_NAME) != 0 &&
+ strcmp(obd->obd_type->typ_name, LUSTRE_MDC_NAME) != 0 &&
+ strcmp(obd->obd_type->typ_name, LUSTRE_MGC_NAME) != 0 &&
+ strcmp(obd->obd_type->typ_name, LUSTRE_LWP_NAME) != 0 &&
+ strcmp(obd->obd_type->typ_name, LUSTRE_OSP_NAME) != 0) {
CERROR("can't register lproc for obd type %s\n",
- dev->obd_type->typ_name);
+ obd->obd_type->typ_name);
return -EINVAL;
}
- rc = ldebugfs_seq_create(dev->obd_debugfs_entry, "srpc_info", 0444,
- &sptlrpc_info_lprocfs_fops, dev);
- if (rc) {
- CERROR("create proc entry srpc_info for %s: %d\n",
- dev->obd_name, rc);
- return rc;
- }
+ debugfs_create_file("srpc_info", 0444, obd->obd_debugfs_entry, obd,
+ &sptlrpc_info_lprocfs_fops);
- rc = ldebugfs_seq_create(dev->obd_debugfs_entry, "srpc_contexts",
- 0444, &sptlrpc_ctxs_lprocfs_fops, dev);
- if (rc) {
- CERROR("create proc entry srpc_contexts for %s: %d\n",
- dev->obd_name, rc);
- return rc;
- }
+ debugfs_create_file("srpc_contexts", 0444, obd->obd_debugfs_entry, obd,
+ &sptlrpc_ctxs_lprocfs_fops);
- rc = ldebugfs_seq_create(dev->obd_debugfs_entry, "srpc_sepol",
- 0200, &srpc_sptlrpc_sepol_fops, dev);
- if (rc) {
- CERROR("create proc entry srpc_sepol for %s: %d\n",
- dev->obd_name, rc);
- return rc;
- }
+ debugfs_create_file("srpc_sepol", 0200, obd->obd_debugfs_entry, obd,
+ &srpc_sptlrpc_sepol_fops);
return 0;
}
LDEBUGFS_SEQ_FOPS_RO(sptlrpc_proc_enc_pool);
-static struct lprocfs_vars sptlrpc_lprocfs_vars[] = {
+static struct ldebugfs_vars sptlrpc_lprocfs_vars[] = {
{ .name = "encrypt_page_pools",
.fops = &sptlrpc_proc_enc_pool_fops },
{ NULL }
int sptlrpc_lproc_init(void)
{
- int rc;
+ int rc = 0;
LASSERT(sptlrpc_debugfs_dir == NULL);
- sptlrpc_debugfs_dir = ldebugfs_register("sptlrpc", debugfs_lustre_root,
- sptlrpc_lprocfs_vars, NULL);
- if (IS_ERR_OR_NULL(sptlrpc_debugfs_dir)) {
- rc = sptlrpc_debugfs_dir ? PTR_ERR(sptlrpc_debugfs_dir)
- : -ENOMEM;
- sptlrpc_debugfs_dir = NULL;
- return rc;
- }
+ sptlrpc_debugfs_dir = debugfs_create_dir("sptlrpc",
+ debugfs_lustre_root);
+ ldebugfs_add_vars(sptlrpc_debugfs_dir, sptlrpc_lprocfs_vars, NULL);
sptlrpc_lprocfs_dir = lprocfs_register("sptlrpc", proc_lustre_root,
NULL, NULL);
: -ENOMEM;
sptlrpc_lprocfs_dir = NULL;
}
- return 0;
+ return rc;
}
void sptlrpc_lproc_fini(void)
{
- if (!IS_ERR_OR_NULL(sptlrpc_debugfs_dir))
- ldebugfs_remove(&sptlrpc_debugfs_dir);
+ debugfs_remove_recursive(sptlrpc_debugfs_dir);
+ sptlrpc_debugfs_dir = NULL;
if (!IS_ERR_OR_NULL(sptlrpc_lprocfs_dir))
lprocfs_remove(&sptlrpc_lprocfs_dir);