From: Theodore Ts'o <tytso@mit.edu>
Date: Sat, 23 Jun 2018 02:20:51 +0000 (-0400)
Subject: libsupport: fix memory leak in error path in quota_compute_usage()
X-Git-Tag: v1.44.3-rc1~31
X-Git-Url: https://git.whamcloud.com/?p=tools%2Fe2fsprogs.git;a=commitdiff_plain;h=98eaa7c98e66417bf6b0981d4b2fd81f776fe13b

libsupport: fix memory leak in error path in quota_compute_usage()

Fixes-Coverity-Bug: 1362023
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---

diff --git a/lib/support/mkquota.c b/lib/support/mkquota.c
index efc37cb..d136a91 100644
--- a/lib/support/mkquota.c
+++ b/lib/support/mkquota.c
@@ -484,8 +484,10 @@ errcode_t quota_compute_usage(quota_ctx_t qctx)
 	}
 	inode_size = fs->super->s_inode_size;
 	inode = malloc(inode_size);
-	if (!inode)
+	if (!inode) {
+		ext2fs_close_inode_scan(scan);
 		return ENOMEM;
+	}
 	while (1) {
 		ret = ext2fs_get_next_inode_full(scan, &ino,
 						 EXT2_INODE(inode), inode_size);