From fe00e1135688e6f3e72b19314d11b13e9983c9d1 Mon Sep 17 00:00:00 2001 From: Dmitry Eremin Date: Thu, 31 Jul 2014 13:31:27 +0400 Subject: [PATCH] LU-5417 tgt: incorrect return code from tgt_handle_lfsck_query Incorrect comparison of unsigned int with zero always false. Therefore tgt_handle_lfsck_query() always return success. Signed-off-by: Dmitry Eremin Change-Id: Idcb321880fb5071c93bebbba0a55961cdbe286dd Reviewed-on: http://review.whamcloud.com/11290 Tested-by: Jenkins Reviewed-by: John L. Hammond Tested-by: Maloo Reviewed-by: Fan Yong Reviewed-by: Oleg Drokin --- lustre/target/tgt_handler.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/lustre/target/tgt_handler.c b/lustre/target/tgt_handler.c index bab3ff2..8742c9a 100644 --- a/lustre/target/tgt_handler.c +++ b/lustre/target/tgt_handler.c @@ -1417,7 +1417,7 @@ static int tgt_handle_lfsck_query(struct tgt_session_info *tsi) { struct lfsck_request *request; struct lfsck_reply *reply; - int rc = 0; + int rc; ENTRY; request = req_capsule_client_get(tsi->tsi_pill, &RMF_LFSCK_REQUEST); @@ -1428,12 +1428,10 @@ static int tgt_handle_lfsck_query(struct tgt_session_info *tsi) if (reply == NULL) RETURN(-ENOMEM); - reply->lr_status = tgt_lfsck_query(tsi->tsi_env, - tsi->tsi_tgt->lut_bottom, request); - if (reply->lr_status < 0) - rc = reply->lr_status; + rc = tgt_lfsck_query(tsi->tsi_env, tsi->tsi_tgt->lut_bottom, request); + reply->lr_status = rc; - RETURN(rc); + RETURN(rc < 0 ? rc : 0); } struct tgt_handler tgt_lfsck_handlers[] = { -- 1.8.3.1