From f111fac3f785400f892ca03bfb9078c6bd091f7d Mon Sep 17 00:00:00 2001 From: Li Xi Date: Fri, 30 May 2014 23:13:18 +0800 Subject: [PATCH] LU-5126 libcfs: fix illegal page access of tracefiled() After failure happens and put_pages_back() returns the pages, tracefiled() should not go on itering on the page list. Otherwise, some pages might be accessed illegally. Signed-off-by: Li Xi Change-Id: I34dd91e3a7ca7d49e67c2bd587c481eb71873003 Reviewed-on: http://review.whamcloud.com/10524 Tested-by: Jenkins Tested-by: Maloo Reviewed-by: Emoly Liu Reviewed-by: Niu Yawei Reviewed-by: Oleg Drokin --- libcfs/libcfs/tracefile.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libcfs/libcfs/tracefile.c b/libcfs/libcfs/tracefile.c index 6b76204..90a4a96 100644 --- a/libcfs/libcfs/tracefile.c +++ b/libcfs/libcfs/tracefile.c @@ -1022,6 +1022,7 @@ static int tracefiled(void *arg) "but wrote %d\n", tage->used, rc); put_pages_back(&pc); __LASSERT(list_empty(&pc.pc_pages)); + break; } } MMSPACE_CLOSE; -- 1.8.3.1