From d23a8edaa726f50cc48a270ec2905ec18401655f Mon Sep 17 00:00:00 2001 From: Sebastien Buisson Date: Mon, 27 May 2013 17:13:09 +0200 Subject: [PATCH] LU-3405 build: fix 'control flow' errors Fix 'control flow' issues found by Coverity version 6.5.1: Logically dead code (DEADCODE) Execution cannot reach this statement. Missing break in switch (MISSING_BREAK) This case is not terminated by a 'break' statement. Stray semicolon (STRAY_SEMICOLON) "if" statement with no "then" or "else" is suspicious. Unsigned compared against 0 (NO_EFFECT) This greater-than-or-equal-to-zero comparison of an unsigned value is always true. Signed-off-by: Sebastien Buisson Change-Id: Ia737603bd9ef4dd6b01891b9b13edd59dec11891 Reviewed-on: http://review.whamcloud.com/6466 Tested-by: Hudson Tested-by: Maloo Reviewed-by: Dmitry Eremin Reviewed-by: Oleg Drokin --- lustre/obdclass/obd_mount_server.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/lustre/obdclass/obd_mount_server.c b/lustre/obdclass/obd_mount_server.c index 9137219..ad35237 100644 --- a/lustre/obdclass/obd_mount_server.c +++ b/lustre/obdclass/obd_mount_server.c @@ -985,13 +985,9 @@ static int server_stop_servers(int lsiflags) } if (obd != NULL && (type == NULL || type->typ_refcnt == 0)) { - int err; - obd->obd_force = 1; /* obd_fail doesn't mean much on a server obd */ - err = class_manual_cleanup(obd); - if (rc != 0) - rc = err; + rc = class_manual_cleanup(obd); } mutex_unlock(&server_start_lock); -- 1.8.3.1