From d084fc211370cfdf233b59eb7abdaa552f639fe1 Mon Sep 17 00:00:00 2001 From: Alexander Zarochentsev Date: Wed, 27 Mar 2019 19:39:03 +0300 Subject: [PATCH] LU-11585 quota: no IS_ERR() check in qsd_lqe_read qsd_lqe_read() should check lqe_locate() return value with IS_ERR() instead of != NULL. Cray-bug-id: LUS-6636 Signed-off-by: Alexander Zarochentsev Change-Id: I930a16a789ece6ca52ca82ce69626d6678472c9a Signed-off-by: Alexander Zarochentsev Reviewed-on: https://review.whamcloud.com/34522 Reviewed-by: Alex Zhuravlev Tested-by: Jenkins Reviewed-by: Patrick Farrell Reviewed-by: Andreas Dilger Tested-by: Maloo --- lustre/quota/qsd_entry.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lustre/quota/qsd_entry.c b/lustre/quota/qsd_entry.c index 40519a4..4e0faac 100644 --- a/lustre/quota/qsd_entry.c +++ b/lustre/quota/qsd_entry.c @@ -122,7 +122,7 @@ static int qsd_lqe_read(const struct lu_env *env, struct lquota_entry *lqe, lqe->lqe_enforced = true; } - if (lqe_def != NULL) + if (!IS_ERR(lqe_def)) lqe_putref(lqe_def); } -- 1.8.3.1