From c8a33e5322b0675680f8d737f04259799d30aa0e Mon Sep 17 00:00:00 2001 From: Mr NeilBrown Date: Wed, 30 Nov 2022 11:47:03 +1100 Subject: [PATCH] LU-16353 config: enable_foo variables mustn't contains space $enable_crypto is in some circumstances set to "embedded llcrypt" which contains a space. When the code from lustre-build.m4 then tests the value with: if test x$enablecrypto = xyes we get a syntax error from ./configure We could add quotes to this comment, but for consistency we would need to add quotes to ever other test for an enable_foo variable. It is simpler just to ensure we don't add spaces. So change the space to a hyphen. Test-Parameters: trivial Signed-off-by: Mr NeilBrown Change-Id: I097e857409d6ec48a765ccda1cc470d28b90e601 Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/49282 Tested-by: jenkins Tested-by: Maloo Reviewed-by: Sebastien Buisson Reviewed-by: Andreas Dilger Reviewed-by: James Simmons Reviewed-by: Oleg Drokin --- lustre/autoconf/lustre-core.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lustre/autoconf/lustre-core.m4 b/lustre/autoconf/lustre-core.m4 index f3ee56f..d82d30d 100644 --- a/lustre/autoconf/lustre-core.m4 +++ b/lustre/autoconf/lustre-core.m4 @@ -3203,7 +3203,7 @@ AS_IF([test "x$enable_crypto" = xin-kernel], [ AC_DEFINE(HAVE_LUSTRE_CRYPTO, 1, [Enable Lustre client crypto via embedded llcrypt]) AC_DEFINE(CONFIG_LL_ENCRYPTION, 1, [embedded llcrypt]) AC_DEFINE(HAVE_FSCRYPT_DUMMY_CONTEXT_ENABLED, 1, [embedded llcrypt uses llcrypt_dummy_context_enabled()]) - enable_crypto="embedded llcrypt" + enable_crypto="embedded-llcrypt" enable_llcrypt=yes], [ AS_IF([test "x$enable_crypto" = xyes], [AC_MSG_ERROR([Lustre client crypto cannot be enabled because of lack of encryption support in your kernel.])]) -- 1.8.3.1