From bd1808a3a250003d865a6b0624bad2b5204bbd12 Mon Sep 17 00:00:00 2001 From: Andreas Dilger Date: Wed, 6 Nov 2019 23:33:55 -0700 Subject: [PATCH] LU-12931 gnilnd: use time_after() to compare jiffies Fix a potential bug in gnilnd it is directly comparing a timeout against jiffies instead of using time_after() to handle jiffies wrap. Test-Parameters: trivial Signed-off-by: Andreas Dilger Change-Id: Ie4d190e9c04e807f2152b71dc28ef0b0463ebbe5 Reviewed-on: https://review.whamcloud.com/36702 Tested-by: jenkins Tested-by: Maloo Reviewed-by: Neil Brown Reviewed-by: Shaun Tancheff Reviewed-by: Chris Horn Reviewed-by: Oleg Drokin --- lnet/klnds/gnilnd/gnilnd_stack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lnet/klnds/gnilnd/gnilnd_stack.c b/lnet/klnds/gnilnd/gnilnd_stack.c index 411dbff..bab50cb 100644 --- a/lnet/klnds/gnilnd/gnilnd_stack.c +++ b/lnet/klnds/gnilnd/gnilnd_stack.c @@ -135,7 +135,7 @@ kgnilnd_quiesce_wait(char *reason) CFS_RACE(CFS_FAIL_GNI_QUIESCE_RACE); schedule_timeout_uninterruptible(cfs_time_seconds(i)); - LASSERTF(quiesce_deadline > jiffies, + LASSERTF(time_after(quiesce_deadline, jiffies), "couldn't quiesce threads in %lu seconds, falling over now\n", cfs_duration_sec(quiesce_to)); } -- 1.8.3.1