From bbadfbefd9e0323172ad0a37b4268e68bf0968b7 Mon Sep 17 00:00:00 2001 From: Oleg Drokin Date: Fri, 27 Feb 2015 07:43:55 +0000 Subject: [PATCH] Revert "LU-5417 lfs: fix comparison between signed and unsigned" This change is incorrect after all. While it's a noop on x86_64, it's a very important overflow check for 32bit arches. This reverts commit b5b354a75b5e697e90892878ecb26459cb9a6a21. Change-Id: I8810da3407d91e63c6e1c062a483a26ffc1bcd97 Reviewed-on: http://review.whamcloud.com/13903 Tested-by: Jenkins Reviewed-by: Oleg Drokin Tested-by: Oleg Drokin --- lustre/include/lustre/lustre_user.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lustre/include/lustre/lustre_user.h b/lustre/include/lustre/lustre_user.h index fb4cb9b..bb808e8 100644 --- a/lustre/include/lustre/lustre_user.h +++ b/lustre/include/lustre/lustre_user.h @@ -1197,7 +1197,7 @@ static inline ssize_t hur_len(struct hsm_user_request *hur) (__u64)hur->hur_request.hr_itemcount * sizeof(hur->hur_user_item[0]) + hur->hur_request.hr_data_len; - if (size > ~((size_t)0)>>1) + if (size != (ssize_t)size) return -1; return size; -- 1.8.3.1