From a5c1cd5ec240543a3b77b5da86eaceff0ace5ba0 Mon Sep 17 00:00:00 2001 From: Amir Shehata Date: Wed, 17 Oct 2018 12:59:13 -0700 Subject: [PATCH] LU-11530 lnet: properly error check sensitivity Reject setting health sensitivity greater than the maximum health value. Test-Parameters: trivial Signed-off-by: Amir Shehata Change-Id: I866ff2cac2ba6b034cdbac24096e7014c66a3e2e Reviewed-on: https://review.whamcloud.com/33392 Tested-by: Jenkins Tested-by: Maloo Reviewed-by: Sonia Sharma Reviewed-by: Doug Oucharek Reviewed-by: Oleg Drokin --- lnet/lnet/api-ni.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lnet/lnet/api-ni.c b/lnet/lnet/api-ni.c index b2d4c25..d796e9c 100644 --- a/lnet/lnet/api-ni.c +++ b/lnet/lnet/api-ni.c @@ -217,9 +217,11 @@ sensitivity_set(const char *val, cfs_kernel_param_arg_t *kp) return 0; } - if (value == *sensitivity) { + if (value > LNET_MAX_HEALTH_VALUE) { mutex_unlock(&the_lnet.ln_api_mutex); - return 0; + CERROR("Invalid health value. Maximum: %d value = %lu\n", + LNET_MAX_HEALTH_VALUE, value); + return -EINVAL; } *sensitivity = value; -- 1.8.3.1