From 89a668f6c8770c5af8c99984003ffd9844dc2904 Mon Sep 17 00:00:00 2001 From: Frank Zago Date: Wed, 18 May 2016 17:51:01 -0400 Subject: [PATCH] LU-8163 hsm: user_request_mask can't be unset in test 24c The following lines in sanity-hsm.sh test_24c set_hsm_param user_request_mask "" set_hsm_param group_request_mask "" set_hsm_param other_request_mask "" generate the following errors in the test, which isn't caught: error: set_param: setting mdt.lustre-MDT0000.hsm.user_request_mask: no value This is because "lct set_param" cannot accept an empty value: $ lctl set_param -n mdt.lustre-MDT0000.hsm.user_request_mask="" error: set_param: setting mdt.lustre-MDT0000.hsm.user_request_mask: no value Since the test checked earlier that [user|group|other]_request_mask was RESTORE, we don't actually need to change their values to nothing. They just have to be not ARCHIVE. Test-Parameters: trivial testlist=sanity-hsm,sanity-hsm Signed-off-by: frank zago Change-Id: I00622d93157e6577651996bf482ec8f710f86c9e Reviewed-on: http://review.whamcloud.com/20320 Reviewed-by: Henri Doreau Reviewed-by: Andreas Dilger Tested-by: Jenkins Tested-by: Maloo Reviewed-by: Oleg Drokin --- lustre/tests/sanity-hsm.sh | 3 --- 1 file changed, 3 deletions(-) diff --git a/lustre/tests/sanity-hsm.sh b/lustre/tests/sanity-hsm.sh index e0960bb..fd2f711 100755 --- a/lustre/tests/sanity-hsm.sh +++ b/lustre/tests/sanity-hsm.sh @@ -2132,7 +2132,6 @@ test_24c() { chown $RUNAS_ID:nobody $file || error "cannot chown '$file' to '$RUNAS_ID:nobody'" - set_hsm_param user_request_mask "" $RUNAS $LFS hsm_$action $file && error "$action by user should fail" @@ -2146,7 +2145,6 @@ test_24c() { chown nobody:$RUNAS_GID $file || error "cannot chown '$file' to 'nobody:$RUNAS_GID'" - set_hsm_param group_request_mask "" $RUNAS $LFS hsm_$action $file && error "$action by group should fail" @@ -2160,7 +2158,6 @@ test_24c() { chown nobody:nobody $file || error "cannot chown '$file' to 'nobody:nobody'" - set_hsm_param other_request_mask "" $RUNAS $LFS hsm_$action $file && error "$action by other should fail" -- 1.8.3.1