From 804c5778e6069f067c9640014f03dcd30069f5ea Mon Sep 17 00:00:00 2001 From: Sebastien Buisson Date: Mon, 27 May 2013 17:05:28 +0200 Subject: [PATCH] LU-3404 build: fix 'incorrect expression' errors Fix 'program hangs' defects found by Coverity version 6.5.1: Array compared against 0 (NO_EFFECT) Comparing an array to null is not useful. Copy-paste error (COPY_PASTE_ERROR) This line looks like a copy-paste error. Self assignment (NO_EFFECT) Assignment operation has no effect. Side effect in assertion (ASSERT_SIDE_EFFECT) Assignment has a side effect. This code will work differently in a non-debug build. You might have intended to use a comparison instead. Wrong sizeof argument (SIZEOF_MISMATCH) Passing argument is suspicious. Signed-off-by: Sebastien Buisson Change-Id: Iad370305cb8540f7c1b918e53ceae32e9ccbba8f Reviewed-on: http://review.whamcloud.com/6465 Tested-by: Hudson Tested-by: Maloo Reviewed-by: Dmitry Eremin Reviewed-by: Andreas Dilger --- snmp/lustre-snmp-util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/snmp/lustre-snmp-util.c b/snmp/lustre-snmp-util.c index 93908a1..70d5ecd 100644 --- a/snmp/lustre-snmp-util.c +++ b/snmp/lustre-snmp-util.c @@ -766,7 +766,7 @@ extern int mds_stats_values(char * name_value, unsigned long long * nb_sample, u void convert_ull(counter64 *c64, unsigned long long ull, size_t *var_len) { - *var_len = sizeof(c64); + *var_len = sizeof(*c64); c64->low = (unsigned long long) (0x0ffffffff & ull); ull >>= 32; c64->high = (unsigned long long) (0x0ffffffff & ull); -- 1.8.3.1