From 79d4826a129a1f29585d50ee83e624aac7ea01a6 Mon Sep 17 00:00:00 2001 From: Eric Mei Date: Fri, 23 Apr 2010 12:48:07 -0600 Subject: [PATCH] b=22310 add a little more comment. r=adilger --- lustre/llite/rw.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lustre/llite/rw.c b/lustre/llite/rw.c index df40ae6..1884c01 100644 --- a/lustre/llite/rw.c +++ b/lustre/llite/rw.c @@ -747,7 +747,14 @@ int ll_readahead(const struct lu_env *env, struct cl_io *io, } if (end != 0) { unsigned long tmp_end; - /* Align RA window to optimal RPC boundary */ + /* + * Align RA window to an optimal boundary. + * + * XXX This would be better to align to cl_max_pages_per_rpc + * instead of PTLRPC_MAX_BRW_PAGES, because the RPC size may + * be aligned to the RAID stripe size in the future and that + * is more important than the RPC size. + */ tmp_end = ((end + 1) & (~(PTLRPC_MAX_BRW_PAGES - 1))) - 1; if (tmp_end > start) end = tmp_end; -- 1.8.3.1