From 6ee822d272a01e070684549eb01906801295259d Mon Sep 17 00:00:00 2001 From: Mr NeilBrown Date: Thu, 27 Feb 2020 13:59:27 +1100 Subject: [PATCH] LU-6142 fld: remove function typedefs typedefs a generally discouraged in upstream linux. fld_hash_func_t and fld_scan_func_t are only used once immediately after the definition, so having them doesn't help readability or maintainability at all. So remove them. Test-Parameters: trivial Signed-off-by: Mr NeilBrown Change-Id: I37288238f375d5673b7cb8d68d30102f43e44107 Reviewed-on: https://review.whamcloud.com/37740 Tested-by: jenkins Tested-by: Maloo Reviewed-by: James Simmons Reviewed-by: Shaun Tancheff Reviewed-by: Oleg Drokin --- lustre/fld/fld_internal.h | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/lustre/fld/fld_internal.h b/lustre/fld/fld_internal.h index 9579cfe..b8e9590 100644 --- a/lustre/fld/fld_internal.h +++ b/lustre/fld/fld_internal.h @@ -64,15 +64,12 @@ struct fld_stats { __u64 fst_cache; }; -typedef int (*fld_hash_func_t) (struct lu_client_fld *, __u64); - -typedef struct lu_fld_target * -(*fld_scan_func_t) (struct lu_client_fld *, __u64); - struct lu_fld_hash { - const char *fh_name; - fld_hash_func_t fh_hash_func; - fld_scan_func_t fh_scan_func; + const char *fh_name; + int (*fh_hash_func)(struct lu_client_fld *fld, + __u64 seq); + struct lu_fld_target * (*fh_scan_func)(struct lu_client_fld *fld, + __u64 seq); }; struct fld_cache_entry { -- 1.8.3.1