From 6ae6948f2e852fb6fcd9a4f61bfa388d88074c1f Mon Sep 17 00:00:00 2001 From: Emoly Liu Date: Thu, 20 Mar 2014 14:28:38 +0800 Subject: [PATCH] LU-4762 lctl: set_param should return error when value is null "lctl set_param" should return error when the parameter value is null. For example: "lctl set_param debug_mb" or "lctl set_param fail_loc=" Signed-off-by: Emoly Liu Change-Id: I5572c7a16803f1c4ba4449056b4dd2c476106bde Reviewed-on: http://review.whamcloud.com/9638 Tested-by: Jenkins Tested-by: Maloo Reviewed-by: Jian Yu Reviewed-by: Bobi Jam Reviewed-by: Oleg Drokin --- lustre/utils/lustre_cfg.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lustre/utils/lustre_cfg.c b/lustre/utils/lustre_cfg.c index 54312d4..720142b 100644 --- a/lustre/utils/lustre_cfg.c +++ b/lustre/utils/lustre_cfg.c @@ -1087,6 +1087,8 @@ int jt_lcfg_setparam(int argc, char **argv) *value = '\0'; value ++; path = argv[i]; + if (*value == '\0') + break; } else { /* format: set_param a b */ if (path == NULL) { @@ -1107,6 +1109,9 @@ int jt_lcfg_setparam(int argc, char **argv) if (rc2 < 0 && rc == 0) rc = rc2; } + if (path != NULL && (value == NULL || *value == '\0')) + fprintf(stderr, "error: %s: setting %s=: %s\n", + jt_cmdname(argv[0]), path, strerror(rc = EINVAL)); return rc; } -- 1.8.3.1