From 622b1b48a1fa9dc8c6954fa7ca596358b05af888 Mon Sep 17 00:00:00 2001 From: Andreas Dilger Date: Thu, 28 Jul 2011 16:13:53 -0600 Subject: [PATCH] LU-532 mdt: improve xattr ctime warning message Print out which xattr is not getting OBD_MD_FLCTIME set so that it is possible to track down what code path on the client is failing. Change-Id: I1918d2e8e0a1e03d8437846e823bca9df6f89b48 Signed-off-by: Andreas Dilger Reviewed-on: http://review.whamcloud.com/1161 Tested-by: Hudson Tested-by: Maloo Reviewed-by: Bobi Jam Reviewed-by: Oleg Drokin --- lustre/mdt/mdt_xattr.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lustre/mdt/mdt_xattr.c b/lustre/mdt/mdt_xattr.c index 6cfb1e2..f3b5537 100644 --- a/lustre/mdt/mdt_xattr.c +++ b/lustre/mdt/mdt_xattr.c @@ -369,8 +369,11 @@ int mdt_reint_setxattr(struct mdt_thread_info *info, GOTO(out_unlock, rc); if (unlikely(!(valid & OBD_MD_FLCTIME))) { - CWARN("client miss to set OBD_MD_FLCTIME when " - "setxattr: [object "DFID"] [valid "LPU64"]\n", + /* This isn't strictly an error, but all current clients + * should set OBD_MD_FLCTIME when setting attributes. */ + CWARN("%s: client miss to set OBD_MD_FLCTIME when " + "setxattr %s: [object "DFID"] [valid "LPU64"]\n", + info->mti_exp->exp_obd->obd_name, xattr_name, PFID(rr->rr_fid1), valid); attr->la_ctime = cfs_time_current_sec(); } -- 1.8.3.1