From 592d9a737bc19fbf0d3419ede32068cf8bf7677e Mon Sep 17 00:00:00 2001 From: "Mr. NeilBrown" Date: Fri, 16 Jul 2021 08:24:10 -0400 Subject: [PATCH] LU-9859 libcfs: make lnet_debugfs_symlink_def local to libcfs/modules.c This type is only used in libcfs/module.c, so make it local to there. If any other module ever wanted to add its own symlinks, it would probably be easiest to export lnet_debugfs_root and just call debugfs_create_symlink as required. Linux-commit: c4f907719736b720aa831447828809840e533371 Test-Parameters: trivial Change-Id: I08221cfc781735451a292ba20cd35b9172fc20f2 Signed-off-by: Mr. NeilBrown Signed-off-by: Greg Kroah-Hartman Reviewed-on: https://review.whamcloud.com/44332 Tested-by: jenkins Reviewed-by: Andreas Dilger Tested-by: Maloo Reviewed-by: Arshad Hussain --- libcfs/include/libcfs/libcfs.h | 5 ----- libcfs/libcfs/module.c | 5 +++++ 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/libcfs/include/libcfs/libcfs.h b/libcfs/include/libcfs/libcfs.h index cd781f6..862c404 100644 --- a/libcfs/include/libcfs/libcfs.h +++ b/libcfs/include/libcfs/libcfs.h @@ -85,11 +85,6 @@ int libcfs_ioctl_data_adjust(struct libcfs_ioctl_data *data); extern struct workqueue_struct *cfs_rehash_wq; -struct lnet_debugfs_symlink_def { - const char *name; - const char *target; -}; - void lnet_insert_debugfs(struct ctl_table *table); void lnet_remove_debugfs(struct ctl_table *table); diff --git a/libcfs/libcfs/module.c b/libcfs/libcfs/module.c index f966e61..0554cc9 100644 --- a/libcfs/libcfs/module.c +++ b/libcfs/libcfs/module.c @@ -56,6 +56,11 @@ #include #include "tracefile.h" +struct lnet_debugfs_symlink_def { + const char *name; + const char *target; +}; + static struct dentry *lnet_debugfs_root; BLOCKING_NOTIFIER_HEAD(libcfs_ioctl_list); -- 1.8.3.1