From 3654682c02f349944abbf6aacac5b83d6b0bf82d Mon Sep 17 00:00:00 2001 From: Elena Gryaznova Date: Tue, 5 Oct 2010 00:15:38 +0400 Subject: [PATCH] b=21927 t-f: use the global variables for facets mount points i=Andreas.Dilger --- lustre/tests/test-framework.sh | 46 ++++++++++++++++++++++++++++++++---------- 1 file changed, 35 insertions(+), 11 deletions(-) diff --git a/lustre/tests/test-framework.sh b/lustre/tests/test-framework.sh index b1ac4ed..77b3724 100644 --- a/lustre/tests/test-framework.sh +++ b/lustre/tests/test-framework.sh @@ -542,11 +542,13 @@ mount_facet() { shift local dev=$(facet_active $facet)_dev local opt=${facet}_opt - echo "Starting ${facet}: ${!opt} $@ ${!dev} ${MOUNT%/*}/${facet}" - do_facet ${facet} mount -t lustre ${!opt} $@ ${!dev} ${MOUNT%/*}/${facet} + local mntpt=$(facet_mntpt $facet) + + echo "Starting ${facet}: ${!opt} $@ ${!dev} $mntpt" + do_facet ${facet} mount -t lustre ${!opt} $@ ${!dev} $mntpt RC=${PIPESTATUS[0]} if [ $RC -ne 0 ]; then - echo "mount -t lustre $@ ${!dev} ${MOUNT%/*}/${facet}" + echo "mount -t lustre $@ ${!dev} $mntpt" echo "Start of ${!dev} on ${facet} failed ${RC}" else do_facet ${facet} "lctl set_param debug=\\\"$PTLDEBUG\\\"; \ @@ -578,7 +580,9 @@ start() { eval export ${facet}failover_dev=$device fi - do_facet ${facet} mkdir -p ${MOUNT%/*}/${facet} + local mntpt=$(facet_mntpt $facet) + do_facet ${facet} mkdir -p $mntpt + eval export ${facet}_MOUNT=$mntpt mount_facet ${facet} RC=$? return $RC @@ -588,13 +592,14 @@ stop() { local running local facet=$1 shift - HOST=`facet_active_host $facet` + local HOST=`facet_active_host $facet` [ -z $HOST ] && echo stop: no host for $facet && return 0 - running=$(do_facet ${facet} "grep -c ${MOUNT%/*}/${facet}' ' /proc/mounts") || true + local mntpt=$(facet_mntpt $facet) + running=$(do_facet ${facet} "grep -c $mntpt' ' /proc/mounts") || true if [ ${running} -ne 0 ]; then - echo "Stopping ${MOUNT%/*}/${facet} (opts:$@)" - do_facet ${facet} umount -d $@ ${MOUNT%/*}/${facet} + echo "Stopping $mntpt (opts:$@)" + do_facet ${facet} umount -d $@ $mntpt fi # umount should block, but we should wait for unrelated obd's @@ -770,12 +775,12 @@ sanity_mount_check_servers () { # FIXME: modify get_facets to display all facets wo params local facets="$(get_facets OST),$(get_facets MDS),mgs" local node - local mnt + local mntpt local facet for facet in ${facets//,/ }; do node=$(facet_host ${facet}) - mnt=${MOUNT%/*}/${facet} - sanity_mount_check_nodes $node $mnt || + mntpt=$(facet_mntpt $facet) + sanity_mount_check_nodes $node $mntpt || { error "server $node environments are insane!"; return 1; } done } @@ -1725,6 +1730,14 @@ mdsdevname() { echo -n $DEVPTR } +facet_mntpt () { + local facet=$1 + local var=${facet}_MOUNT + eval mntpt=${!var:-${MOUNT%/*}/$facet} + + echo -n $mntpt +} + ######## ## MountConf setup @@ -2044,6 +2057,17 @@ init_facet_vars () { else eval export ${facet}failover_dev=$device fi + + # get mount point of already mounted device + # is facet_dev is already mounted then use the real + # mount point of this facet; otherwise use $(facet_mntpt $facet) + # i.e. ${facet}_MOUNT if specified by user or default + local mntpt=$(do_facet ${facet} cat /proc/mounts | \ + awk '"'${!dev}'" == $1 && $3 == "lustre" { print $2 }') + if [ -z $mntpt ]; then + mntpt=$(facet_mntpt $facet) + fi + eval export ${facet}_MOUNT=$mntpt } init_facets_vars () { -- 1.8.3.1