From 2f8d7b4679de3fa467040aa61733f262714e39c9 Mon Sep 17 00:00:00 2001 From: Andreas Dilger Date: Wed, 5 Dec 2018 17:15:05 -0700 Subject: [PATCH 1/1] LU-11736 utils: don't set max_sectors_kb on MDT/MGT The max_sectors_kb tunable should not be applied to MDT and MGT devices. This tuning is needed for efficiency of large IOs for spinning disks, but is not needed for SSDs or regular IO. It can cause problems with DM Multipath configurations for minimal benefits, so should be limited to OST devices. This only applies to ldiskfs backend filesystems, no such tuning is currently done for any ZFS devices. Test-Parameters: trivial testlist=conf-sanity Signed-off-by: Andreas Dilger Change-Id: I496603da13aae042f63cc37c0dea221a393ebbe5 Reviewed-on: https://review.whamcloud.com/33796 Tested-by: Jenkins Tested-by: Maloo Reviewed-by: Nathaniel Clark Reviewed-by: Wang Shilong Reviewed-by: Gu Zheng Reviewed-by: Oleg Drokin --- lustre/utils/libmount_utils_ldiskfs.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lustre/utils/libmount_utils_ldiskfs.c b/lustre/utils/libmount_utils_ldiskfs.c index 5fece46..c1f79ae 100644 --- a/lustre/utils/libmount_utils_ldiskfs.c +++ b/lustre/utils/libmount_utils_ldiskfs.c @@ -1238,6 +1238,13 @@ static int tune_block_dev(const char *src, struct mount_opts *mop) char *real_sys_path = NULL; int rc; + /* + * Don't apply block device tuning for MDT or MGT devices, + * since we don't need huge IO sizes to get good performance + */ + if (!IS_OST(&mop->mo_ldd)) + return 0; + if (src == NULL) return EINVAL; @@ -1267,8 +1274,7 @@ static int tune_block_dev(const char *src, struct mount_opts *mop) goto have_whole_dev; if (verbose) - fprintf(stderr, - "warning: cannot access '%s': %s\n", + fprintf(stderr, "warning: cannot access '%s': %s\n", partition_path, strerror(errno)); rc = errno; goto out; -- 1.8.3.1