From 26457eac6bebda83893a72a2dac6ecc0b28813ed Mon Sep 17 00:00:00 2001 From: "John L. Hammond" Date: Tue, 8 Apr 2014 15:44:01 -0500 Subject: [PATCH] LU-4872 build: warn on LASSERT and CERROR in checkpatch.pl In contrib/scripts/checkpatch.pl emit a warning on new LASSERT statements and new LCONSOLE*() messages. Also ask the submitter to think hard before adding new CERROR, CWARN, CEMERG messages. Signed-off-by: John L. Hammond Change-Id: I8ebcde6af64cdf1c0669bdc5fd0b0a9abeae6066 Reviewed-on: http://review.whamcloud.com/9914 Tested-by: Jenkins Tested-by: Maloo Reviewed-by: Prakash Surya Reviewed-by: Andreas Dilger --- contrib/scripts/checkpatch.pl | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/contrib/scripts/checkpatch.pl b/contrib/scripts/checkpatch.pl index b766319..893619f 100755 --- a/contrib/scripts/checkpatch.pl +++ b/contrib/scripts/checkpatch.pl @@ -3091,6 +3091,27 @@ sub process { } } +# try to replace assertions with error handling + if ($line =~ /\bLASSERTF?\s*\(/) { + WARN("LASSERT", + "try to replace assertions with error handling\n" . + $herecurr); + } + +# avoid new console messages + if ($line =~ /\bLCONSOLE[A-Z_]*\s*\(/) { + WARN("LCONSOLE", + "avoid adding new console messages\n" . + $herecurr); + } + +# minimize new CERROR messages + if ($line =~ /\bC(EMERG|ERROR|NETERR|WARN)\s*\(/) { + WARN("LCONSOLE", + "think hard before adding new CERROR messages\n" . + $herecurr); + } + # no volatiles please my $asm_volatile = qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b}; if ($line =~ /\bvolatile\b/ && $line !~ /$asm_volatile/) { -- 1.8.3.1