From 08827d622325db02072d3a9757475f0c416da329 Mon Sep 17 00:00:00 2001 From: Elena Gryaznova Date: Mon, 24 May 2021 18:14:26 +0300 Subject: [PATCH] LU-14701 tests: wrong get[set]_osd_param() call sanity-dom:sanityn:test_19 is always skipped because of get_osd_param() is called incorrectly for DOM=yes. For osd-* MDT device is to be used instead of default device=${2:-$FSNAME-OST*} Fixes: a7625cd2f37a ("LU-3285 test: add Data-on-MDT tests and fixes") Test-Parameters: trivial testlist=sanity-dom env=ONLY=sanityn Test-Parameters: trivial testlist=sanityn env=ONLY=19 Signed-off-by: Elena Gryaznova HPE-bug-id: LUS-9965 Reviewed-by: Alexander Boyko Reviewed-by: Alexander Zarochentsev Change-Id: I2bb9fc7fbaac966ea2254071e7ea82b963a93ad3 Reviewed-on: https://review.whamcloud.com/43774 Tested-by: jenkins Reviewed-by: Mike Pershin Tested-by: Maloo Reviewed-by: Oleg Drokin --- lustre/tests/sanityn.sh | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/lustre/tests/sanityn.sh b/lustre/tests/sanityn.sh index 860a4a9..ca804b6 100755 --- a/lustre/tests/sanityn.sh +++ b/lustre/tests/sanityn.sh @@ -568,15 +568,18 @@ run_test 18 "mmap sanity check =================================" test_19() { # bug3811 local node=$(facet_active_host ost1) + local device="$FSNAME-OST*" - [ "x$DOM" = "xyes" ] && node=$(facet_active_host $SINGLEMDS) + [ "x$DOM" = "xyes" ] && node=$(facet_active_host $SINGLEMDS) && + device="$FSNAME-MDT*" # check whether obdfilter is cache capable at all - get_osd_param $node '' read_cache_enable >/dev/null || + get_osd_param $node $device read_cache_enable >/dev/null || skip "not cache-capable obdfilter" - local MAX=$(get_osd_param $node '' readcache_max_filesize | head -n 1) - set_osd_param $node '' readcache_max_filesize 4096 + local max=$(get_osd_param $node $device readcache_max_filesize |\ + head -n 1) + set_osd_param $node $device readcache_max_filesize 4096 dd if=/dev/urandom of=$TMP/$tfile bs=512k count=32 local SUM=$(cksum $TMP/$tfile | cut -d" " -f 1,2) cp $TMP/$tfile $DIR1/$tfile @@ -591,7 +594,7 @@ test_19() { # bug3811 [ "$(cat $TMP/sum2)" = "$SUM" ] || \ error "$DIR2/$tfile $(cat $TMP/sum2) != $SUM" done - set_osd_param $node '' readcache_max_filesize $MAX + set_osd_param $node $device readcache_max_filesize $max rm $DIR1/$tfile } run_test 19 "test concurrent uncached read races ===============" -- 1.8.3.1