From 0024460d797490ae90a2221cb5d4648c9d4fac82 Mon Sep 17 00:00:00 2001 From: Mr NeilBrown Date: Thu, 6 May 2021 10:19:30 +1000 Subject: [PATCH] LU-12678 o2iblnd: fix bug in list_first_entry() change. This comparison should be != NULL, else a NULL pointer could be dereferenced. Test-Parameters: trivial Fixes: 34b57a6f8fcd ("LU-12678 lnet: use list_first_entry() in lnet/klnds subdirectory.") Signed-off-by: Mr NeilBrown Change-Id: I4510e2e0f2eb7b5bf86626e5ddb5ee537d3fae02 Reviewed-on: https://review.whamcloud.com/43558 Reviewed-by: Andreas Dilger Tested-by: jenkins Reviewed-by: James Simmons Tested-by: Maloo --- lnet/klnds/o2iblnd/o2iblnd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lnet/klnds/o2iblnd/o2iblnd.c b/lnet/klnds/o2iblnd/o2iblnd.c index ae84f06..82b8d10 100644 --- a/lnet/klnds/o2iblnd/o2iblnd.c +++ b/lnet/klnds/o2iblnd/o2iblnd.c @@ -2023,7 +2023,7 @@ kiblnd_fail_poolset(struct kib_poolset *ps, struct list_head *zombies) spin_lock(&ps->ps_lock); while ((po = list_first_entry_or_null(&ps->ps_pool_list, struct kib_pool, - po_list)) == NULL) { + po_list)) != NULL) { po->po_failed = 1; if (po->po_allocated == 0) list_move(&po->po_list, zombies); -- 1.8.3.1