From 982eca73a960131b4a12e528419e09a1fac90b30 Mon Sep 17 00:00:00 2001 From: Arshad Hussain Date: Wed, 1 Nov 2023 13:23:54 +0530 Subject: [PATCH] LU-17000 coverity: Fix Logically dead code under liblnetconfig.c This patch fixes Logically dead code check reported by coverity run. CoverityID: 404752 ("Logically dead code") Test-Parameters: trivial testlist=sanity-lnet Signed-off-by: Arshad Hussain Change-Id: I5a435324a19e04805c2a7c555ac2a0c1433ce2d0 Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/52950 Tested-by: jenkins Tested-by: Maloo Reviewed-by: James Simmons Reviewed-by: Andreas Dilger Reviewed-by: Oleg Drokin --- lnet/utils/lnetconfig/liblnetconfig.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/lnet/utils/lnetconfig/liblnetconfig.c b/lnet/utils/lnetconfig/liblnetconfig.c index 24215be..c759f7b 100644 --- a/lnet/utils/lnetconfig/liblnetconfig.c +++ b/lnet/utils/lnetconfig/liblnetconfig.c @@ -1740,11 +1740,6 @@ int lustre_lnet_parse_nid_range(struct nid_node *head, char *nidstr, while ((nid = strsep(&nidstr, "@")) != NULL) { char *tmp = NULL, *tmp2 = NULL, *end = NULL; - if (!nid) { - *errmsg = "Unable to parse nidlist: no proper NID string"; - return -ENOENT; - } - tmp = strchr(nid, '['); tmp2 = strchr(nid, ']'); -- 1.8.3.1