From fac57894c7f237794a6fb247bae90674b2ae3491 Mon Sep 17 00:00:00 2001 From: Alex Zhuravlev Date: Wed, 27 Mar 2024 20:19:03 +0300 Subject: [PATCH] LU-17683 lnet: ksocknal_startup() leaks iface table which is allocated in lnet_inet_enumerate() Signed-off-by: Alex Zhuravlev Change-Id: Ib25402bb82a33c5f4838fc5bd9e9a22c806df89a Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/54590 Reviewed-by: Andreas Dilger Reviewed-by: James Simmons Reviewed-by: Oleg Drokin Tested-by: jenkins Tested-by: Maloo --- lnet/klnds/o2iblnd/o2iblnd.c | 1 + lnet/klnds/socklnd/socklnd.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/lnet/klnds/o2iblnd/o2iblnd.c b/lnet/klnds/o2iblnd/o2iblnd.c index be69163..993525d 100644 --- a/lnet/klnds/o2iblnd/o2iblnd.c +++ b/lnet/klnds/o2iblnd/o2iblnd.c @@ -3794,6 +3794,7 @@ kiblnd_startup(struct lnet_ni *ni) write_unlock_irqrestore(&kiblnd_data.kib_global_lock, flags); net->ibn_init = IBLND_INIT_ALL; + kfree(ifaces); return 0; diff --git a/lnet/klnds/socklnd/socklnd.c b/lnet/klnds/socklnd/socklnd.c index d22249b..cbcfeb7 100644 --- a/lnet/klnds/socklnd/socklnd.c +++ b/lnet/klnds/socklnd/socklnd.c @@ -2649,6 +2649,7 @@ ksocknal_startup(struct lnet_ni *ni) list_add(&net->ksnn_list, &ksocknal_data.ksnd_nets); net->ksnn_ni = ni; ksocknal_data.ksnd_nnets++; + kfree(ifaces); return 0; @@ -2657,6 +2658,7 @@ out_net: out_base: if (ksocknal_data.ksnd_nnets == 0) ksocknal_base_shutdown(); + kfree(ifaces); return -ENETDOWN; } -- 1.8.3.1