Whamcloud - gitweb
fs/lustre-release.git
5 years agoLU-6055 hsm: improve error handling in sanity-hsm 54/13154/2
John L. Hammond [Fri, 19 Dec 2014 16:44:05 +0000 (10:44 -0600)]
LU-6055 hsm: improve error handling in sanity-hsm

In path2fid() propagate errors from 'lfs path2fid'.  In
file_creation_failure() redirect the output of df to stderr so that it
is not captured by command substitution.

Signed-off-by: John L. Hammond <john.hammond@intel.com>
Change-Id: I7fabf46af4aa36c6affef45cf8c9b044a7aa29dd
Reviewed-on: http://review.whamcloud.com/13154
Tested-by: Jenkins
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
5 years agoLU-5648 ofd: In destroy orphan case always let MDS know last id 67/12067/3
Oleg Drokin [Fri, 26 Sep 2014 02:15:36 +0000 (22:15 -0400)]
LU-5648 ofd: In destroy orphan case always let MDS know last id

It appears that if we think MDS asked us to delete too many
precreate objects (more than 2 MAX_PRECREATE counts)
then we don't do the precreation, but do not let MDS know it needs
to advance the last_id forward by quite a bit.
This lead to reassigning these objects to other files after recovery.

Change-Id: Icbd5b9e3cd81129f56ee5cd3aafd5f418affbecc
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Reviewed-on: http://review.whamcloud.com/12067
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Alex Zhuravlev <alexey.zhuravlev@intel.com>
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
5 years agoLU-6035 kernel: kernel update RHEL6.6 [2.6.32-504.3.3.el6] 06/13106/3
Bob Glossman [Tue, 16 Dec 2014 21:18:19 +0000 (13:18 -0800)]
LU-6035 kernel: kernel update RHEL6.6 [2.6.32-504.3.3.el6]

Update RHEL6.6 kernel to 2.6.32-504.3.3.el6

Test-Parameters: clientdistro=el6.6 mdsdistro=el6.6\
  ossdistro=el6.6 mdsfilesystemtype=ldiskfs\
  mdtfilesystemtype=ldiskfs ostfilesystemtype=ldiskfs

Signed-off-by: Bob Glossman <bob.glossman@intel.com>
Change-Id: I07f3a84b776e3bcd8f1b7ba2250e0bbb3d47f010
Reviewed-on: http://review.whamcloud.com/13106
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Tested-by: Jenkins
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5528 ptlrpc: fix race between connect vs resend 23/11723/12
Alexander.Boyko [Wed, 20 Aug 2014 13:07:35 +0000 (17:07 +0400)]
LU-5528 ptlrpc: fix race between connect vs resend

Buggy code at ptlrpc_connect_interpret()
finish:
rc = ptlrpc_import_recovery_state_machine(imp);
...
Set import connection flags
When import has FULL state ptlrpc_import_recovery_state_machine()
wakeup all waiters on import and all delayed request, which was
resented. And it could happened that request was send without
updated flags and AT is disabled. If such request is in progress
on the server, server drop the new instance, and could do early reply
for it. But this early reply confuse client, cause it wait real
reply(no AT for this request). Client try to touch buffer outside
reply and got EPROTO error.
The same bug existed for initital connect too. Import became FULL
before import connection flags was set.

Signed-off-by: Alexander Boyko <alexander_boyko@xyratex.com>
Xyratex-bug-id: MRP-2034
Change-Id: Ic6959e3194c23bdd88a7da1a8f0ea9b4cd4285f0
Reviewed-on: http://review.whamcloud.com/11723
Reviewed-by: Li Wei <wei.g.li@intel.com>
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Alexander Boyko <alexander.boyko@seagate.com>
Reviewed-by: Liang Zhen <liang.zhen@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5773 test: reduce thread count 78/13078/4
Niu Yawei [Tue, 16 Dec 2014 02:59:55 +0000 (21:59 -0500)]
LU-5773 test: reduce thread count

Reduce thread count for the test_1c of obdfilter-survery test to
prevent OOM on vm.

Test-Parameters: alwaysuploadlogs \
envdefinitions=SLOW=yes,ENABLE_QUOTA=yes \
mdtfilesystemtype=ldiskfs mdsfilesystemtype=ldiskfs ostfilesystemtype=ldiskfs \
mdtcount=1 testlist=obdfilter-survey,obdfilter-survey,obdfilter-survey

Signed-off-by: Niu Yawei <yawei.niu@intel.com>
Change-Id: I83926a538827dea6682bd0f84434ba5d351cfd88
Reviewed-on: http://review.whamcloud.com/13078
Tested-by: Jenkins
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Jian Yu <jian.yu@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-6024 nodemap: fix ACL handling in mdt_finish_open 62/13062/3
Kit Westneat [Sat, 13 Dec 2014 16:11:53 +0000 (11:11 -0500)]
LU-6024 nodemap: fix ACL handling in mdt_finish_open

This patch adds ACL mapping code to mdt_finish_open so that clients
get a correctly mapped list. The code is essentially the same as in
mdt_getattr_internal.

Signed-off-by: Kit Westneat <kit.westneat@gmail.com>
Change-Id: I3cf0ba2128ba8c4027359329f423d2327005f082
Reviewed-on: http://review.whamcloud.com/13062
Tested-by: Jenkins
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Nathaniel Clark <nathaniel.l.clark@intel.com>
Reviewed-by: Andrew Perepechko <andrew.perepechko@seagate.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-6023 build: fix libselinux support 30/13030/5
Dmitry Eremin [Thu, 11 Dec 2014 13:17:59 +0000 (16:17 +0300)]
LU-6023 build: fix libselinux support

Enabling correct libselinux-devel detection by searching for
the same header file in autoconf that is used in code.

Link mount_osd_ldiskfs.so with -lselinux.

Signed-off-by: Dmitry Eremin <dmitry.eremin@intel.com>
Change-Id: I085e91464a263b6d1b1be13971e54dfc80a4e347
Reviewed-on: http://review.whamcloud.com/13030
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: James Simmons <uja.ornl@gmail.com>
5 years agoLU-4660 osd-ldiskfs: fix osd_bufs_get() error handling 44/9344/7
Andriy Skylysh [Tue, 16 Dec 2014 03:16:50 +0000 (20:16 -0700)]
LU-4660 osd-ldiskfs: fix osd_bufs_get() error handling

Unlock pages just locked during cleanup if page loading failed.

Clean up code style, add function comment blocks.

Signed-off-by: Andriy Skulysh <Andriy_Skulysh@xyratex.com>
Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Change-Id: Ie523b0cfea30bc55ecd58db0849b1b005a393fc7
Reviewed-on: http://review.whamcloud.com/9344
Tested-by: Jenkins
Reviewed-by: Bobi Jam <bobijam@gmail.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-6058 test: log to stderr 55/13155/2
John L. Hammond [Fri, 19 Dec 2014 18:09:51 +0000 (12:09 -0600)]
LU-6058 test: log to stderr

In test-framework.sh's log() function print the message to stderr
instead of stdout. This ensures that the message will not be not
captured by command substitution. Similarly print bash stack traces to
stderr from error().

Signed-off-by: John L. Hammond <john.hammond@intel.com>
Change-Id: If9ca4af1c8d66f9bb3767f4fc3c04fb6966de915
Reviewed-on: http://review.whamcloud.com/13155
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Jian Yu <jian.yu@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
5 years agoLU-5916 lod: inherit default pool setting properly 46/12746/7
Niu Yawei [Mon, 17 Nov 2014 06:59:44 +0000 (01:59 -0500)]
LU-5916 lod: inherit default pool setting properly

When parent directory has no default striping but has only
default pool setting, the pool setting should be inherited
by subdir properly.

This patch fixed the problem by changing the
LOVEA_DELETE_VALUES() to check pool name as well, and it
removed the unused function lod_store_def_striping().

Signed-off-by: Niu Yawei <yawei.niu@intel.com>
Change-Id: I7ce5251b6c601309aeb91a1b903bde02d0712e25
Reviewed-on: http://review.whamcloud.com/12746
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: wangdi <di.wang@intel.com>
Reviewed-by: Alex Zhuravlev <alexey.zhuravlev@intel.com>
5 years agoLU-5814 lov: flatten struct lov_stripe_md 81/12581/2
John L. Hammond [Wed, 5 Nov 2014 17:40:02 +0000 (11:40 -0600)]
LU-5814 lov: flatten struct lov_stripe_md

Flatten out the lsm_wire struct from the middle of struct
lov_stripe_md and remove the member name macros.

Signed-off-by: John L. Hammond <john.hammond@intel.com>
Change-Id: I53455d4f42860d4c7e5541f1f18b0c451a022c28
Reviewed-on: http://review.whamcloud.com/12581
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Bobi Jam <bobijam@gmail.com>
Reviewed-by: Jinshan Xiong <jinshan.xiong@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5971 llite: merge lclient.h into llite/vvp_internal.h 92/12592/6
John L. Hammond [Tue, 4 Nov 2014 22:03:36 +0000 (16:03 -0600)]
LU-5971 llite: merge lclient.h into llite/vvp_internal.h

Move the definition of struct cl_client_cache to
lustre/include/cl_object.h and move the rest of
lustre/include/lclient.h in to lustre/llite/vvp_internal.h.

Signed-off-by: John L. Hammond <john.hammond@intel.com>
Change-Id: Ib3ca8f1693c517a77c5bfd7c7cced9bfc440c747
Reviewed-on: http://review.whamcloud.com/12592
Reviewed-by: Jinshan Xiong <jinshan.xiong@intel.com>
Tested-by: Jenkins
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-4536 tests: disable sanity test_65ic for ZFS 14/13114/2
Andreas Dilger [Thu, 18 Dec 2014 00:42:04 +0000 (17:42 -0700)]
LU-4536 tests: disable sanity test_65ic for ZFS

Disable sanity.sh test_65ic due to frequent test timeouts on
review-zfs testing.  This will allow the rest of the tests to be
enforced, and will allow this problem to be debugged separately.

Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Change-Id: I1ea93b5c2dfb0a3bbe0265a283ab7512044d6cd2
Reviewed-on: http://review.whamcloud.com/13114
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Nathaniel Clark <nathaniel.l.clark@intel.com>
Reviewed-by: Doug Oucharek <doug.s.oucharek@intel.com>
5 years agoLU-5396 obdclass: make some functions static 20/12220/12
Frank Zago [Thu, 11 Dec 2014 16:49:04 +0000 (11:49 -0500)]
LU-5396 obdclass: make some functions static

Some functions and variables are only used in their C file, so reduce
their scope. This reduces the code size, and fixes sparse warnings
such as:

  warning: symbol 'proc_lnet_routes' was not declared.
      Should it be static?
  warning: symbol 'proc_lnet_routers' was not declared.
      Should it be static?

Some prototypes were removed from C files and added to the proper
header.

Signed-off-by: Frank Zago <fzago@cray.com>
Change-Id: I35a7ae4d9efd7098d93d3500f4854ef074fce179
Reviewed-on: http://review.whamcloud.com/12220
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-6028 ldlm: move LDLM_GID_ANY to lustre_dlm.h 74/13074/2
Jinshan Xiong [Mon, 15 Dec 2014 20:48:23 +0000 (12:48 -0800)]
LU-6028 ldlm: move LDLM_GID_ANY to lustre_dlm.h

lustre_idl.h only includes wire data; lustre_dlm.h is the
right place for LDLM_GID_ANY.

Signed-off-by: Jinshan Xiong <jinshan.xiong@intel.com>
Change-Id: I832796e924116e80c079494f6928c037e7e4f2aa
Reviewed-on: http://review.whamcloud.com/13074
Tested-by: Jenkins
Reviewed-by: Bobi Jam <bobijam@gmail.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-3963 libcfs: Use kernel's strncasecmp and remove cfs_get_blocked_sigs 70/13070/3
James Simmons [Mon, 15 Dec 2014 19:15:43 +0000 (14:15 -0500)]
LU-3963 libcfs: Use kernel's strncasecmp and remove cfs_get_blocked_sigs

Remove libcfs function cfs_strncasecmp() since the kernel
already has its own strncasecmp(). Lastly remove from libcfs.h
cfs_get_blocked_sigs() since this function no longer exist.

Change-Id: Ief5bac8ac23114c8e34d988906b06dda8eb77306
Signed-off-by: James Simmons <uja.ornl@gmail.com>
Reviewed-on: http://review.whamcloud.com/13070
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Tested-by: Jenkins
Reviewed-by: Patrick Farrell <paf@cray.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-6001 build: fix autoconf DLC detection output 31/13031/2
Dmitry Eremin [Thu, 11 Dec 2014 13:27:21 +0000 (16:27 +0300)]
LU-6001 build: fix autoconf DLC detection output

checking for yaml_parser_initialize in -lyaml... no
checking whether to enable dlc... yes
no (libyaml not present)

Signed-off-by: Dmitry Eremin <dmitry.eremin@intel.com>
Change-Id: I29b968295b508522f9158ac920ee3bb862ae4b4e
Reviewed-on: http://review.whamcloud.com/13031
Tested-by: Jenkins
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Amir Shehata <amir.shehata@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5651 test: run replay-single test 93 only when supported. 42/12942/5
James Simmons [Thu, 11 Dec 2014 15:13:14 +0000 (10:13 -0500)]
LU-5651 test: run replay-single test 93 only when supported.

The new test for replay-single will only work for lustre
versions that contain commit f61cec84. This patch does
lustre version checking to over failing on platforms that
are not fixed.

Change-Id: I0feffb4b3c131db68c115a111bc87a229bda23e3
Signed-off-by: James Simmons <uja.ornl@gmail.com>
Reviewed-on: http://review.whamcloud.com/12942
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Jian Yu <jian.yu@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-2675 mdc: remove mdc_sendpage() 93/12893/2
John L. Hammond [Mon, 1 Dec 2014 19:57:06 +0000 (13:57 -0600)]
LU-2675 mdc: remove mdc_sendpage()

Remove the unused function mdc_sendpage() and supporting crud.

Signed-off-by: John L. Hammond <john.hammond@intel.com>
Change-Id: I09792c5b25f10351eead9e67d42de5821f4d7bc1
Reviewed-on: http://review.whamcloud.com/12893
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-2675 llapi: find_param cleanup part II 51/12851/3
John L. Hammond [Mon, 27 Oct 2014 19:40:29 +0000 (14:40 -0500)]
LU-2675 llapi: find_param cleanup part II

Add fp_ prefixes to the remaining members of struct find_param. Also
add underscores between words in several member names:
  obduuid -> fp_obd_uuid
  stripesize_units -> fp_stripe_size_units
  ...

Signed-off-by: John L. Hammond <john.hammond@intel.com>
Change-Id: Iaa62a6b44e2929f3925525a97fec0434243dec1b
Reviewed-on: http://review.whamcloud.com/12851
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
5 years agoLU-5577 ptlrpc: fix comparison between signed and unsigned 75/12475/6
Dmitry Eremin [Wed, 29 Oct 2014 14:17:03 +0000 (17:17 +0300)]
LU-5577 ptlrpc: fix comparison between signed and unsigned

Change return type and size argiments of lustre_msg_hdr_size(),
lustre_msg_buf{len,count}() and req_capsule_*_size() to __u32.
Change type of req_format->rf_idx and req_format->rf_fields.nr
to size_t. Also return zero for incorrect message magic instead
of -EINVAL. This will be more robust because of few of them after
LASSERTF(0, "...") and will not be returned. In the rest places
it return zero size instead of huge number after implicit
unsigned conversion.

Signed-off-by: Dmitry Eremin <dmitry.eremin@intel.com>
Change-Id: Iae8b83b4285a1ea2fa010f9de2792426c1772b2c
Reviewed-on: http://review.whamcloud.com/12475
Tested-by: Jenkins
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Fan Yong <fan.yong@intel.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5823 clio: add coo_getstripe interface 52/12452/19
Bobi Jam [Tue, 28 Oct 2014 03:30:38 +0000 (11:30 +0800)]
LU-5823 clio: add coo_getstripe interface

Use cl_object_operations::coo_getstripe() to handle
LL_IOC_LOV_GETSTRIPE ops.

Signed-off-by: Bobi Jam <bobijam.xu@intel.com>
Change-Id: Iee0d007f773ead35434eb88e7ca2f31c0bc42c11
Reviewed-on: http://review.whamcloud.com/12452
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Jinshan Xiong <jinshan.xiong@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5577 obdclass: do_body_ops->dbo_{read,write} return ssize_t 88/12388/4
Dmitry Eremin [Mon, 13 Oct 2014 17:22:00 +0000 (21:22 +0400)]
LU-5577 obdclass: do_body_ops->dbo_{read,write} return ssize_t

Fix warnings when use return value from do_body_ops->dbo_{read,write}.

Signed-off-by: Dmitry Eremin <dmitry.eremin@intel.com>
Change-Id: I6f3324e0799eff699b44e7b2b09ee4b3d2298c0d
Reviewed-on: http://review.whamcloud.com/12388
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5577 obdclass: (*dt_index_page_build_t) arg nob to size_t 82/12382/2
Dmitry Eremin [Fri, 10 Oct 2014 16:55:00 +0000 (20:55 +0400)]
LU-5577 obdclass: (*dt_index_page_build_t) arg nob to size_t

Change the type accordant usage and check for correct input.

Signed-off-by: Dmitry Eremin <dmitry.eremin@intel.com>
Change-Id: Ic80025e95eddbc9fb51efd83c54573e5f310bb0b
Reviewed-on: http://review.whamcloud.com/12382
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5577 obdclass: change cl_fault_io->ft_nob to size_t 80/12380/3
Dmitry Eremin [Fri, 10 Oct 2014 15:41:29 +0000 (19:41 +0400)]
LU-5577 obdclass: change cl_fault_io->ft_nob to size_t

Change the type accordant usage.

Signed-off-by: Dmitry Eremin <dmitry.eremin@intel.com>
Change-Id: I866b9e0fc24c1d2fd281b40d03e8b4d73f159e31
Reviewed-on: http://review.whamcloud.com/12380
Tested-by: Jenkins
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5577 libcfs: fix warnings in libcfs/curproc.h 79/12379/4
Dmitry Eremin [Fri, 10 Oct 2014 14:53:52 +0000 (18:53 +0400)]
LU-5577 libcfs: fix warnings in libcfs/curproc.h

Fix compiler warnings that annoying from searching other issues.

Signed-off-by: Dmitry Eremin <dmitry.eremin@intel.com>
Change-Id: I17cdc1d94b58d2c2f3284665090ad7eef991d5ac
Reviewed-on: http://review.whamcloud.com/12379
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Tested-by: Jenkins
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5577 obd: change brw_page->count to unsigned 78/12378/3
Dmitry Eremin [Wed, 5 Nov 2014 01:24:49 +0000 (20:24 -0500)]
LU-5577 obd: change brw_page->count to unsigned

Pages count is unsigned. So, change the type accordant usage.

Signed-off-by: Dmitry Eremin <dmitry.eremin@intel.com>
Change-Id: I71a9c9e31f90a7e6aa456801c6f47dc9ee9c0df2
Reviewed-on: http://review.whamcloud.com/12378
Tested-by: Jenkins
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-6029 test: add wrap up duration in conf-sanity test_84 87/13087/4
Dmitry Eremin [Tue, 16 Dec 2014 15:05:48 +0000 (18:05 +0300)]
LU-6029 test: add wrap up duration in conf-sanity test_84

The time of execution the function target_finish_recovery() can be
very long but "obd->obd_recovery_end = cfs_time_current_sec();" set
at the end. Therefore the recovery time always will be more than
hard limit and depends how long target_finish_recovery() function
was executed.

To avoid instability in test_84 just add 5 seconds as wrap up time.

Signed-off-by: Dmitry Eremin <dmitry.eremin@intel.com>
Change-Id: I53263f9a248429f59741f701fcc7b5b6d693325e
Reviewed-on: http://review.whamcloud.com/13087
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Nathaniel Clark <nathaniel.l.clark@intel.com>
Reviewed-by: Sergey Cheremencev <sergey_cheremencev@xyratex.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
5 years agoLU-5461 mdc: don't add to page cache upon failure 50/11450/7
Lai Siyao [Thu, 14 Aug 2014 13:22:50 +0000 (21:22 +0800)]
LU-5461 mdc: don't add to page cache upon failure

Reading directory pages may fail on MDS, in this case client should
not cache a non-up-to-date directory page, because it will cause
a later read on the same page fail.

Add sanity 242 for this.

Signed-off-by: Lai Siyao <lai.siyao@intel.com>
Change-Id: Icbb55c0ecc4b88913b08ac8998c2673ec15b18ea
Reviewed-on: http://review.whamcloud.com/11450
Tested-by: Jenkins
Reviewed-by: Fan Yong <fan.yong@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-4178 tests: add messages to sanity-hsm 13/8113/10
JC Lafoucriere [Mon, 3 Nov 2014 02:17:45 +0000 (21:17 -0500)]
LU-4178 tests: add messages to sanity-hsm

Add messages in case of file creation failure so we
can diagnose the failure.

Signed-off-by: JC Lafoucriere <jacques-charles.lafoucriere@cea.fr>
Change-Id: I080c4cbb6bfe5a65d964f32a36d7c1dba35d0c27
Reviewed-on: http://review.whamcloud.com/8113
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Reviewed-by: James Nunez <james.a.nunez@intel.com>
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
5 years agoLU-5771 ldiskfs: cleanup orphan inode in error path 49/12349/5
Wang Shilong [Mon, 20 Oct 2014 12:41:03 +0000 (20:41 +0800)]
LU-5771 ldiskfs: cleanup orphan inode in error path

Commit from upstream: 4538821993f4486c76090dfb377c60c0a0e71ba3

There were some error paths in ext4_delete_inode() which was not
dropping the inode from the orphan list.  This could lead to a BUG_ON
on umount when the orphan list is discovered to be non-empty.

Signed-off-by: Wang Shilong <wshilong@ddn.com>
Change-Id: Ica2c87ae378cc23eed70c1bfeb96db3852d218dc
Reviewed-on: http://review.whamcloud.com/12349
Tested-by: Jenkins
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
5 years agoLU-3852 tests: skip tests with large file when no room 56/12456/9
Bruno Faccini [Tue, 28 Oct 2014 13:50:00 +0000 (14:50 +0100)]
LU-3852 tests: skip tests with large file when no room

Strengthen sanity-hsm sub-tests using large files by skipping
then if not enough space instead to fail.

Also re-enable test_251, and test_[200,221,223b] (for LU-4178),
who have all been wrongly disabled because of their multiple
failures on an auto-test node with very low disk space for the
Servers VMs!!

Also fix a bug in sanity/test_56w that should not be run if
$OSTCOUNT < 2, that was triggered due to my very restictive
test environment osscount/ostcount=1 to limit the Lustre FS size
as much as possible.

Test-Parameters: ostcount=1 ostsizegb=1 envdefinitions=SLOW=yes
Test-Parameters: osscount=1 mdscount=1 testlist=sanity-hsm
Signed-off-by: Bruno Faccini <bruno.faccini@intel.com>
Change-Id: I26bc36e4304a916f29149e6ad19306ed59c9a616
Reviewed-on: http://review.whamcloud.com/12456
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: James Nunez <james.a.nunez@intel.com>
5 years agoLU-5242 tests: except sanity test_132 for ZFS 93/13093/2
Andreas Dilger [Tue, 16 Dec 2014 19:55:15 +0000 (12:55 -0700)]
LU-5242 tests: except sanity test_132 for ZFS

Sanity test_132() is failing regularly on ZFS, but SOM is not a
feature we support.  Disable this test until the problem can be
resolved.  The SOM functionality itself will continue to be tested
with ldiskfs, and should not be OSD-specific.

Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Change-Id: I8fa38d993be0ab5afd9f293d9878cb862fc50c46
Reviewed-on: http://review.whamcloud.com/13093
Tested-by: Jenkins
Reviewed-by: Nathaniel Clark <nathaniel.l.clark@intel.com>
5 years agoLU-6011 kernel: kernel update [RHEL7 3.10.0-123.13.1.el7] 22/13022/4
Bob Glossman [Wed, 10 Dec 2014 15:13:05 +0000 (07:13 -0800)]
LU-6011 kernel: kernel update [RHEL7 3.10.0-123.13.1.el7]

update RHEL7 kernel to 3.10.0-123.13.1.el7

Test-Parameters: clientdistro=el7 mdsfilesystemtype=ldiskfs\
      mdtfilesystemtype=ldiskfs ostfilesystemtype=ldiskfs

Signed-off-by: Bob Glossman <bob.glossman@intel.com>
Change-Id: I6f9234f982a97646fa38c350d4740672cfc331e7
Reviewed-on: http://review.whamcloud.com/13022
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Minh Diep <minh.diep@intel.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Yang Sheng <yang.sheng@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-4536 ldlm: Recalculate interval in ldlm_pool_recalc() 47/12547/4
Nathaniel Clark [Tue, 4 Nov 2014 02:26:33 +0000 (21:26 -0500)]
LU-4536 ldlm: Recalculate interval in ldlm_pool_recalc()

Instead of rechecking a static value, recalculate to see if pool stats
need to be updated.
Add newline so message will print instead of warning about missing
newline.

Test-Parameters: mdsfilesystemtype=zfs mdtfilesystemtype=zfs ostfilesystemtype=zfs testlist=sanity,sanity,sanity,sanity,sanity,sanity,sanity,sanity,sanity,sanity
Signed-off-by: Nathaniel Clark <nathaniel.l.clark@intel.com>
Change-Id: Ic31cc0c1d09a85a9bd5ee04ac34c388263190df1
Reviewed-on: http://review.whamcloud.com/12547
Tested-by: Jenkins
Reviewed-by: Lai Siyao <lai.siyao@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Jian Yu <jian.yu@intel.com>
5 years agoLU-5986 test: Ensure correct start for conf-sanity/84 16/13016/3
Nathaniel Clark [Wed, 10 Dec 2014 01:13:04 +0000 (20:13 -0500)]
LU-5986 test: Ensure correct start for conf-sanity/84

For review-zfs:
1) test 79 fails to reformat nodes
2) test 80 fails silently
3) test 84 chokes

Fix test 79 to reformat at end and fix 80 die when it should.

Signed-off-by: Nathaniel Clark <nathaniel.l.clark@intel.com>
Change-Id: I42c635fffd89eda9ccd6f3f9d739ff8ac75afcf6
Reviewed-on: http://review.whamcloud.com/13016
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Jian Yu <jian.yu@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-6012 scrub: NOT miss to auto detect inconsistent OI mapping 20/13020/2
Fan Yong [Sat, 27 Sep 2014 23:10:34 +0000 (07:10 +0800)]
LU-6012 scrub: NOT miss to auto detect inconsistent OI mapping

When full scrub is triggered automatically, its flags should
be set as SF_INCONSISTENT.

For lookup case, we should check whether current OI mapping is
consistent or not, even if the current OI scrub flags is NOT
SF_INCONSISTENT.

Signed-off-by: Fan Yong <fan.yong@intel.com>
Change-Id: I99ea077ae79fcdfedd7bb16c2a664714e0ea5ea3
Reviewed-on: http://review.whamcloud.com/13020
Tested-by: Jenkins
Tested-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Lai Siyao <lai.siyao@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
5 years agoLU-1445 lod: clean up lod_fld_lookup() return codes 27/12727/2
Andreas Dilger [Fri, 14 Nov 2014 21:06:34 +0000 (14:06 -0700)]
LU-1445 lod: clean up lod_fld_lookup() return codes

Don't return "rc" when it is known that this will always be "0".
This confuses the reader into thinking that this is an error path
when it is in fact a no-op shortcut that returns success.

Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Change-Id: Ie4571226b3e90c866b958cf6ab65f6077abcab07
Reviewed-on: http://review.whamcloud.com/12727
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5885 lfsck: deadlock when remove striped dir 41/12741/3
Fan Yong [Wed, 24 Sep 2014 09:30:56 +0000 (17:30 +0800)]
LU-5885 lfsck: deadlock when remove striped dir

There is potential deadlock race condition between removing
striped directory and namespace LFSCK. Consider the following
scenario:

1) The LFSCK thread obtained the master object firstly, at
   that time, the master object has not been destroyed yet.

2) One RPC service thread destroyed the master and all its
   slave objects (shards). Because the LFSCK is referencing
   the master object, then the master object will be marked
   as dying in RAM. On the other hand, the master object is
   referencing all its slave objects, then all slave objects
   will be marked as dying in RAM also.

3) The LFSCK thread tries to find some slave object with the
   master object referenced. Then it will find that the slave
   object is dying. According to the object visibility rules:
   the object with dying flag cannot be returned to others.
   So the LFSCK thread has to wait until the dying object has
   been purged from RAM, then it can allocate a new object (with
   the same FID) in RAM. Unfortunately, the LFSCK thread itself
   is referencing the master object, and cause the master object
   cannot be purged, then cause the slave object cannot be purged
   also. So the LFSCK thread will fall into deadlock.

To resolve such trouble, the LFSCK should use non-blocked version
lu_object_find() to locate the slave object of the striped dir,
and return failure immediately (instead of wait) when it finds
dying (slave) object.

This patch also contorls the async pipeline depth between the
LFSCK main engine and the namespace assistant thread to avoid
potential RAM pressure.

Some other code adjustment to avoid potential data overflow
that may cause weird LFSCK statistics information.

Signed-off-by: Fan Yong <fan.yong@intel.com>
Change-Id: I00c601eca8ade5d2e4260c729463f7ecdba0ed53
Reviewed-on: http://review.whamcloud.com/12741
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Lai Siyao <lai.siyao@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-3353 ptlrpc: Suppress error message when imp_sec is freed 00/10200/3
Amir Shehata [Thu, 8 May 2014 17:47:56 +0000 (10:47 -0700)]
LU-3353 ptlrpc: Suppress error message when imp_sec is freed

There is a race condition on client reconnect when the import
is being destroyed.  Some outstanding client bound requests
are being processed when the imp_sec has alread been freed.
Ensure to suppress the error message in import_sec_validate_get()
in that case

Signed-off-by: Amir Shehata <amir.shehata@intel.com>
Change-Id: I44bc27c804259d4e4b6564460318732113b251a9
Reviewed-on: http://review.whamcloud.com/10200
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-3573 osd-zfs: Only advance zap cursor as needed 04/12904/2
Nathaniel Clark [Wed, 5 Nov 2014 18:05:22 +0000 (13:05 -0500)]
LU-3573 osd-zfs: Only advance zap cursor as needed

Only advance the zap cursor when ozi_pos is not advanced, otherwise
occasionally the a file could get "lost" because the zap_cursor would
advance over it before the retrieve happened.  Handle '..' like '.'
when retrieving ZAP values.

Test-Parameters: mdtfilesystemtype=zfs mdsfilesystemtype=zfs ostfilesystemtype=zfs testlist=conf-sanity,conf-sanity,conf-sanity,conf-sanity
Signed-off-by: Nathaniel Clark <nathaniel.l.clark@intel.com>
Reviewed-by: Isaac Huang <he.huang@intel.com>
Reviewed-by: Alex Zhuravlev <alexey.zhuravlev@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Change-Id: I916573c70c8828bed6905b5eda9344b4a49b7f11
Reviewed-on: http://review.whamcloud.com/12904
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
5 years agoLU-4647 nodemap: add tests to sanity-sec for nodemap mapping 06/10406/23
Kit Westneat [Tue, 8 Jul 2014 18:57:40 +0000 (14:57 -0400)]
LU-4647 nodemap: add tests to sanity-sec for nodemap mapping

Added tests to sanity-sec.sh, as outlined in the original nodemap
spec. The tests currently only work with a single OSS node, but this
will be fixed in a future update. These tests test basic permissions
and quota handling of the nodemapper, as well as ACL mapping.

Signed-off-by: Kit Westneat <kit.westneat@gmail.com>
Change-Id: Ieb29091e5b3110593973a5eb03680e86a769b449
Reviewed-on: http://review.whamcloud.com/10406
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5373 test: ignore command return value in sanity test_33b 92/12992/2
Bob Glossman [Mon, 8 Dec 2014 19:48:22 +0000 (11:48 -0800)]
LU-5373 test: ignore command return value in sanity test_33b

Since the test is only looking for a panic and the command
used has different returns depending on kernel version,
ignore the command return value in all cases.

Signed-off-by: Bob Glossman <bob.glossman@intel.com>
Change-Id: I63e9d0589b1c11736c9afbb8bee8ea4e11b30a4f
Reviewed-on: http://review.whamcloud.com/12992
Tested-by: Jenkins
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Jian Yu <jian.yu@intel.com>
5 years agoLU-5909 kernel: kernel update RHEL6.6 [2.6.32-504.1.3.el6] 15/12815/4
Bob Glossman [Tue, 11 Nov 2014 23:16:03 +0000 (15:16 -0800)]
LU-5909 kernel: kernel update RHEL6.6 [2.6.32-504.1.3.el6]

Update RHEL6.6 kernel to 2.6.32-504.1.3.el6

Test-Parameters: clientdistro=el6.6 mdsdistro=el6.6\
  ossdistro=el6.6 mdsfilesystemtype=ldiskfs\
  mdtfilesystemtype=ldiskfs ostfilesystemtype=ldiskfs

Signed-off-by: Bob Glossman <bob.glossman@intel.com>
Change-Id: I6a320f2a2806b12ee7c07645bed212792965da99
Reviewed-on: http://review.whamcloud.com/12815
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Minh Diep <minh.diep@intel.com>
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5837 llite: ll_getparent cleanup 27/12527/6
Henri Doreau [Fri, 31 Oct 2014 23:04:19 +0000 (00:04 +0100)]
LU-5837 llite: ll_getparent cleanup

Avoid unneeded allocation. Get read-only attributes from the user
getparent structure and write the modified attributes only, instead
of populating a whole structure in kernel and copying it back.

Signed-off-by: Henri Doreau <henri.doreau@cea.fr>
Change-Id: Ifc0632870f80733194384d02d1b4962cdcd75658
Reviewed-on: http://review.whamcloud.com/12527
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: frank zago <fzago@cray.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5485 lnet: peer aliveness status and NI status 53/12453/4
Liang Zhen [Tue, 28 Oct 2014 10:04:51 +0000 (18:04 +0800)]
LU-5485 lnet: peer aliveness status and NI status

A couple of changes to improve aliveness detection:
- When LNet received a message, it can determine peer of this message
  is alive

- When LNet recieved a message from remote network, it can determine
  router is alive and NI status on router is UP.

Signed-off-by: Liang Zhen <liang.zhen@intel.com>
Change-Id: I7133987c5c8728248cce7bc0a95048b26bc6611a
Reviewed-on: http://review.whamcloud.com/12453
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Reviewed-by: Isaac Huang <he.huang@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5932 tests: load sunrpc module before insmod ptlrpc_gss 90/12790/2
Jian Yu [Wed, 19 Nov 2014 21:10:10 +0000 (13:10 -0800)]
LU-5932 tests: load sunrpc module before insmod ptlrpc_gss

Lustre ptlrpc_gss module depends on Linux kernel sunrpc module.
This patch fixes load_module() in test-framework.sh to load the
sunrpc module before loading ptlrpc_gss module by using insmod.

Signed-off-by: Jian Yu <jian.yu@intel.com>
Change-Id: Idf22fa9023a2fada9038e16fbc3e8a61530266bc
Reviewed-on: http://review.whamcloud.com/12790
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Reviewed-by: Wei Liu <wei3.liu@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-2675 llite: remove lli_lvb 49/12849/2
John L. Hammond [Mon, 24 Nov 2014 22:08:27 +0000 (16:08 -0600)]
LU-2675 llite: remove lli_lvb

In struct ll_inode_info remove the struct ost_lvb lli_lvb member and
replace it with obd_time lli_{a,m,c}time. Rename ll_merge_lvb() to
ll_merge_attr(). Remove cl_merge_lvb() and replace calls to it with
calls to ll_merge_attr().

Signed-off-by: John L. Hammond <john.hammond@intel.com>
Change-Id: Idaf8a89d2e4243e62a23cab949c3c129001bb9f3
Reviewed-on: http://review.whamcloud.com/12849
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Bobi Jam <bobijam@gmail.com>
Reviewed-by: Lai Siyao <lai.siyao@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5828 lnet: showing buffers problem with mulitple CPTs 93/12593/3
Amir Shehata [Wed, 5 Nov 2014 22:32:59 +0000 (14:32 -0800)]
LU-5828 lnet: showing buffers problem with mulitple CPTs

Overloading an iterator variable in lustre_lnet_show_routing()
caused only the first CPT information to be displayed.

Signed-off-by: Amir Shehata <amir.shehata@intel.com>
Change-Id: Ic75dccc0c3537b8272d1c2687a759fbcc23052e8
Reviewed-on: http://review.whamcloud.com/12593
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Doug Oucharek <doug.s.oucharek@intel.com>
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5858 obdclass: eliminate NULL error return 54/12554/4
Bob Glossman [Tue, 4 Nov 2014 19:14:35 +0000 (11:14 -0800)]
LU-5858 obdclass: eliminate NULL error return

Always return an ERR_PTR() on errors, never return a NULL,
in lu_object_find_slice().  Also clean up callers who
no longer need special case handling of NULL returns.

Signed-off-by: Bob Glossman <bob.glossman@intel.com>
Change-Id: I57ddb38abaec7caf57bb63a75dbd76e181ba72b2
Reviewed-on: http://review.whamcloud.com/12554
Tested-by: Jenkins
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Fan Yong <fan.yong@intel.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5396 mdc: (and lmv, mgc, osc) make some functions static 22/12222/9
Frank Zago [Tue, 30 Sep 2014 03:10:50 +0000 (22:10 -0500)]
LU-5396 mdc: (and lmv, mgc, osc) make some functions static

Some functions and variables are only used in their C file, so reduce
their scope. This reduces the code size, and fixes sparse warnings
such as:

  warning: symbol 'proc_lnet_routes' was not declared.
      Should it be static?
  warning: symbol 'proc_lnet_routers' was not declared.
      Should it be static?

Some prototypes were removed from C files and added to the proper
header.

Signed-off-by: Frank Zago <fzago@cray.com>
Change-Id: I8dcc5224c1da75cfb5ef7afb1fdb0f72422a3ac0
Reviewed-on: http://review.whamcloud.com/12222
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5396 lov: (and ldlm) make some functions static 21/12221/10
Frank Zago [Tue, 30 Sep 2014 02:39:31 +0000 (21:39 -0500)]
LU-5396 lov: (and ldlm) make some functions static

Some functions and variables are only used in their C file, so reduce
their scope. This reduces the code size, and fixes sparse warnings
such as:

  warning: symbol 'proc_lnet_routes' was not declared.
      Should it be static?
  warning: symbol 'proc_lnet_routers' was not declared.
      Should it be static?

Some prototypes were removed from C files and added to the proper
header.

Signed-off-by: Frank Zago <fzago@cray.com>
Change-Id: I86b7ada5c768f4b875fce55745f7492faabd4617
Reviewed-on: http://review.whamcloud.com/12221
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5396 ptlrpc: make some functions static 19/12219/4
Frank Zago [Thu, 2 Oct 2014 02:05:25 +0000 (21:05 -0500)]
LU-5396 ptlrpc: make some functions static

Some functions and variables are only used in their C file, so reduce
their scope. This reduces the code size, and fixes sparse warnings
such as:

  warning: symbol 'proc_lnet_routes' was not declared.
      Should it be static?
  warning: symbol 'proc_lnet_routers' was not declared.
      Should it be static?

Some prototypes were removed from C files and added to the proper
header.

Signed-off-by: Frank Zago <fzago@cray.com>
Change-Id: Ic30c9c00be7fd161e0eb3aa2505c6d731c3d7a87
Reviewed-on: http://review.whamcloud.com/12219
Tested-by: Jenkins
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5396 llite: make some functions static 11/12211/5
Frank Zago [Mon, 8 Sep 2014 00:24:35 +0000 (19:24 -0500)]
LU-5396 llite: make some functions static

Some functions and variables are only used in their C file, so reduce
their scope. This reduces the code size, and fixes sparse warnings
such as:

  warning: symbol 'proc_lnet_routes' was not declared.
      Should it be static?
  warning: symbol 'proc_lnet_routers' was not declared.
      Should it be static?

Some prototypes were removed from C files and added to the proper
header.

Signed-off-by: Frank Zago <fzago@cray.com>
Change-Id: Id6b13d2b5ceb30de02b60ed6be24d4a496454b70
Reviewed-on: http://review.whamcloud.com/12211
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5396 libcfs: make some functions static 07/12207/7
Frank Zago [Sun, 7 Sep 2014 18:00:28 +0000 (13:00 -0500)]
LU-5396 libcfs: make some functions static

Some functions and variables are only used in their C file, so reduce
their scope. This reduces the code size, and fixes sparse warnings
such as:

  warning: symbol 'proc_lnet_routes' was not declared.
      Should it be static?
  warning: symbol 'proc_lnet_routers' was not declared.
      Should it be static?

Some prototypes were removed from C files and added to the proper
header.

Signed-off-by: Frank Zago <fzago@cray.com>
Change-Id: I5bdf94633fb94e435d32691d521ad7c1234018aa
Reviewed-on: http://review.whamcloud.com/12207
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5772 osd-zfs: irrelevant comment over __osd_xattr_load 50/12350/3
Isaac Huang [Mon, 20 Oct 2014 19:32:20 +0000 (13:32 -0600)]
LU-5772 osd-zfs: irrelevant comment over __osd_xattr_load

Moved comment over __osd_xattr_load() to __osd_xattr_get(),
where it really belongs, and converted it to Doxygen format.
Added a few other minor cleanups as well.

Signed-off-by: Isaac Huang <he.huang@intel.com>
Change-Id: If73048d046419eaa4e23cbc5acde32c09b588996
Reviewed-on: http://review.whamcloud.com/12350
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Nathaniel Clark <nathaniel.l.clark@intel.com>
Reviewed-by: Ned Bass <bass6@llnl.gov>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5443 libcfs: replace direct HZ access with kernel APIs 93/11993/11
Jian Yu [Tue, 18 Nov 2014 02:32:20 +0000 (18:32 -0800)]
LU-5443 libcfs: replace direct HZ access with kernel APIs

On some customer's systems, kernel was compiled with HZ defined to
100, instead of 1000. This improves performance for HPC applications.
However, to use these systems with Lustre, customers have to re-build
Lustre for the kernel because Lustre directly uses the defined
constant HZ.

Since kernel 2.6.21, some non-HZ dependent timing APIs become non-
inline functions, which can be used in Lustre codes to replace the
direct HZ access.

These kernel APIs include:
 jiffies_to_msecs()
 jiffies_to_usecs()
 jiffies_to_timespec()
 msecs_to_jiffies()
 usecs_to_jiffies()
 timespec_to_jiffies()

And here are some samples of the replacement:
 HZ            -> msecs_to_jiffies(MSEC_PER_SEC)
 n * HZ        -> msecs_to_jiffies(n * MSEC_PER_SEC)
 HZ / n        -> msecs_to_jiffies(MSEC_PER_SEC / n)
 n / HZ        -> jiffies_to_msecs(n) / MSEC_PER_SEC
 n / HZ * 1000 -> jiffies_to_msecs(n)

This patch replaces the direct HZ access in libcfs module.

The patch also replaces ONE_BILLION with NSEC_PER_SEC,
and ONE_MILLION with USEC_PER_SEC in linux-time.h.

Signed-off-by: Jian Yu <jian.yu@intel.com>
Change-Id: I33846f378eb876cd8958ff0c397ffb56a552f256
Reviewed-on: http://review.whamcloud.com/11993
Tested-by: Jenkins
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Nathaniel Clark <nathaniel.l.clark@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5443 ldiskfs: replace direct HZ access with kernel APIs 79/12779/2
Jian Yu [Wed, 19 Nov 2014 02:36:32 +0000 (18:36 -0800)]
LU-5443 ldiskfs: replace direct HZ access with kernel APIs

On some customer's systems, kernel was compiled with HZ defined to
100, instead of 1000. This improves performance for HPC applications.
However, to use these systems with Lustre, customers have to re-build
Lustre for the kernel because Lustre directly uses the defined
constant HZ.

Since kernel 2.6.21, some non-HZ dependent timing APIs become non-
inline functions, which can be used in Lustre codes to replace the
direct HZ access.

These kernel APIs include:
 jiffies_to_msecs()
 jiffies_to_usecs()
 jiffies_to_timespec()
 msecs_to_jiffies()
 usecs_to_jiffies()
 timespec_to_jiffies()

And here are some samples of the replacement:
 HZ            -> msecs_to_jiffies(MSEC_PER_SEC)
 n * HZ        -> msecs_to_jiffies(n * MSEC_PER_SEC)
 HZ / n        -> msecs_to_jiffies(MSEC_PER_SEC / n)
 n / HZ        -> jiffies_to_msecs(n) / MSEC_PER_SEC
 n / HZ * 1000 -> jiffies_to_msecs(n)

This patch replaces the direct HZ access in ldiskfs module.

Test-Parameters: alwaysuploadlogs envdefinitions=SLOW=yes,MMP_EXCEPT=5 \
mdtfilesystemtype=ldiskfs mdsfilesystemtype=ldiskfs ostfilesystemtype=ldiskfs \
clientcount=4 osscount=2 mdscount=2 austeroptions=-R failover=true iscsi=1 \
testlist=mmp

Signed-off-by: Jian Yu <jian.yu@intel.com>
Change-Id: Ic111360083bd6d8973e47767cb1b291915613727
Reviewed-on: http://review.whamcloud.com/12779
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Nathaniel Clark <nathaniel.l.clark@intel.com>
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5986 test: fix conflicting conf-sanity 83 test. 84/12984/2
James Simmons [Mon, 8 Dec 2014 15:59:59 +0000 (10:59 -0500)]
LU-5986 test: fix conflicting conf-sanity 83 test.

Patches for both LU-4119 and LU-5729 introduced test
83 to conf-sanity. The simple fix is to renumber the
test from LU-4119 to test 84.

Change-Id: Idca7c97daface6768a08f7ef7cbd00b601921a1e
Signed-off-by: James Simmons <uja.ornl@gmail.com>
Reviewed-on: http://review.whamcloud.com/12984
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Jenkins
Reviewed-by: Nathaniel Clark <nathaniel.l.clark@intel.com>
Reviewed-by: Jian Yu <jian.yu@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
5 years agoLU-5996 tests: check spaces and tabs in .sh files 76/12976/2
Jian Yu [Sat, 6 Dec 2014 07:16:37 +0000 (23:16 -0800)]
LU-5996 tests: check spaces and tabs in .sh files

This patch fixes checkpatch.pl script to check the following
coding style rules in .sh files:
- code indent should use tabs where possible
- no space before tabs
- no spaces at the start of a line

Signed-off-by: Jian Yu <jian.yu@intel.com>
Change-Id: I71821d2d15ca218528fcd8fb37119d0e0798027a
Reviewed-on: http://review.whamcloud.com/12976
Tested-by: Jenkins
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
5 years agoRevert "LU-4820 osd: drop memcpy in zfs osd" 90/12990/3
Andreas Dilger [Mon, 8 Dec 2014 17:37:02 +0000 (17:37 +0000)]
Revert "LU-4820 osd: drop memcpy in zfs osd"

This caused review-zfs sanity test_44 to fail in all test cases.

This reverts commit 1249edcd71e6a44f92aba1482201b30696e85d0d.

Change-Id: I972c4c68ee67443c999ce74fda6f6960b0e4b30d
Reviewed-on: http://review.whamcloud.com/12990
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Tested-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5982 lfsck: not unlock the object repeatedly 43/12943/3
Fan Yong [Wed, 24 Sep 2014 04:10:29 +0000 (12:10 +0800)]
LU-5982 lfsck: not unlock the object repeatedly

There was wrong logic in lfsck_namespace_insert_orphan() that tried to
unlock the same object twice if failed to update the object's linkEA,
then triggered low layer LBUG(). Fix it.

On the other hand, the remote orphan parent object should be marked as
LOHA_EXISTS after lfsck_namespace_create_orphan_remote() done.

Some test scripts cleanup.

Signed-off-by: Fan Yong <fan.yong@intel.com>
Change-Id: I3901d5cea8afde362dca8ee25a8d2a44e9f6ffea
Reviewed-on: http://review.whamcloud.com/12943
Tested-by: Jenkins
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Alex Zhuravlev <alexey.zhuravlev@intel.com>
5 years agonew tag 2.6.91 2.6.91 v2_6_91 v2_6_91_0
Oleg Drokin [Fri, 5 Dec 2014 23:38:22 +0000 (18:38 -0500)]
new tag 2.6.91

Change-Id: I9601b0cfaa9088eb4d7fda2614fbc2183dcccb52

5 years agoLU-5824 tests: auster -h gives wrong example 70/12470/2
Isaac Huang [Wed, 29 Oct 2014 05:19:47 +0000 (23:19 -0600)]
LU-5824 tests: auster -h gives wrong example

The last example given by "auster -h" should use "-i 5" rather than
"-r 5".

Signed-off-by: Isaac Huang <he.huang@intel.com>
Change-Id: Ibf1f196e5a1d4282ad9a75eda68c27c45f074a7e
Reviewed-on: http://review.whamcloud.com/12470
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Jian Yu <jian.yu@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
5 years agoLU-5866 build: add option to disable zfs build 76/12576/8
Wang Shilong [Mon, 10 Nov 2014 12:51:30 +0000 (20:51 +0800)]
LU-5866 build: add option to disable zfs build

add option --disable-zfs to disable build zfs for Lustre.

Signed-off-by: Wang Shilong <wshilong@ddn.com>
Change-Id: Ie7c1c5d0417979f61f0294390377eaebc36fd320
Reviewed-on: http://review.whamcloud.com/12576
Tested-by: Jenkins
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5577 obdclass: change loop indexes to unsigned 87/12387/4
Dmitry Eremin [Mon, 13 Oct 2014 17:18:21 +0000 (21:18 +0400)]
LU-5577 obdclass: change loop indexes to unsigned

Cleanup warnings about comparison between signed and unsigned.

Signed-off-by: Dmitry Eremin <dmitry.eremin@intel.com>
Change-Id: I2d94940251f639942142d54a561225daa8cd8a74
Reviewed-on: http://review.whamcloud.com/12387
Tested-by: Jenkins
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Jinshan Xiong <jinshan.xiong@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5451 lod: improve weird FID handling 60/11560/9
John L. Hammond [Fri, 22 Aug 2014 15:21:25 +0000 (10:21 -0500)]
LU-5451 lod: improve weird FID handling

In lod_fld_lookup() the FID in question may have come from disk or
wire. Thus if fid_is_sane() returns false then return -EIO rather than
asserting.

Signed-off-by: John L. Hammond <john.hammond@intel.com>
Change-Id: I6c7e3885a8b1aa81fcaa8891392a11e40a02fbce
Reviewed-on: http://review.whamcloud.com/11560
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Fan Yong <fan.yong@intel.com>
Reviewed-by: Mike Pershin <mike.pershin@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5933 fiemap: set FIEMAP_EXTENT_LAST correctly 81/12781/2
Bobi Jam [Wed, 19 Nov 2014 05:47:58 +0000 (13:47 +0800)]
LU-5933 fiemap: set FIEMAP_EXTENT_LAST correctly

When we've collected enough extents as user requested, we'd check one
further to decide whether we've reached the last extent of the file.

Signed-off-by: Bobi Jam <bobijam.xu@intel.com>
Change-Id: Ic4c4710adf98552626d87d54c893ba9fa18ef7b8
Reviewed-on: http://review.whamcloud.com/12781
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5696 ptlrpc: missing wakeup for ptlrpc_check_set 58/12158/10
Liang Zhen [Wed, 1 Oct 2014 16:47:46 +0000 (00:47 +0800)]
LU-5696 ptlrpc: missing wakeup for ptlrpc_check_set

This patch changes a few things:

- There is no guarantee that request_out_callback will happen
  before reply_in_callback, if a request got reply and unlinked
  reply buffer before request_out_callback is called, then the
  thread waiting on ptlrpc_request_set will miss wakeup event.

  This may seriously impact performance of some IO workloads or
  result in RPC timeout

- To make code more easier to understand, this patch changes
  action-bits "rq_req_unlink" and "rq_reply_unlink" to
  status-bits "rq_req_unlinked" and "rq_reply_unlinked"

Signed-off-by: Liang Zhen <liang.zhen@intel.com>
Change-Id: Ie6043534af3c9b48a52da30210d327f3de83b866
Reviewed-on: http://review.whamcloud.com/12158
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Johann Lombardi <johann.lombardi@intel.com>
Reviewed-by: Li Wei <wei.g.li@intel.com>
Reviewed-by: Mike Pershin <mike.pershin@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5474 tests: sanity-hsm test_90 use local HSM_ARCHIVE 69/12069/11
James Nunez [Mon, 17 Nov 2014 18:29:40 +0000 (11:29 -0700)]
LU-5474 tests: sanity-hsm test_90 use local HSM_ARCHIVE

sanity-hsm test 90 suffers from frequent failures due to
slow archive speeds. If the existing archive is not
local, test 90 now uses a local disk archive to speed
the archive process.

sanity-hsm test 40 was modified to query the SINGLEAGT
node to check if the archive is a local disk for
HSM_ARCHIVE.

copytool_cleanup was modified to match copytool_setup;
remove the contents of $hsm_root and not $hsm_root itself.

Test 90 is removed from the exception list.

Signed-off-by: James Nunez <james.a.nunez@intel.com>
Change-Id: I0beee30b681d4b80f23d33cb42ff5b2944fc21d1
Reviewed-on: http://review.whamcloud.com/12069
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Jian Yu <jian.yu@intel.com>
Reviewed-by: Jinshan Xiong <jinshan.xiong@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoRevert "LU-5275 lprocfs: remove last of non seq data structs and functions." 53/12953/3
Johann Lombardi [Fri, 5 Dec 2014 09:53:39 +0000 (09:53 +0000)]
Revert "LU-5275 lprocfs: remove last of non seq data structs and functions."

This reverts commit 0ad4f8a4227ed7dd93fec99d33c6bb25056473fc.
This patch has broken the el6.6 build:
include/linux/proc_fs.h:120: note: previous declaration of 'remove_proc_subtree' was here

Change-Id: I62d9b032448d9eea5d089b69382c2ff5064c5d3d
Reviewed-on: http://review.whamcloud.com/12953
Tested-by: Jenkins
Reviewed-by: Johann Lombardi <johann.lombardi@intel.com>
5 years agoLU-5581 ldlm: evict clients returning errors on ASTs 52/11752/5
Alexey Lyashkov [Sun, 2 Nov 2014 16:53:48 +0000 (11:53 -0500)]
LU-5581 ldlm: evict clients returning errors on ASTs

When a client returns an error other then EINVAL replying to blocking
ast, it is unsafe to cancel the lock on server side only, because the
client may continue its I/O assuming it still owns the lock while the
real lock may be granted already to another client.

In only valid error case when client replied to AST with EINVAL cancel
the lock and return ERESTART, evict the client in any other error
case.

Xyratex-bug-id: MRP-2041
Signed-off-by: Alexey Lyashkov <alexey_lyashkov@xyratex.com>
Change-Id: Ibce60ce3b2c24ba388155ac49cba8f20388893e7
Reviewed-on: http://review.whamcloud.com/11752
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-4647 nodemap: fix problem with node reclassification 75/12575/2
Kit Westneat [Wed, 5 Nov 2014 14:23:10 +0000 (09:23 -0500)]
LU-4647 nodemap: fix problem with node reclassification

nodemap_add_member can't be used to move an already hashed member
to a new nodemap, so this patch copies the needed functionality to
nm_member_reclassif_cb. This also adds a mutex lock for reclassifying
so that there is only one nodemap reclassifying at a time.
Reclassifying takes a lock on a nodemap's nm_member_hash, so a
deadlock could arise if one nodemap is trying to add a member to
another nodemap, and that second nodemap is also reclassifying and
eventually tries to add a member to the first nodemap.

Signed-off-by: Kit Westneat <kit.westneat@gmail.com>
Change-Id: Icc93a8e6d8384afa90e45cc04f1422512974ce4a
Reviewed-on: http://review.whamcloud.com/12575
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Nathaniel Clark <nathaniel.l.clark@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5889 mdc: Proper accessing struct lov_user_md 83/12683/2
Yoshifumi Uemura [Wed, 12 Nov 2014 07:02:04 +0000 (16:02 +0900)]
LU-5889 mdc: Proper accessing struct lov_user_md

In mdc_setattr_pack() access the members of struct lov_user_md by
little endian byte order.

Signed-off-by: Yoshifumi Uemura <kogexe@gmail.com>
Change-Id: I201f00f527242faa6e1a199d3e792e5cdfa48006
Reviewed-on: http://review.whamcloud.com/12683
Tested-by: Jenkins
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Yang Sheng <yang.sheng@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-4975 ofd: Fix Doxygen warnings for ofd files 65/12665/2
Doug Oucharek [Tue, 11 Nov 2014 02:35:48 +0000 (18:35 -0800)]
LU-4975 ofd: Fix Doxygen warnings for ofd files

After patches 10417 and 10586, some Doxygen warnings were created
due to incorrect syntax and missing function parameters in header.
This patch fixes those warnings.

Signed-off-by: Doug Oucharek <doug.s.oucharek@intel.com>
Change-Id: I6859d9cbe17f52562ae1e93ea4fa0afb08b3f547
Reviewed-on: http://review.whamcloud.com/12665
Tested-by: Jenkins
Reviewed-by: Richard Henwood <richard.henwood@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Johann Lombardi <johann.lombardi@intel.com>
5 years agoLU-1892 osp: Fix Doxygen warnings for osp_trans.c 59/12659/2
Doug Oucharek [Mon, 10 Nov 2014 20:22:14 +0000 (12:22 -0800)]
LU-1892 osp: Fix Doxygen warnings for osp_trans.c

After patch 10361, three Doxygen warnings were created due to
incorrect syntax. This patch fixes those.

Signed-off-by: Doug Oucharek <doug.s.oucharek@intel.com>
Change-Id: Iaaec90f545a8f55522b5f87111dea2b544592ea2
Reviewed-on: http://review.whamcloud.com/12659
Tested-by: Jenkins
Reviewed-by: Richard Henwood <richard.henwood@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Fan Yong <fan.yong@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5813 lnet: Fix typo in route show command 57/12557/4
Amir Shehata [Tue, 4 Nov 2014 20:58:01 +0000 (12:58 -0800)]
LU-5813 lnet: Fix typo in route show command

Fix type: s/vebose/verbose

Signed-off-by: Amir Shehata <amir.shehata@intel.com>
Change-Id: I454dc319b670b176c96916ea6b1d44036f9f0199
Reviewed-on: http://review.whamcloud.com/12557
Reviewed-by: frank zago <fzago@cray.com>
Reviewed-by: Doug Oucharek <doug.s.oucharek@intel.com>
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5577 obdclass: lu_htable_order() return type to long 85/12385/2
Dmitry Eremin [Fri, 10 Oct 2014 19:35:16 +0000 (23:35 +0400)]
LU-5577 obdclass: lu_htable_order() return type to long

Change the type accordant usage.

Signed-off-by: Dmitry Eremin <dmitry.eremin@intel.com>
Change-Id: I4a2071f9ca51cc34f1fd7c73ccf7dac52a9ff0e9
Reviewed-on: http://review.whamcloud.com/12385
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5275 lprocfs: remove last of non seq data structs and functions. 98/12298/4
James Simmons [Mon, 3 Nov 2014 20:55:06 +0000 (15:55 -0500)]
LU-5275 lprocfs: remove last of non seq data structs and functions.

This patch removes the rest of the non-seq file data structs
and functions. We rename the current seq data structs and
functions to match what is in the upstream lustre client.
Some functions in newer kernels are absent in RHEL6.5 and
SLES11SP3 kernels but lustre has equivalent functions so
they have also been renamed to match what exist in newer
kernels.

Change-Id: Iec17cd214864fe7c004eae8972397be326cdfee4
Signed-off-by: James Simmons <uja.ornl@gmail.com>
Reviewed-on: http://review.whamcloud.com/12298
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Bobi Jam <bobijam@gmail.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-2675 obd: remove client_obd_lock_t 31/12231/4
John L. Hammond [Wed, 5 Nov 2014 01:10:43 +0000 (20:10 -0500)]
LU-2675 obd: remove client_obd_lock_t

Remove the definition of client_obd_lock_t and the functions
client_obd_list_{init,lock,unlock,done}(). Use spinlock_t for the
cl_{loi,lru}_list_lock members of struct client_obd and call
spin_{lock,unlock}() directly.

Signed-off-by: John L. Hammond <john.hammond@intel.com>
Change-Id: I3c4b9cf531b6d62c3481a40f4a1c448cf864beec
Reviewed-on: http://review.whamcloud.com/12231
Tested-by: Jenkins
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5536 target: allow FLD_READ request during recovery 99/12199/6
Mikhail Pershin [Mon, 6 Oct 2014 18:35:10 +0000 (22:35 +0400)]
LU-5536 target: allow FLD_READ request during recovery

FLD_READ opcode was introduced but not added to the
tgt_filter_recovery_request() as allowed during recovery.

Signed-off-by: Mikhail Pershin <mike.pershin@intel.com>
Change-Id: I1d63a95202288e3d72b77037658e5ba0eec4103e
Reviewed-on: http://review.whamcloud.com/12199
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Johann Lombardi <johann.lombardi@intel.com>
5 years agoLU-5702 ldlm: suppress error message for valid case 89/12189/3
Mikhail Pershin [Mon, 6 Oct 2014 11:01:53 +0000 (15:01 +0400)]
LU-5702 ldlm: suppress error message for valid case

LVB object may not exist and this is valid case

Signed-off-by: Mikhail Pershin <mike.pershin@intel.com>
Change-Id: I673933d582856a212289e228f0ccfb156c88cfb1
Reviewed-on: http://review.whamcloud.com/12189
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Li Wei <wei.g.li@intel.com>
Reviewed-by: Johann Lombardi <johann.lombardi@intel.com>
5 years agoLU-5857 tests: check lctl return value in check_catastrophe() 40/12640/4
Jian Yu [Wed, 3 Dec 2014 02:26:10 +0000 (18:26 -0800)]
LU-5857 tests: check lctl return value in check_catastrophe()

This patch fixes check_catastrophe() to check the return value of
lctl command. The catastrophe value would be checked only if the
lctl command passed.

The patch also simplifies the function to check catastrophe value
on all of the test nodes without separating local and remote nodes.

Signed-off-by: Jian Yu <jian.yu@intel.com>
Change-Id: I0ffdafe27b0829dde5a8ea136be76e35b5ea8f43
Reviewed-on: http://review.whamcloud.com/12640
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5586 llite: fix dup flags names 92/12892/2
Bob Glossman [Mon, 1 Dec 2014 19:03:26 +0000 (11:03 -0800)]
LU-5586 llite: fix dup flags names

The name 'xattr' is used for two different ll_flags bits.
Change the names to be distinct and different, reflecting
the names of the bits used in LL_SBI_xbitnamex #defines.

Signed-off-by: Bob Glossman <bob.glossman@intel.com>
Change-Id: I538cbee8f5382e1a7c74f2dcd598025886225cc3
Reviewed-on: http://review.whamcloud.com/12892
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Minh Diep <minh.diep@intel.com>
Reviewed-by: Jian Yu <jian.yu@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5951 clio: update timestamps after buiding rpc 65/12865/4
Niu Yawei [Mon, 1 Dec 2014 06:05:55 +0000 (01:05 -0500)]
LU-5951 clio: update timestamps after buiding rpc

The mtime/atime/ctime in the write RPC has to be updated after
the RPC is built (where xid is generated), otherwise, it could
race with the setattr and updating wrong timestamps on OST side.

Seems this regression was introduced when landing clio code.

Use ofd_write_lock() to protect fmd lookup/udpate in
ofd_punch_object(), otherwise, it could race with ofd_attr_set()
and ofd_commitrw().

Signed-off-by: Niu Yawei <yawei.niu@intel.com>
Change-Id: I16216038ea2bd064ef7f33857a1d4aba167ac5fb
Reviewed-on: http://review.whamcloud.com/12865
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Bobi Jam <bobijam@gmail.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
5 years agoLU-5950 mgc: add nid iteration 29/12829/3
Alexander.Boyko [Mon, 24 Nov 2014 10:55:15 +0000 (13:55 +0300)]
LU-5950 mgc: add nid iteration

mgc_apply_recover_logs use only first nid from entry,
this could be the problem for a cluster with several network
address for a one node.

Signed-off-by: Alexander Boyko <alexander.boyko@seagate.com>
Change-Id: I6ec348761c2d51edd613cb388e37ef7776990424
Xyratex-bug-id: MRP-2255
Reviewed-on: http://review.whamcloud.com/12829
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Jenkins
Reviewed-by: Mike Pershin <mike.pershin@intel.com>
Reviewed-by: Ann Koehler <amk@cray.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
5 years agoLU-5912 libcfs: use vfs api for fsync calls 31/12731/3
Bob Glossman [Fri, 14 Nov 2014 22:26:30 +0000 (14:26 -0800)]
LU-5912 libcfs: use vfs api for fsync calls

Use vfs_fsync_range() instead of direct use of filp->f_op->fsync()
routines.  Doing so will apply correct locking transparently without
needing to decide how to do it ourselves.
What we were doing was a long term violation of the locking
protocols described in Documentation/filesystems/Locking in linux
source but was never noticed until new checking code went into the
RHEL 6.6 kernel.  The new check triggered a visible error in syslog.

Signed-off-by: Bob Glossman <bob.glossman@intel.com>
Change-Id: I551215fc340637364fe04f6e3bae963cf983c953
Reviewed-on: http://review.whamcloud.com/12731
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Yang Sheng <yang.sheng@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
5 years agoLU-5894 mds: allow 2.4/2.5 clients create remote dir 15/12715/2
Wang Di [Fri, 14 Nov 2014 07:16:09 +0000 (23:16 -0800)]
LU-5894 mds: allow 2.4/2.5 clients create remote dir

MDS will only return ENOTSUPP if old client (2.4/2.5) tries
to create striped dir with stripe count > 1, so it can still
create remote directory on the new MDS (>= 2.6).

Change-Id: I25c90ae793f91eed032949d26fd5e7fc41801e4f
Signed-off-by: Wang Di <di.wang@intel.com>
Reviewed-on: http://review.whamcloud.com/12715
Tested-by: Jenkins
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
5 years agoLU-5808 llog: check name strictly to avoid invalid record 37/12437/2
Li Xi [Mon, 27 Oct 2014 13:54:25 +0000 (21:54 +0800)]
LU-5808 llog: check name strictly to avoid invalid record

Records for a file system cound be written to llog of another file
system by mistake if the name of the former one is the prefix of
the latter one. This patch fixes the problem by using more strict
checking of llog name.

Signed-off-by: Li Xi <lixi@ddn.com>
Change-Id: If45c59b0226b71e8a95f9aa719eae8412c89a2f1
Reviewed-on: http://review.whamcloud.com/12437
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Reviewed-by: Mike Pershin <mike.pershin@intel.com>
5 years agoLU-5635 llog: prevent out-of-bound index 61/12161/3
Frank Zago [Wed, 1 Oct 2014 20:30:50 +0000 (15:30 -0500)]
LU-5635 llog: prevent out-of-bound index

llog_process_thread() can be called from llog_cat_process_cb with an
index already out of bound, leading to the following crash:

LustreError: 3773:0:(llog.c:310:llog_process_thread())
  ASSERTION(index <= last_index + 1 ) failed:
LustreError: 3773:0:(llog.c:310:llog_process_thread()) LBUG

 #0 [ffff8801144bf900] machine_kexec at ffffffff81038f3b
 #1 [ffff8801144bf960] crash_kexec at ffffffff810c5d82
 #2 [ffff8801144bfa30] panic at ffffffff8152798a
 #3 [ffff8801144bfab0] lbug_with_loc at ffffffffa02f8eeb [libcfs]
 #4 [ffff8801144bfad0] llog_process_thread at ffffffffa0413fff [obdclass]
 #5 [ffff8801144bfb80] llog_process_or_fork at ffffffffa041585f [obdclass]
 #6 [ffff8801144bfbd0] llog_cat_process_cb at ffffffffa0418612 [obdclass]
 #7 [ffff8801144bfc30] llog_process_thread at ffffffffa0413c22 [obdclass]
 #8 [ffff8801144bfce0] llog_process_or_fork at ffffffffa041585f [obdclass]
 #9 [ffff8801144bfd30] llog_cat_process_or_fork at ffffffffa0416b9d [obdclass]
    RIP: 00007f6de5e4f730  RSP: 00007fff9aa26d98  RFLAGS: 00000206
    RAX: 0000000000000000  RBX: ffffffff8100b072  RCX: 00007f6de5e4f730
    RDX: 0000000000008000  RSI: 00000000019c7000  RDI: 0000000000000003
    RBP: 00000000019c7000   R8: 00007f6de6103ee8   R9: 0000000000000001
    R10: 00007fff9aa26b20  R11: 0000000000000246  R12: ffffffffffff8000
    R13: 0000000000000003  R14: 0000000000008000  R15: 0000000000000003
    ORIG_RAX: 0000000000000000  CS: 0033  SS: 002b

If index is too big, simply return success.

Change-Id: I81bbedbbe2bcef478c370ef40fc069447d39efbd
Signed-off-by: frank zago <fzago@cray.com>
Reviewed-on: http://review.whamcloud.com/12161
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Jinshan Xiong <jinshan.xiong@intel.com>
Reviewed-by: Patrick Farrell <paf@cray.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5687 dt: propagate errors from failed declarations 30/12130/4
John L. Hammond [Tue, 30 Sep 2014 16:09:30 +0000 (11:09 -0500)]
LU-5687 dt: propagate errors from failed declarations

Check for and return errors from dt_declare_*() in several locations.

Signed-off-by: John L. Hammond <john.hammond@intel.com>
Change-Id: Id18b12d6c713e78e2f1cc782ff659d2c84cc60bb
Reviewed-on: http://review.whamcloud.com/12130
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Mike Pershin <mike.pershin@intel.com>
Reviewed-by: Alex Zhuravlev <alexey.zhuravlev@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-2675 lnet: remove ulnds 17/12117/3
John L. Hammond [Mon, 29 Sep 2014 18:33:24 +0000 (13:33 -0500)]
LU-2675 lnet: remove ulnds

Remove the unused userspace LND code (all of lnet/ulnds/) and
supporting autocrud.

Signed-off-by: John L. Hammond <john.hammond@intel.com>
Change-Id: I104d8b22afdde5027a2a0ef1a9ecc0423b67fae5
Reviewed-on: http://review.whamcloud.com/12117
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Amir Shehata <amir.shehata@intel.com>
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Reviewed-by: Isaac Huang <he.huang@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-2675 lmv: remove lmv_init_{lock,unlock}() 15/12115/3
John L. Hammond [Mon, 29 Sep 2014 18:12:52 +0000 (13:12 -0500)]
LU-2675 lmv: remove lmv_init_{lock,unlock}()

In struct lmv_obd rename the init_mutex member to
lmv_init_mutex. Remove the compat macros lmv_init_{lock,unlock}() and
use mutex_{lock,unlock}(&lmv->lmv_init_mutex) instead.

Signed-off-by: John L. Hammond <john.hammond@intel.com>
Change-Id: Iae1f5d6b7fd1f96ba430d5e7af97c51ce3e042a8
Reviewed-on: http://review.whamcloud.com/12115
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-2675 md: remove unused code from md_object.h 13/12113/3
John L. Hammond [Mon, 29 Sep 2014 17:55:46 +0000 (12:55 -0500)]
LU-2675 md: remove unused code from md_object.h

Remove several unused functions, structures, and members from
md_object.h.

Signed-off-by: John L. Hammond <john.hammond@intel.com>
Change-Id: I33de0ba987bfde95172e9bfb77929b6b4dcd0aa8
Reviewed-on: http://review.whamcloud.com/12113
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Fan Yong <fan.yong@intel.com>
Reviewed-by: Mike Pershin <mike.pershin@intel.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5622 tests: check/wait for copytool death 22/11922/5
Bruno Faccini [Mon, 15 Sep 2014 15:37:31 +0000 (17:37 +0200)]
LU-5622 tests: check/wait for copytool death

Seems that copytool death/kill may take more time so
this condition must be handled in sanity-hsm copytool_cleanup()
function to avoid situations where copytool will then not be
restarted, but only signaled, in next copytool_setup().

Signed-off-by: Bruno Faccini <bruno.faccini@intel.com>
Change-Id: Ia72ed07f0219cf0aa2ef5b3805fb1f7faf4dab66
Reviewed-on: http://review.whamcloud.com/11922
Reviewed-by: Henri Doreau <henri.doreau@cea.fr>
Tested-by: Jenkins
Reviewed-by: Robert Read <robert.read@intel.com>
Reviewed-by: James Nunez <james.a.nunez@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-3456 ptlrpc: quiet errors on initial connection 57/10057/4
Andreas Dilger [Tue, 22 Apr 2014 19:54:46 +0000 (13:54 -0600)]
LU-3456 ptlrpc: quiet errors on initial connection

It may be that a client or MDS is trying to connect to a target (OST
or peer MDT) before that target is finished setup.  Rather than
spamming the console logs during initial connection, only print a
console error message if there are repeated failures trying to
connect to the target, which may indicate an error on that node.

Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Bobi Jam <bobijam.xu@intel.com>
Change-Id: I98ec7b4c2109b700b53297038d3fede4773ebbe5
Reviewed-on: http://review.whamcloud.com/10057
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Bobi Jam <bobijam@gmail.com>
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-4820 osd: drop memcpy in zfs osd 60/9760/10
Alex Zhuravlev [Mon, 24 Mar 2014 15:30:19 +0000 (19:30 +0400)]
LU-4820 osd: drop memcpy in zfs osd

dmu_read() was called from osd_read_prep() copying from
ARC bufs into the same ARC bufs. seem to be the remainings
of per-zerocopy age.

Signed-off-by: Alex Zhuravlev <alexey.zhuravlev@intel.com>
Change-Id: I0f3657c360d8541d7c3c6e8e32eac78bc5702b42
Reviewed-on: http://review.whamcloud.com/9760
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Mike Pershin <mike.pershin@intel.com>
Reviewed-by: Isaac Huang <he.huang@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-5878 lfs: migrate file to its proper destination 01/12601/6
Frank Zago [Thu, 6 Nov 2014 17:08:30 +0000 (11:08 -0600)]
LU-5878 lfs: migrate file to its proper destination

llapi_file_open_param() is supposed to be returning the opened file
descriptor. However, when llapi_search_ost() is called, it returns 1,
which sets rc to 1, which in turn is confused for an error later, and
returned to the caller. So when the copy happen, the destination file
descriptor is 1 (stdout).

Fixed a typo in the function description, and format the parameters
descriptions.

Fixed a bad indentation.

There's no need to test lum before freeing it since at that point is
not NULL (and free will test it anyway).

Change-Id: I16fe26480b880aa818b1bb706b22bfdd6833d69c
Signed-off-by: frank zago <fzago@cray.com>
Reviewed-on: http://review.whamcloud.com/12601
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Jian Yu <jian.yu@intel.com>
Reviewed-by: Henri Doreau <henri.doreau@cea.fr>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
5 years agoLU-5861 lnet: invoke lnetctl properly from startup script 61/12561/2
Amir Shehata [Tue, 4 Nov 2014 21:14:39 +0000 (13:14 -0800)]
LU-5861 lnet: invoke lnetctl properly from startup script

Use the correct lnetctl command syntax to load default config:
lnetctl import < lnet.conf

Signed-off-by: Amir Shehata <amir.shehata@intel.com>
Change-Id: I54dd0d34f75b91c1c6ceb9745d817cb43f82ef25
Reviewed-on: http://review.whamcloud.com/12561
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Doug Oucharek <doug.s.oucharek@intel.com>
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
5 years agoLU-4119 ldlm: abort recovery by time_hard 78/9078/11
Sergey Cheremencev [Thu, 20 Nov 2014 16:58:43 +0000 (11:58 -0500)]
LU-4119 ldlm: abort recovery by time_hard

Set obd_abort_recovery to 1 when recovery time
reaches obd_recovery_time_hard.

Xyratex-bug-id: MRP-1365

Change-Id: Ida8f71cb63d5db9bf85bcdf2c152b4d9f71b8bca
Signed-off-by: Sergey Cheremencev <Sergey_Cheremencev@xyratex.com>
Reviewed-on: http://review.whamcloud.com/9078
Tested-by: Jenkins
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Mike Pershin <mike.pershin@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>