Whamcloud - gitweb
fs/lustre-release.git
15 years agoAdd lu_ref tracking to obd_device.
nikita [Sat, 18 Oct 2008 17:30:57 +0000 (17:30 +0000)]
Add lu_ref tracking to obd_device.
b=16450

15 years agoAdd st_block checking to multistat.c.
nikita [Sat, 18 Oct 2008 17:29:50 +0000 (17:29 +0000)]
Add st_block checking to multistat.c.
b=16450

15 years agoRemove unused mdd code.
nikita [Sat, 18 Oct 2008 17:28:44 +0000 (17:28 +0000)]
Remove unused mdd code.
b=16450

15 years agoMove md-specific fields out of struct lu_site into special struct md_site, so
nikita [Sat, 18 Oct 2008 17:27:58 +0000 (17:27 +0000)]
Move md-specific fields out of struct lu_site into special struct md_site, so
that lu_site can be used on a client.
b=16450

15 years agoConstify instances of struct {lu,dt,md}_device_operations.
nikita [Sat, 18 Oct 2008 17:26:37 +0000 (17:26 +0000)]
Constify instances of struct {lu,dt,md}_device_operations.
b=16450

15 years agoSeparate lu_site stats printing code into a separate function that can be
nikita [Sat, 18 Oct 2008 17:25:19 +0000 (17:25 +0000)]
Separate lu_site stats printing code into a separate function that can be
reused on a client.
b=16450

15 years agolu_ref is a debugging module allowing to track references to a given
nikita [Sat, 18 Oct 2008 17:24:14 +0000 (17:24 +0000)]
lu_ref is a debugging module allowing to track references to a given
object. It is quite cpu expensive, and has to be explicitly enabled with
--enable-lu_ref. See usage description within the patch.
b=16450

15 years agoFix a race between lu_object_find() finding an object and its concurrent
nikita [Sat, 18 Oct 2008 17:22:46 +0000 (17:22 +0000)]
Fix a race between lu_object_find() finding an object and its concurrent
finalization. This race is (most likely) not possible on the server, but might
happen on the client.
b=16450

15 years agolu_kmem_descr and its companion interface allow to create and destroy a number
nikita [Sat, 18 Oct 2008 17:20:41 +0000 (17:20 +0000)]
lu_kmem_descr and its companion interface allow to create and destroy a number
of kmem caches at once.
b=16450

15 years agoAdd lu_ref support to lu_object and lu_device. lu_ref is used to track leaked
nikita [Sat, 18 Oct 2008 17:19:11 +0000 (17:19 +0000)]
Add lu_ref support to lu_object and lu_device. lu_ref is used to track leaked
references.
b=16450

15 years agoIntroduce two new methods in lu_device_type_operations, that are invoked when
nikita [Sat, 18 Oct 2008 17:17:44 +0000 (17:17 +0000)]
Introduce two new methods in lu_device_type_operations, that are invoked when
first instance of a given type is created and last one is destroyed
respectively. This is need by CLIO.
b=16450

15 years agoIntroduce new lu_context functions that are needed on the client side, where
nikita [Sat, 18 Oct 2008 17:16:32 +0000 (17:16 +0000)]
Introduce new lu_context functions that are needed on the client side, where
some system threads (ptlrpcd) are shared by multiple modules, and so cannot be
stopped during module shutdown.
b=16450

15 years agoOn a server, a file system object is uniquely identified by a fid, which is
nikita [Sat, 18 Oct 2008 17:14:45 +0000 (17:14 +0000)]
On a server, a file system object is uniquely identified by a fid, which is
sufficient to locate and load all object state (inode). On a client, on the
other hand, more data are necessary instantiate an object. Change
lu_object_find() and friends to take additional `lu_conf' argument describing
object.  Typically this includes layout information.
b=16450

15 years agoConstify instances of struct lsm_operations.
nikita [Sat, 18 Oct 2008 17:12:24 +0000 (17:12 +0000)]
Constify instances of struct lsm_operations.
b=16450

15 years agoWrap kms updates into a helper function.
nikita [Sat, 18 Oct 2008 17:11:31 +0000 (17:11 +0000)]
Wrap kms updates into a helper function.
b=16450

15 years agoUse appropriately tagged _nested() locking calls in the places where llog
nikita [Sat, 18 Oct 2008 17:09:55 +0000 (17:09 +0000)]
Use appropriately tagged _nested() locking calls in the places where llog
takes more than one ->lgh_lock lock.
b=16450

15 years agoAdd new ->l_weigh_ast() call-back to ldlm_lock. It is called by
nikita [Sat, 18 Oct 2008 17:07:21 +0000 (17:07 +0000)]
Add new ->l_weigh_ast() call-back to ldlm_lock. It is called by
ldlm_cancel_shrink_policy() to estimate lock "value", instead of hard-coded
`number of pages' logic.
b=16450

15 years agoIntroduce ldlm_lock_addref_try() function (used by CLIO) that attempts to
nikita [Sat, 18 Oct 2008 17:05:50 +0000 (17:05 +0000)]
Introduce ldlm_lock_addref_try() function (used by CLIO) that attempts to
addref a lock that might be being canceled concurrently.
b=16450

15 years agolu_ref support for ldlm_lock and ldlm_resource. See lu_ref patch.
nikita [Sat, 18 Oct 2008 17:04:25 +0000 (17:04 +0000)]
lu_ref support for ldlm_lock and ldlm_resource. See lu_ref patch.
        lu_ref fields ->l_reference and ->lr_reference are added to ldlm_lock
        and ldlm_resource. LDLM interface has to be changed, because code that
        releases a reference on a lock, has to "know" what reference this is.
        In the most frequent case

                lock = ldlm_handle2lock(handle);
                ...
                LDLM_LOCK_PUT(lock);

        no changes are required. When any other reference (received _not_ from
        ldlm_handle2lock()) is released, LDLM_LOCK_RELEASE() has to be called
        instead of LDLM_LOCK_PUT().

        Arguably, changes are pervasive, and interface requires some discipline
        for proper use. On the other hand, it was very instrumental in finding
        a few leaked lock references.
b=16450

15 years agoKill unused ldlm_handle2lock_ns() function.
nikita [Sat, 18 Oct 2008 17:02:22 +0000 (17:02 +0000)]
Kill unused ldlm_handle2lock_ns() function.
b=16450

15 years agoAdd functions to map (rather arbitrary) between LDLM error codes and standard
nikita [Sat, 18 Oct 2008 17:01:23 +0000 (17:01 +0000)]
Add functions to map (rather arbitrary) between LDLM error codes and standard
errno values. CLIO needs this to prevent LDLM specific constants from escaping
ldlm and osc.
b=16450

15 years agoCLIO posts ENQUEUE requests asynchronously through ptlrpcd---a case that stock
nikita [Sat, 18 Oct 2008 15:49:01 +0000 (15:49 +0000)]
CLIO posts ENQUEUE requests asynchronously through ptlrpcd---a case that stock
ldlm_completion_ast() cannot handle as it waits until lock is
granted. Introduce new ldlm_completion_ast_async() for this. Also comment
ldlm_completion_ast().
b=16450

15 years agoCLIO uses lock weighting policy to keep locks over mmapped regions in
nikita [Sat, 18 Oct 2008 15:45:07 +0000 (15:45 +0000)]
CLIO uses lock weighting policy to keep locks over mmapped regions in
memory---a requirement implemented through ->o_join_lru() obd method in
HEAD. Remove this method and its users.
b=16450

15 years agoInstead of specifying each ldlm_lock call-back through separate parameter,
nikita [Sat, 18 Oct 2008 15:42:22 +0000 (15:42 +0000)]
Instead of specifying each ldlm_lock call-back through separate parameter,
wrap them into struct ldlm_callback_suite.
b=16450

15 years agoUse spin_lock_nested() in (the only) situation where more than one ldlm_lock
nikita [Sat, 18 Oct 2008 15:38:15 +0000 (15:38 +0000)]
Use spin_lock_nested() in (the only) situation where more than one ldlm_lock
is locked simultaneously. Also, fix possible dead-lock in
ldlm_lock_change_resource() by enforcing particular lock ordering.
b=16450

15 years agoUse LCK_MINMODE rather than 0 to reset lock->l_granted_mode to its initial
nikita [Sat, 18 Oct 2008 15:35:00 +0000 (15:35 +0000)]
Use LCK_MINMODE rather than 0 to reset lock->l_granted_mode to its initial
state.
b=16450

15 years agoAdd new LINVRNT() macro, optional on new --enable-invariants configure
nikita [Sat, 18 Oct 2008 15:32:59 +0000 (15:32 +0000)]
Add new LINVRNT() macro, optional on new --enable-invariants configure
switch. This macro is to be used for consistency and sanity checks that are
too expensive to be left in `production' mode.
b=16450

15 years agoIntroduce and use new LOCK_INODE_MUTEX_PARENT() macro to be used in the
nikita [Sat, 18 Oct 2008 15:30:01 +0000 (15:30 +0000)]
Introduce and use new LOCK_INODE_MUTEX_PARENT() macro to be used in the
situations where Lustre has to lock more than one inode mutex at a time.
b=16450

15 years agoAdd two new failloc constants to test lockless IO. Only one of them in
nikita [Sat, 18 Oct 2008 15:27:57 +0000 (15:27 +0000)]
Add two new failloc constants to test lockless IO. Only one of them in
implemented---another is checked in yet to be landed core CLIO code.
b=16450

15 years agoAugment ->do_{read,write}_lock() prototypes with a `role' parameter indicating
nikita [Sat, 18 Oct 2008 15:25:48 +0000 (15:25 +0000)]
Augment ->do_{read,write}_lock() prototypes with a `role' parameter indicating
lock ordering. Update mdd code to use new locking interface.
b=16450

15 years agoCall cmm_device_free() in the failure path of cmm_device_alloc().
nikita [Sat, 18 Oct 2008 15:22:51 +0000 (15:22 +0000)]
Call cmm_device_free() in the failure path of cmm_device_alloc().
b=16450

15 years agoMake previously optional ->oti_{w,r}_locks sanity checks mandatory to simplify
nikita [Sat, 18 Oct 2008 15:20:34 +0000 (15:20 +0000)]
Make previously optional ->oti_{w,r}_locks sanity checks mandatory to simplify
the code.
b=16450

15 years agoA couple of trivial spelling fixes.
nikita [Sat, 18 Oct 2008 15:15:47 +0000 (15:15 +0000)]
A couple of trivial spelling fixes.
b=16450

15 years agoUpdate documenting comments to match doxygen conventions.
nikita [Sat, 18 Oct 2008 15:13:21 +0000 (15:13 +0000)]
Update documenting comments to match doxygen conventions.
b=16450

15 years agoBranch HEAD
adilger [Fri, 17 Oct 2008 22:49:15 +0000 (22:49 +0000)]
Branch HEAD
Fix comment.

15 years agoBranch b1_6
adilger [Fri, 17 Oct 2008 21:05:02 +0000 (21:05 +0000)]
Branch b1_6
Use $RM macro for portability.
Make it more clear when sub-makes are finished.

15 years agob=16551
grev [Fri, 17 Oct 2008 19:12:34 +0000 (19:12 +0000)]
b=16551
i=Adilger
fix for remote [mds|ost] with nodsh

15 years agob=16551
grev [Fri, 17 Oct 2008 11:13:11 +0000 (11:13 +0000)]
b=16551
i=Adilger
fix for remote [mds|ost] with nodsh

15 years agob=15266
grev [Fri, 17 Oct 2008 10:30:48 +0000 (10:30 +0000)]
b=15266
i=Brian
create machinefile on $TMP, cleanup machinefile

15 years ago Branch HEAD
liuy [Fri, 17 Oct 2008 09:47:09 +0000 (09:47 +0000)]
 Branch HEAD
 b=12521
 To avoid extent lock conflicts, if avail_cb_nodes < stripe_count*CO,
 avail_cb_nodes should divide (stripe_count*CO) exactly. So that each OST
 can be accessed by one or more constant clients.

15 years agoBranch HEAD
huanghua [Thu, 16 Oct 2008 16:58:48 +0000 (16:58 +0000)]
Branch HEAD
b=17403

i=adilger
i=yury.umanets
create objects in correct directory on OST.

15 years agoBranch HEAD
yangsheng [Thu, 16 Oct 2008 08:27:54 +0000 (08:27 +0000)]
Branch HEAD
b=17199
i=johann, bobijam
Patch provide by LLNL.

Skip dumping log if panic_on_lbug is set.

15 years agobuild setting for b_hd_sptlrpc.
ericm [Thu, 16 Oct 2008 04:15:39 +0000 (04:15 +0000)]
build setting for b_hd_sptlrpc.

15 years agoBranch HEAD
bobijam [Thu, 16 Oct 2008 01:41:11 +0000 (01:41 +0000)]
Branch HEAD
b=17038
i=johann

regression test case for getxattr upon symlink file.

15 years agob=14471
grev [Wed, 15 Oct 2008 17:11:01 +0000 (17:11 +0000)]
b=14471
i=Adilger
replace lustre proc by lctl [set|get]_param

15 years ago Branch HEAD
liuy [Wed, 15 Oct 2008 15:18:11 +0000 (15:18 +0000)]
 Branch HEAD
 b=12521
 - set Lustre hints (except striping hints) "anywhere"
 - perform collective I/O for interleaving, no matter how big the req size is
 - keep the semantic information of cb_nodes
 - perform collective I/O by the same client if the whole file access portion
   is no bigger than stripe size and cb_nodes is changed by the user
 - fix some bugs in the error handling
 - remove redundant codes

15 years agob=12599
grev [Wed, 15 Oct 2008 15:04:40 +0000 (15:04 +0000)]
b=12599
i=Nathan
fix obsolete run_one CLEANUP

15 years agob=16932
grev [Wed, 15 Oct 2008 14:46:43 +0000 (14:46 +0000)]
b=16932
i=Johann
skip some tests if there are several ost services on oss node

15 years ago- sombody declated @err two times in lov_destroy().
yury [Wed, 15 Oct 2008 07:36:32 +0000 (07:36 +0000)]
- sombody declated @err two times in lov_destroy().

15 years agoBranch HEAD
anserper [Tue, 14 Oct 2008 19:26:50 +0000 (19:26 +0000)]
Branch HEAD

b=17152
i=Johann Lombardi
i=Alexey Lyashkov

Take additional references to lov while operating over it

15 years agobranch: HEAD
ericm [Tue, 14 Oct 2008 18:59:51 +0000 (18:59 +0000)]
branch: HEAD
do not repost buffer before all requests are finished.
b=17228
r=wangdi
r=nathan

15 years agob=13490,i=maxim:
isaac [Tue, 14 Oct 2008 17:28:01 +0000 (17:28 +0000)]
b=13490,i=maxim:
-   fix credit flow deadlock in uptllnd.

15 years agob=17370
alex [Tue, 14 Oct 2008 10:35:34 +0000 (10:35 +0000)]
b=17370

 - fix warning caused by unused vars

15 years agoBranch HEAD
yangsheng [Tue, 14 Oct 2008 05:24:11 +0000 (05:24 +0000)]
Branch HEAD
b=17335
i=nathan, yangsheng
Author: johann

Don't set cld_lostlock in mgc_requeue_add() if RQ_STOP.

15 years agoBranch HEAD
fanyong [Tue, 14 Oct 2008 03:53:22 +0000 (03:53 +0000)]
Branch HEAD
b=16947
i=huanghua
i=johann

Code cleanup and possible race conditions fix when statahead startup.

15 years agob=12182
alex [Mon, 13 Oct 2008 11:35:15 +0000 (11:35 +0000)]
b=12182
i=adilger
i=green
i=nikita

 - oss read-only cache feature

15 years agob=17318
kalpak [Mon, 13 Oct 2008 09:50:54 +0000 (09:50 +0000)]
b=17318
i=adilger

Remove unused wantedi program

15 years ago- update from HEAD
alex [Mon, 13 Oct 2008 08:49:24 +0000 (08:49 +0000)]
- update from HEAD

15 years agofix return code from del orphan.
shadow [Sun, 12 Oct 2008 13:37:46 +0000 (13:37 +0000)]
fix return code from del orphan.
Branch HEAD
b=17279
i=umka
i=wangdi

15 years ago- removed more dead code (dead for >2 years as it was only needed when lmv used on...
yury [Sun, 12 Oct 2008 09:28:00 +0000 (09:28 +0000)]
- removed more dead code (dead for >2 years as it was only needed when lmv used on server side) from lmv

15 years agob=16890
anserper [Sat, 11 Oct 2008 01:16:25 +0000 (01:16 +0000)]
b=16890

remove fake test modules

15 years agoBranch HEAD ; b=16890 ; fix a typo
anserper [Fri, 10 Oct 2008 23:11:56 +0000 (23:11 +0000)]
Branch HEAD ; b=16890 ; fix a typo

15 years agoBranch HEAD
anserper [Fri, 10 Oct 2008 23:02:43 +0000 (23:02 +0000)]
Branch HEAD
b=16890
i=Johann Lombardi
i=ZhiYong Tian

remove outdated quota tests

15 years agob=17299
nathan [Fri, 10 Oct 2008 19:19:42 +0000 (19:19 +0000)]
b=17299
i=adilger
i=nathan
rename MAXPOOLNAME to LOV_MAXPOOLNAME

15 years agobranch: HEAD
ericm [Fri, 10 Oct 2008 17:36:51 +0000 (17:36 +0000)]
branch: HEAD
AT test sleep use current AT service time.
b=16990
o=Brian Behlendorf <behlendorf1@llnl.gov>
r=nathan
r=ericm

15 years agoBranch HEAD
robert.read [Thu, 9 Oct 2008 22:04:26 +0000 (22:04 +0000)]
Branch HEAD

Use correct libcfs version in v1_* tags.

15 years agob=15621
grev [Thu, 9 Oct 2008 20:16:23 +0000 (20:16 +0000)]
b=15621
i=Umka
test_51bb, verifies CMD functionality

15 years agoUpdated for the fourth incremental development build.
stinson1947 [Thu, 9 Oct 2008 19:22:03 +0000 (19:22 +0000)]
Updated for the fourth incremental development build.

15 years agob=15977
pravins [Thu, 9 Oct 2008 14:28:24 +0000 (14:28 +0000)]
b=15977
i=umka
i=grev
fixes for per-nid-stat memory leak patch.

15 years ago- update from HEAD
alex [Thu, 9 Oct 2008 07:34:30 +0000 (07:34 +0000)]
- update from HEAD

15 years agoBranch HEAD
robert.read [Wed, 8 Oct 2008 22:29:13 +0000 (22:29 +0000)]
Branch HEAD
b=16074
i=green
i=nikita

15 years agob=17277
grev [Wed, 8 Oct 2008 21:59:11 +0000 (21:59 +0000)]
b=17277
i=Adilger
one more $tdir cleanup

15 years agob=17277
grev [Wed, 8 Oct 2008 10:05:39 +0000 (10:05 +0000)]
b=17277
i=Adilger
s/MOUNT/DIR/ and related these changes fixes

15 years agob=16218
grev [Tue, 7 Oct 2008 20:21:44 +0000 (20:21 +0000)]
b=16218
i=Adilger
fix directio part; reduce multithreads filesize

15 years agoBranch HEAD
johann [Tue, 7 Oct 2008 15:13:01 +0000 (15:13 +0000)]
Branch HEAD
b=17026
i=shadow
i=oleg

Description: (ptllnd_peer.c:557:kptllnd_peer_check_sends()) ASSERTION(!in_interrupt()) failed
Details: fix stack overflow in the distributed lock manager by defering export
         eviction after a failed ast to the elt thread instead of handling
         it in the dlm interpret routine.

15 years agoUpdate the adio driver patch for mpich2-1.0.7
liuy [Tue, 7 Oct 2008 07:11:12 +0000 (07:11 +0000)]
Update the adio driver patch for mpich2-1.0.7

15 years agob=16150
mattwu [Tue, 7 Oct 2008 06:47:14 +0000 (06:47 +0000)]
b=16150
i=nikita
i=robert
winnt libcfs/lnet cleanup

15 years agob=16150
mattwu [Tue, 7 Oct 2008 06:43:43 +0000 (06:43 +0000)]
b=16150
i=nikita
i=robert
winnt libcfs/lnet cleanup

15 years agob=16150
mattwu [Tue, 7 Oct 2008 06:43:05 +0000 (06:43 +0000)]
b=16150
i=nikita
i=robert
winnt libcfs/lnetcleanup

15 years agob=16150
mattwu [Tue, 7 Oct 2008 06:42:27 +0000 (06:42 +0000)]
b=16150
i=nikita
i=robert
winnt libcfs/lnetcleanup

15 years agofilter_set_info_async(): fix a typo.
nikita [Tue, 7 Oct 2008 05:32:58 +0000 (05:32 +0000)]
filter_set_info_async(): fix a typo.

15 years agob=16150
mattwu [Tue, 7 Oct 2008 04:32:30 +0000 (04:32 +0000)]
b=16150
i=issac
i=liang
winnt lnet cleanup

15 years agob=16150
mattwu [Tue, 7 Oct 2008 04:14:14 +0000 (04:14 +0000)]
b=16150
i=adilger
i=robert
i=liang
winnt libcfs cleanup

15 years agoBranch HEAD
bobijam [Tue, 7 Oct 2008 03:25:53 +0000 (03:25 +0000)]
Branch HEAD
b=17038
o=johann
i=alexey.lyashkov (shadow)
i=zhenyu.xu (bobijam)

return ENODATA for getxattr upon files which are neither regular files nor directories.

15 years agob=15699
nathan [Mon, 6 Oct 2008 22:21:43 +0000 (22:21 +0000)]
b=15699
a=19432
i=manoj.joseph
i=vladimir.saveliev
add conf_param settings to mdd

b=17180
a=19402
i=nathan
i=johann
rename pools tests to a common base

b=17234
a=19563
i=yury.umanets
i=nathan
set pools for all MDTs for CMD

15 years agoi=wangdi:
isaac [Mon, 6 Oct 2008 20:01:11 +0000 (20:01 +0000)]
i=wangdi:
-   fixed a typo in error message.

15 years agoBranch HEAD
johann [Mon, 6 Oct 2008 13:59:54 +0000 (13:59 +0000)]
Branch HEAD
b=17261

fix cast issue.

15 years agoBranch HEAD
johann [Mon, 6 Oct 2008 13:57:32 +0000 (13:57 +0000)]
Branch HEAD
b=17261
i=shadow
i=umka

prevent ptlrpc_queue_wait() from looping indefinitely because of ENOMEM.

15 years agoBranch HEAD
yangsheng [Mon, 6 Oct 2008 12:45:34 +0000 (12:45 +0000)]
Branch HEAD
b=16771
i=adilger, shadow (Author: johann)

Calm donw the compiler warning.

15 years agoBranch HEAD
johann [Mon, 6 Oct 2008 12:28:53 +0000 (12:28 +0000)]
Branch HEAD
b=17261
i=adilger
i=shadow

cap lmm_size to LOV_MAX_STRIPE_COUNT.

15 years agoBranch HEAD
adilger [Fri, 3 Oct 2008 23:05:25 +0000 (23:05 +0000)]
Branch HEAD
Fix line wrapping.

15 years agoBranch b1_6
robert.read [Fri, 3 Oct 2008 22:44:46 +0000 (22:44 +0000)]
Branch b1_6
b=16455
i=brian
i=adilger

The libcfs macros can be defined as stubs in lnet. I used
m4_ifdef() for LC_CONFIG_SPLIT to localize the change to
a single branch.

15 years agoBranch HEAD
adilger [Fri, 3 Oct 2008 22:44:36 +0000 (22:44 +0000)]
Branch HEAD
Improve LASSERT message.

15 years agoBranch HEAD
adilger [Fri, 3 Oct 2008 22:17:42 +0000 (22:17 +0000)]
Branch HEAD
Fix line wrapping.

15 years agoBranch HEAD
adilger [Fri, 3 Oct 2008 22:09:09 +0000 (22:09 +0000)]
Branch HEAD
Remote old 2.4 kernel check.

15 years agoBranch HEAD
adilger [Fri, 3 Oct 2008 22:01:46 +0000 (22:01 +0000)]
Branch HEAD
Add start time to liblustre test messages.
Fix compiler warnings about types.

15 years agoBranch HEAD
adilger [Fri, 3 Oct 2008 21:36:41 +0000 (21:36 +0000)]
Branch HEAD
Add clarifying comment.

15 years agoBranch HEAD
adilger [Fri, 3 Oct 2008 21:33:16 +0000 (21:33 +0000)]
Branch HEAD
Fix whitespace.

15 years agob=17253
grev [Fri, 3 Oct 2008 20:36:24 +0000 (20:36 +0000)]
b=17253
i=Yury.Umanets
start_mds CMD fix

15 years agob=16986
pravins [Fri, 3 Oct 2008 12:57:03 +0000 (12:57 +0000)]
b=16986
i=umka
i=rread
fix condition check for calling kill_super_cb().