Whamcloud - gitweb
fs/lustre-release.git
15 years agoBranch HEAD
yangsheng [Wed, 9 Jul 2008 14:57:05 +0000 (14:57 +0000)]
Branch HEAD
b=16190

Back the change since OFED-1.3 will broken with rhel5.2 kernel.

15 years agoBranch HEAD
bobijam [Wed, 9 Jul 2008 01:27:06 +0000 (01:27 +0000)]
Branch HEAD
b=15825
o=green
i=shadow, bobijam

Description: Kernel BUG tries to release flock
Details    : Lustre does not destroy flock lock before last reference goes
             away. So always drop flock locks when client is evicted and
             perform unlock regardless of successfulness of speaking to MDS.

15 years agoBranch b1_8_gate
adilger [Tue, 8 Jul 2008 21:27:07 +0000 (21:27 +0000)]
Branch b1_8_gate
Make sure to check out the build, ldiskfs, and lnet gate tags for b1_8_gate.

15 years agoBranch HEAD
adilger [Tue, 8 Jul 2008 21:11:19 +0000 (21:11 +0000)]
Branch HEAD
Fix print format warning.
b=15981

15 years agoBranch HEAD
adilger [Tue, 8 Jul 2008 21:09:46 +0000 (21:09 +0000)]
Branch HEAD
Fix formatting of messages.

15 years agoBranch HEAD
adilger [Tue, 8 Jul 2008 21:08:53 +0000 (21:08 +0000)]
Branch HEAD
Print a useful message from "lfs df" when an OST is inactive.

15 years agoBranch HEAD
adilger [Tue, 8 Jul 2008 21:05:41 +0000 (21:05 +0000)]
Branch HEAD
Allow mount to continue if an invalid conf_param was specified.
b=14693
i=nathan
i=bowen.zhou

15 years agoBranch HEAD
adilger [Tue, 8 Jul 2008 21:02:21 +0000 (21:02 +0000)]
Branch HEAD
Cleanup compile warning.
b=15981

15 years agoBranch HEAD
adilger [Tue, 8 Jul 2008 21:01:40 +0000 (21:01 +0000)]
Branch HEAD
Fix compile warning.
b=15981

15 years agoBranch HEAD
adilger [Tue, 8 Jul 2008 21:00:13 +0000 (21:00 +0000)]
Branch HEAD
Ignore generated file.
b=<bug>

15 years agoBranch HEAD
adilger [Tue, 8 Jul 2008 20:40:11 +0000 (20:40 +0000)]
Branch HEAD
Don't drop LBUG/LASSERT messages (subsystem = 0) when processing the debug log.
b=16117

15 years agobranch: HEAD
ericm [Tue, 8 Jul 2008 19:13:30 +0000 (19:13 +0000)]
branch: HEAD
missing '\n' at end of debug message.

15 years agoBranch HEAD
adilger [Tue, 8 Jul 2008 18:14:15 +0000 (18:14 +0000)]
Branch HEAD
Don't print out commit callback messages except when they are increasing
the last_committed value.  The rest can assume to have been committed.

15 years agoBranch HEAD
adilger [Tue, 8 Jul 2008 18:12:26 +0000 (18:12 +0000)]
Branch HEAD
Tighten up kernel version slightly.

15 years agoBranch HEAD
adilger [Tue, 8 Jul 2008 18:10:55 +0000 (18:10 +0000)]
Branch HEAD
Quiet compiler warning due to printf format.
b=15981

15 years agoBranch HEAD
adilger [Tue, 8 Jul 2008 18:09:27 +0000 (18:09 +0000)]
Branch HEAD
Quiet compiler warning from casting pointer to integer of different size.
b=15981

15 years agoBranch HEAD
adilger [Tue, 8 Jul 2008 18:06:38 +0000 (18:06 +0000)]
Branch HEAD
Do pointer verification BEFORE dereferencing pointers.
Quiets compiler warnings.
b=15516

15 years agob=15516
pravins [Tue, 8 Jul 2008 17:32:01 +0000 (17:32 +0000)]
b=15516
i=tom.wang
i=yury.umanets

This patch is first step towards shifting mds-lov work to new
lustre mds stack.
        -       kill OBD_CLEANUP_SELF_EXP
        -       added rw_sem to serialize mds_notify and mds_precleanup
        -       kill OBD_CLEANUP_OBD

15 years agoBranch HEAD
adilger [Tue, 8 Jul 2008 16:46:30 +0000 (16:46 +0000)]
Branch HEAD
Remove trailing whitespace.

15 years agoBranch HEAD
fanyong [Tue, 8 Jul 2008 02:18:20 +0000 (02:18 +0000)]
Branch HEAD
b=16167
i=nikita
i=huanghua

If subdir count is up to ddp_max_nlink, then enable MNLINK_OBJ flag and
assign "i_nlink" to 1. It is a trick to break through the "i_nlink"
limitation for subdir count.

15 years agoremove setting for b_HEAD_AT which has landed.
ericm [Mon, 7 Jul 2008 20:43:57 +0000 (20:43 +0000)]
remove setting for b_HEAD_AT which has landed.

15 years agobranch: HEAD
ericm [Mon, 7 Jul 2008 20:15:53 +0000 (20:15 +0000)]
branch: HEAD
remove a separate mic section in gss packet, using the mechanism's token
to guarantee data integrity. by this we get better performance in krb5p.
b=16042
r=fanyong
r=wangdi

15 years agobranch: HEAD
ericm [Mon, 7 Jul 2008 19:12:54 +0000 (19:12 +0000)]
branch: HEAD
port Adaptive Timeouts from b1_6 to HEAD.
b=14071
r=nathan
r=adilger

15 years agobranch: HEAD
ericm [Mon, 7 Jul 2008 15:45:59 +0000 (15:45 +0000)]
branch: HEAD
fix gss build failure on x86_64.
b=16306

15 years agoBranch HEAD
bobijam [Mon, 7 Jul 2008 02:55:00 +0000 (02:55 +0000)]
Branch HEAD
b=13285
o=bowen.zhou
i=johann, bobijam

Add lctl dl '-t' option to print ost_conn_uuid for osc and mds_conn_uuid for mdc.

15 years agoBranch HEAD
bobijam [Mon, 7 Jul 2008 01:52:58 +0000 (01:52 +0000)]
Branch HEAD
b=14693
o=bowen.zhou
i=johann, bobijam

test case for "'lctl conf_param' stores invalid parameter, future mounts fail"

15 years agoBranch HEAD
yangsheng [Sun, 6 Jul 2008 15:25:03 +0000 (15:25 +0000)]
Branch HEAD
b=16247
i=sheng.yang
i=johann

Allow liblustre sanity to exclude tests

15 years agob=13128
kalpak [Sat, 5 Jul 2008 10:50:48 +0000 (10:50 +0000)]
b=13128
i=adilger
i=johann

Add uid and gid options to lfs manpage. numeric uid/gid should be accepted with -user/-group option

15 years ago- don't use OBD_CONNECT_FID flag for MGS/OSS
tappro [Sat, 5 Jul 2008 06:45:28 +0000 (06:45 +0000)]
- don't use OBD_CONNECT_FID flag for MGS/OSS
  b:15980
  i:adilger,yury

15 years agoBranch HEAD
vs [Fri, 4 Jul 2008 22:27:38 +0000 (22:27 +0000)]
Branch HEAD
b=14975
i=green
i=huanghua

Openlock cache forward port

15 years agoBranch: HEAD
wangdi [Fri, 4 Jul 2008 22:25:35 +0000 (22:25 +0000)]
Branch: HEAD
add stride read-ahead test case
b=16172
i=adilger,nikita

15 years agoBranch HEAD
anserper [Fri, 4 Jul 2008 22:05:49 +0000 (22:05 +0000)]
Branch HEAD
b=15754
i=Johann Lombardi (johann)
i=ZhiYong Tian (tianzy)

Including manual page into make files.

15 years agoBranch HEAD
wangdi [Fri, 4 Jul 2008 16:20:31 +0000 (16:20 +0000)]
Branch HEAD
check import before put it.
b=15684
i=adilger

15 years agocheck both names for symver file.
shadow [Fri, 4 Jul 2008 15:23:23 +0000 (15:23 +0000)]
check both names for symver file.
Branch HEAD
b=15870
i=brian

15 years agoFix hunk failures and thus add a slightly different patch for 2.6.5 (SLES9)
girish [Fri, 4 Jul 2008 14:55:01 +0000 (14:55 +0000)]
Fix hunk failures and thus add a slightly different patch for 2.6.5 (SLES9)
b=16258

15 years agoAdd a different patch, ext3-max-dir-size-2.6-suse.patch to SLES9 series.
girish [Fri, 4 Jul 2008 13:33:05 +0000 (13:33 +0000)]
Add a different patch, ext3-max-dir-size-2.6-suse.patch to SLES9 series.

15 years agoadd recount protection for osc callbacks, so avoid panic on shutdown
shadow [Fri, 4 Jul 2008 07:42:10 +0000 (07:42 +0000)]
add recount protection for osc callbacks, so avoid panic on shutdown

Branch HEAD
b=15210
i=green
i=umka

15 years agonot clear callbacks,obd_disconnect do this for us.
shadow [Fri, 4 Jul 2008 07:05:55 +0000 (07:05 +0000)]
not clear callbacks,obd_disconnect do this for us.

Branch HEAD
b=15210
i=green
i=deen

15 years agoBranch HEAD
yangsheng [Fri, 4 Jul 2008 06:53:22 +0000 (06:53 +0000)]
Branch HEAD
b=16190

back the change since OFED-1.3 build failes with this kernel.

15 years agoBranch HEAD
yangsheng [Fri, 4 Jul 2008 03:25:30 +0000 (03:25 +0000)]
Branch HEAD
b=16190
i=johann, shadow, zhenyu.xu

Update to RHEL5 kernel-2.6.18-92.1.6.el5.

15 years agoBranch: HEAD
wangdi [Fri, 4 Jul 2008 02:12:23 +0000 (02:12 +0000)]
Branch: HEAD
add doxygen doc for filter group llog api.
b=14629
i=robert,jay

15 years agoBranch HEAD
bobijam [Fri, 4 Jul 2008 01:31:03 +0000 (01:31 +0000)]
Branch HEAD
b=14480
i=green

add doxygen doc for ldlm_flock_waitq and ldlm_flock_waitq_lock.

15 years agoBranch b1_8
adilger [Fri, 4 Jul 2008 00:21:00 +0000 (00:21 +0000)]
Branch b1_8
Remove the "ext3-max-dir-size" patch from the SLES 9 series, it is causing
build failures.
b=16258

15 years agoBranch HEAD
adilger [Thu, 3 Jul 2008 23:22:42 +0000 (23:22 +0000)]
Branch HEAD
Change the LU_CACHE size from 30% of free memory to 20% of total memory,
to make the cache size deterministic, and also not depend on a new kernel
symbol.
b=16232
i=nikita
i=yury

15 years agoBranch: HEAD
wangdi [Thu, 3 Jul 2008 22:37:08 +0000 (22:37 +0000)]
Branch: HEAD
sync procfs/llog_thread with import destory
b=15684
i=Robert, Jay

15 years agobranch: HEAD
ericm [Thu, 3 Jul 2008 22:19:27 +0000 (22:19 +0000)]
branch: HEAD
fix build breakage of utils/gss.

15 years agoBranch b_head_libcfs
robert.read [Thu, 3 Jul 2008 20:48:32 +0000 (20:48 +0000)]
Branch b_head_libcfs
b=16159
i=isaac

Cleanup liblustre.

15 years agoBranch HEAD
robert.read [Thu, 3 Jul 2008 20:44:37 +0000 (20:44 +0000)]
Branch HEAD

update .cvsignore.

15 years agoBranch HEAD
robert.read [Thu, 3 Jul 2008 20:33:19 +0000 (20:33 +0000)]
Branch HEAD

add b_head_libcfs to build/buildcvs

15 years agoBranch: HEAD
wangdi [Thu, 3 Jul 2008 20:11:49 +0000 (20:11 +0000)]
Branch: HEAD
1.Filter group llog cleanup (patch from shadow).
2.Separate filter group llog create and find. then filter group llog will
  only be created in the mds/ost syncing process.
3.Some minor fixes.
b=14629
i=robert,yury

15 years agobranch: HEAD
ericm [Thu, 3 Jul 2008 19:53:12 +0000 (19:53 +0000)]
branch: HEAD
add debug lines for keyring.

15 years agoHEAD
robert.read [Thu, 3 Jul 2008 19:50:56 +0000 (19:50 +0000)]
HEAD
b=15940
i=isaac
i=oleg

Convert kp30.h to an internal libcfs include and change users of kp30.h to
include libcfs.h if they were not already.

This renames the include.

15 years agoBranch HEAD
robert.read [Thu, 3 Jul 2008 19:48:16 +0000 (19:48 +0000)]
Branch HEAD
b=15998
i=adilger

Fix make rpms on HEAD.

15 years agoBranch HEAD
robert.read [Thu, 3 Jul 2008 19:46:01 +0000 (19:46 +0000)]
Branch HEAD
b=15940
i=isaac
i=oleg

Convert kp30.h to an internal libcfs include and change users of kp30.h to
include libcfs.h if they were not already.

15 years agobranch: HEAD
ericm [Thu, 3 Jul 2008 18:01:37 +0000 (18:01 +0000)]
branch: HEAD
(original patch from Benjamin Bennett of PSC)
- restore previous behavior of accepting remote principals.
- minor fix logging messages.
b=16148
r=ericm
r=fanyong

15 years agoBranch HEAD
huanghua [Thu, 3 Jul 2008 15:30:56 +0000 (15:30 +0000)]
Branch HEAD
b=15552
i=adilger
i=nikita.danilov

- mapping ino for FID into [2B, 4B]

15 years agoBranch HEAD
johann [Thu, 3 Jul 2008 07:23:15 +0000 (07:23 +0000)]
Branch HEAD
b=16260

Add test 119d (has just been added by bug 15950) to the except list until bug
16260 is fixed.

15 years agoBranch HEAD
johann [Thu, 3 Jul 2008 07:16:34 +0000 (07:16 +0000)]
Branch HEAD
b=15950
i=wangdi
i=shadow

The direct IO path doesn't call check_rpcs to submit a new RPC once
one is completed. As a result, some RPCs are stuck in the queue
and are never sent.
Merge brw_interpret() and brw_interpret_oap().

15 years agoBranch HEAD
yangsheng [Thu, 3 Jul 2008 05:06:54 +0000 (05:06 +0000)]
Branch HEAD
b=16189
i=johann, zhenyu.xu

Update to RHEL4 kernel-2.6.9-67.0.20.

15 years ago- removed trailing spaces and converted tabs.
isaac [Thu, 3 Jul 2008 04:42:07 +0000 (04:42 +0000)]
-   removed trailing spaces and converted tabs.

15 years agoUpdated version from 1.8.0 to 2.0.0
stinson1947 [Thu, 3 Jul 2008 02:08:44 +0000 (02:08 +0000)]
Updated version from 1.8.0 to 2.0.0

15 years agoBranch HEAD
anserper [Thu, 3 Jul 2008 01:09:21 +0000 (01:09 +0000)]
Branch HEAD
b=14010
i=shadow
i=zam

Short read patch.

15 years agoBranch HEAD
adilger [Wed, 2 Jul 2008 21:20:37 +0000 (21:20 +0000)]
Branch HEAD
Add "setstripe" parameter descriptions to lfs man page
b=15754

15 years agocleanup usage obd_set_info_async, obd_get_info.
shadow [Wed, 2 Jul 2008 06:01:57 +0000 (06:01 +0000)]
cleanup usage obd_set_info_async, obd_get_info.
fix KEY_IS macro

Branch HEAD
b=14032
i=umka
i=deen

15 years agoBranch HEAD
anserper [Tue, 1 Jul 2008 22:09:23 +0000 (22:09 +0000)]
Branch HEAD
b=15754
i=Johann(johann)
i=ZhiYong(tianzy)

a manual page for llapi_quotactl(3)

15 years agoBranch HEAD
bwzhou [Tue, 1 Jul 2008 08:41:32 +0000 (08:41 +0000)]
Branch HEAD
b=11990
r=johann, bobijam

zeroed param upon every mount point

15 years agoPutting the branch name at proper switch case to get libcfs changes
deshmukh [Tue, 1 Jul 2008 05:48:16 +0000 (05:48 +0000)]
Putting the branch name at proper switch case to get libcfs changes

15 years agob=13128
kalpak [Tue, 1 Jul 2008 04:25:18 +0000 (04:25 +0000)]
b=13128
i=adilger
i=johann

add -gid,-group,-uid-,-user options to lfs find

15 years agoBranch HEAD
bobijam [Tue, 1 Jul 2008 03:38:57 +0000 (03:38 +0000)]
Branch HEAD
b=12653
i=green, johann
Description: sanity test 65a fails if stripecount of -1 is set
Details    : handle -1 striping on filesystem in ll_dirstripe_verify

15 years agoBranch HEAD
fanyong [Tue, 1 Jul 2008 02:06:00 +0000 (02:06 +0000)]
Branch HEAD
b=15797
i=huanghua
i=vitaly

Misc fix for updating file {a/m/c}time as following policy:
1) Lustre file "{a/m/c}time" should base on client-side clock, including all
the file operations.
2) All the client-side clocks should be synchronized. It is no matter whether
the server-side clocks are synchronized with client-side ones or not.
3) File "ctime" is increased only.
4) File "{a,m}time" are increased only, except "utime()" operation can change
them backwards.

15 years agoBranch: HEAD
wangdi [Mon, 30 Jun 2008 18:52:13 +0000 (18:52 +0000)]
Branch: HEAD
Two minors fixes for stride read-ahead.
b=14483
i=adilger

15 years agobadly clear PG_Writeback bit in ll_ap_completion can produce false
shadow [Mon, 30 Jun 2008 12:29:46 +0000 (12:29 +0000)]
badly clear PG_Writeback bit in ll_ap_completion can produce false
positive assertion

Branch HEAD
b=14742
i=nikita
i=johan

15 years agofix issue with >8TB fs: group doesn't fit in 16bits anymore
alex [Mon, 30 Jun 2008 04:45:58 +0000 (04:45 +0000)]
fix issue with >8TB fs: group doesn't fit in 16bits anymore

b=16101
i=adilger
i=kalpak

15 years agoBranch HEAD
yangsheng [Sun, 29 Jun 2008 15:41:47 +0000 (15:41 +0000)]
Branch HEAD
b=16221
i=adilger

Remove 2.6.12-vanilla support from HEAD.

15 years agob=13103 (patch by adilger)
kalpak [Sun, 29 Jun 2008 10:08:39 +0000 (10:08 +0000)]
b=13103 (patch by adilger)
i=kalpak,girish

upstream e2fsprogs calls uninit_groups feature as uninit_bg. So mkfs.lustre should check for uninit_bg feature also

15 years agoIn ldlm_resource_add_lock(), call to ldlm_resource_dump()
deen [Sat, 28 Jun 2008 10:04:50 +0000 (10:04 +0000)]
In ldlm_resource_add_lock(), call to ldlm_resource_dump()
starve other threads from the resource lock for a long time in
case of long waiting queue, so change the debug level from
D_OTHER to the less frequently used D_INFO.

b=15953
i=adilger
i=nathan.rutman

15 years agoBranch: b1_8
adilger [Sat, 28 Jun 2008 06:30:54 +0000 (06:30 +0000)]
Branch: b1_8
Remove unused variable.

15 years agoBranch HEAD
adilger [Sat, 28 Jun 2008 04:54:49 +0000 (04:54 +0000)]
Branch HEAD
Ensure all module symbols from ldiskfs and OFED are available.
b=16112
i=brian
i=shadow

15 years agoBranch HEAD
adilger [Fri, 27 Jun 2008 22:04:32 +0000 (22:04 +0000)]
Branch HEAD
Make this code the same as b1_6 (mostly whitespace removal and comment updates)
for ease of comparison.  The only remaining difference is the optimization to
skip getting lq_rw_sem if we are using RR allocation.

15 years agob_HEAD_AT use the same tags of ldiskfs/libcfs as of HEAD.
ericm [Fri, 27 Jun 2008 21:53:52 +0000 (21:53 +0000)]
b_HEAD_AT use the same tags of ldiskfs/libcfs as of HEAD.

15 years agoBranch:HEAD
wangdi [Fri, 27 Jun 2008 17:32:44 +0000 (17:32 +0000)]
Branch:HEAD
missing stride start_offset in stride read-ahead.
b=16172
i=Oleg,Johann

15 years agoBranch HEAD
bwzhou [Fri, 27 Jun 2008 16:49:30 +0000 (16:49 +0000)]
Branch HEAD
b=14693
r=nathan

Don't return an error for conf param processing failures

15 years agoBranch HEAD
adilger [Fri, 27 Jun 2008 09:56:32 +0000 (09:56 +0000)]
Branch HEAD
Add comments to ldlm_enqueue_info fields.

15 years agoBranch HEAD
adilger [Fri, 27 Jun 2008 09:37:32 +0000 (09:37 +0000)]
Branch HEAD
Specify a MODULE_LICENSE for lloop module to avoid kernel tainting.
From b1_6.
b=5498
i=nathan
i=jay

15 years agob=5188
grev [Fri, 27 Jun 2008 09:34:48 +0000 (09:34 +0000)]
b=5188
add test_68 to ALWAYS_EXCEPT list

15 years agoBranch HEAD
adilger [Fri, 27 Jun 2008 09:31:19 +0000 (09:31 +0000)]
Branch HEAD
Quiet compiler warnings.

15 years agoBranch HEAD
adilger [Fri, 27 Jun 2008 09:23:48 +0000 (09:23 +0000)]
Branch HEAD
Allow both "clear" and "clear\n" to be written to ldlm.namespaces.*.lru_size.
Minor line wrapping and whitespace cleanup.
b=13868

15 years agoBranch HEAD
adilger [Fri, 27 Jun 2008 09:12:38 +0000 (09:12 +0000)]
Branch HEAD
Remove stale comment.

15 years agoBranch HEAD
huanghua [Fri, 27 Jun 2008 04:01:01 +0000 (04:01 +0000)]
Branch HEAD
b=16000
i=adilger
i=nikita.danilov

one more bit in sequence for IGIF and IDIF

15 years agoBranch HEAD
bwzhou [Fri, 27 Jun 2008 03:26:27 +0000 (03:26 +0000)]
Branch HEAD
b=15881
r=rread

rewrite sanity 129

15 years agoBranch HEAD
adilger [Thu, 26 Jun 2008 21:49:41 +0000 (21:49 +0000)]
Branch HEAD
Remove write permissions of files in the lustre-source RPM to avoid
any security risk.
b=16180
i=brian
i=terry

15 years agoBranch b1_6
adilger [Thu, 26 Jun 2008 21:09:09 +0000 (21:09 +0000)]
Branch b1_6
Fix ldiskfs configure.ac to match ChangeLog version.

15 years agoBranch b1_6
adilger [Thu, 26 Jun 2008 21:07:21 +0000 (21:07 +0000)]
Branch b1_6
Fix indenting to use tabs.

15 years agob=13934
yury [Thu, 26 Jun 2008 21:04:45 +0000 (21:04 +0000)]
b=13934
r=tappro,fanyong
- fixes unaligned access on 64 bit platforms. Thanks to Nikita for these patches.

15 years agoBranch HEAD
adilger [Thu, 26 Jun 2008 20:21:43 +0000 (20:21 +0000)]
Branch HEAD
Fix usage message to avoid referring to parameters as "files".
b=14471

15 years agoBranch HEAD
adilger [Thu, 26 Jun 2008 19:49:01 +0000 (19:49 +0000)]
Branch HEAD
Ignore generated files
b=16112

15 years agoBranch HEAD
adilger [Wed, 25 Jun 2008 22:50:07 +0000 (22:50 +0000)]
Branch HEAD
Ignore generated files
b=16112

15 years agob=15863
yury [Wed, 25 Jun 2008 22:14:03 +0000 (22:14 +0000)]
b=15863
r=shadow,wangdi
- fixes missed llcd_put() and wrong flag passed to llog_cleanup_commit_master() what again led to missing some llcd to be decrefed in cleanup. Fixes test_42 from replay-single.sh;
- some comments to understand llcd live cycle better next time.

15 years agoAdd missing .cvsignore files.
robert.read [Wed, 25 Jun 2008 21:04:08 +0000 (21:04 +0000)]
Add missing .cvsignore files.

15 years agoBranch b_hd_dmu
rcorreia [Wed, 25 Jun 2008 20:38:29 +0000 (20:38 +0000)]
Branch b_hd_dmu
Updated library names and paths due to zfs-lustre changes.
Updated lustrecvs to show helpful message if mercurial is missing.
Changed default zfs-lustre path from zfs-lustre/ to lustre/zfs-lustre/.
Added paths of zfs-lustre tools to test-framework.sh.

b=14778
i=alex.zhuravlev
i=manoj.joseph