Whamcloud - gitweb
fs/lustre-release.git
4 years agoLU-7079 ptlrpc: imp_peer_committed_transno should increase 61/16161/5
Alex Zhuravlev [Tue, 1 Sep 2015 14:28:46 +0000 (17:28 +0300)]
LU-7079 ptlrpc: imp_peer_committed_transno should increase

imp_peer_committed_transno should not decrease as this can
confuse the users if imp_peer_committed_transno is used to
check commit status.

Change-Id: I8a1fdc651d837987bbe9aecc859b36849f9ee0a7
Signed-off-by: Alex Zhuravlev <alexey.zhuravlev@intel.com>
Reviewed-on: http://review.whamcloud.com/16161
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Mike Pershin <mike.pershin@intel.com>
Reviewed-by: wangdi <di.wang@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-5718 o2iblnd: avoid intensive reconnecting 00/14600/6
Liang Zhen [Tue, 25 Aug 2015 16:25:34 +0000 (12:25 -0400)]
LU-5718 o2iblnd: avoid intensive reconnecting

When there is connection race between two nodes and one side of
connection is rejected by remote side, o2iblnd will reconnect
immediately, this is going to generate a lot of memory pressure and
even cause OOM if remote side is slow and can't complete connecting
request in short time.

This patch resolves this issue by reconnecting after rejected
connection has been destroyed by connd, so there is no more than
one zombie connection for each peer.

Signed-off-by: Liang Zhen <liang.zhen@intel.com>
Change-Id: I78d3b00be70231d576572832b9b0fba2df3d3c12
Reviewed-on: http://review.whamcloud.com/14600
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Doug Oucharek <doug.s.oucharek@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-7059 mdt: reset rc=0 in mdt_lock_objects_in_linkea 31/16131/2
wang di [Thu, 27 Aug 2015 17:28:19 +0000 (10:28 -0700)]
LU-7059 mdt: reset rc=0 in mdt_lock_objects_in_linkea

reset rc to 0 in mdt_lock_objects_in_linkea, otherwise
it might cause migration failure for mulitple link file.

Add sanity.sh 230e to verify the case.

Signed-off-by: wang di <di.wang@intel.com>
Change-Id: I063a6e461e2fe427105e8063720f59df42a8eda3
Reviewed-on: http://review.whamcloud.com/16131
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Lai Siyao <lai.siyao@intel.com>
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
4 years agoLU-7072 tests: Fix and re-enable test 78 in sanityn 78/16178/3
Henri Doreau [Wed, 2 Sep 2015 08:55:40 +0000 (10:55 +0200)]
LU-7072 tests: Fix and re-enable test 78 in sanityn

Early NRS policy tunings can fail for the following reasons:
  - Policy not started (ENODEV)
  - Policy not fully initialized (EAGAIN)

Make test_78 of sanityn handle both properly and re-enable it.

Signed-off-by: Henri Doreau <henri.doreau@cea.fr>
Change-Id: I1d68ad709d0ac1c8ee9dabebf565c786d7c904da
Reviewed-on: http://review.whamcloud.com/16178
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Jenkins
Tested-by: Andreas Dilger <andreas.dilger@intel.com>
4 years agoLU-6853 build: Add python-docutils to dkms.spec 63/16163/2
Nathaniel Clark [Tue, 1 Sep 2015 18:20:45 +0000 (14:20 -0400)]
LU-6853 build: Add python-docutils to dkms.spec

Require python-docutils for rst2man during build of lustre.

Signed-off-by: Nathaniel Clark <nathaniel.l.clark@intel.com>
Change-Id: I1235c9296c6b1fc5a309cd3018c9fcb3eea452e9
Reviewed-on: http://review.whamcloud.com/16163
Tested-by: Jenkins
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Minh Diep <minh.diep@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6766 build: add support for arm64 95/15395/3
Arnaud Guignard [Fri, 19 Jun 2015 08:51:24 +0000 (10:51 +0200)]
LU-6766 build: add support for arm64

Expand lustre to support the ARM64 platform.

The architecture is reported as aarch64 so add that support to
lustre-build-linux.m4.

For the Red Hat/Fedora packaging, strip the aarch64 suffix for the
required kernel.

Add definitions for lstat_t, lstat_f, fstat_f and fstatat_f for aarch64
architecture in lustre/include/lustre/lustre_user.h.

Change-Id: I2d4a9e7be4d4c32ab99da802f1b2318764e4386e
Signed-off-by: Arnaud Guignard <arnaud.guignard@cea.fr>
Reviewed-on: http://review.whamcloud.com/15395
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-5977 ofd: Removed correction for bad timestamps 77/16077/3
Giuseppe Di Natale [Wed, 19 Aug 2015 22:52:56 +0000 (15:52 -0700)]
LU-5977 ofd: Removed correction for bad timestamps

Removed a correction made to handle a bug with negative
timestamps in Lustre 2.1.0.

Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Change-Id: I8bddd4370ac907a794b4b1c41062de482bee42f4
Reviewed-on: http://review.whamcloud.com/16077
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Jenkins
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
4 years agoLU-5974 ptlrpc: Removed checksum compatibility with 1.8 76/16076/4
Giuseppe Di Natale [Fri, 21 Aug 2015 22:57:40 +0000 (15:57 -0700)]
LU-5974 ptlrpc: Removed checksum compatibility with 1.8

Removed version checks which enabled checksum compatibility
with Lustre version 1.8

Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Change-Id: I15895cd7236c4c864a8597faf2c43d1548cfcfb2
Reviewed-on: http://review.whamcloud.com/16076
Reviewed-by: Christopher J. Morrone <morrone2@llnl.gov>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
4 years agoLU-6142 ldlm: remove ldlm typedef usage from code 00/15300/8
Andreas Dilger [Wed, 6 May 2015 21:53:51 +0000 (15:53 -0600)]
LU-6142 ldlm: remove ldlm typedef usage from code

Replace usage of ldlm_mode_t, ldlm_type_t, ldlm_policy_data_t,
ldlm_wire_policy_data_t, ldlm_error_t, ldlm_side_t, ldlm_appetite_t,
ldlm_ns_type_t, ldlm_cancel_flags_t, ldlm_policy_res_t, and
ldlm_ns_hash_def with named enums to conform to upstream coding style.

Fix users of flags that were using "int" instead of named enum.
Rename some "flags" variables to distinguish between different flags.

Rename LDLM_CANCEL_* flags (used with enum ldlm_lru_flags) to
LDLM_LRU_FLAGS_* to avoid confusion with enum ldlm_cancel_flags.

Remove unused write-only field lr_most_restr from ldlm_resource.

Add deprecated typedefs into checkpatch.pl so that they generate
warnings for new patches.

Because these fields are so widely used, removing the typedefs
entirely is put into a second patch that can be landed later,
after other in-flight patches using these typedefs have been landed,
or refreshed to remove their use.

Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Change-Id: Ibdba36496953017c406b41c6e0b6986dfa3cab07
Reviewed-on: http://review.whamcloud.com/15300
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6401 headers: Create single .h for lu_seq_range 52/15952/8
Ben Evans [Thu, 20 Aug 2015 14:07:07 +0000 (09:07 -0500)]
LU-6401 headers: Create single .h for lu_seq_range

Put lu_seq_range related functions into a single .h.
Include directly from files which use it, and remove definitions from
lustre_idl.h

Signed-off-by: Ben Evans <bevans@cray.com>
Change-Id: I2e8912688bc5b9fd77fd7b1c85d2dee27cfd825c
Reviewed-on: http://review.whamcloud.com/15952
Tested-by: Jenkins
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6215 o2iblnd: handle new struct ib_cq_init_attr 18/16118/2
James Simmons [Thu, 27 Aug 2015 22:14:32 +0000 (18:14 -0400)]
LU-6215 o2iblnd: handle new struct ib_cq_init_attr

For linux kernel version 4.2 the infiniband layer
created a new structure ib_cq_init_attr to pass to
ib_create_cq(). This patch handles this new case.
See linux commit 8e37210b38fb7d6aa06aebde763316ee955d44c0

Change-Id: I0db25c8bf6a4fb11a120607a45f8f1e546c375d6
Signed-off-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-on: http://review.whamcloud.com/16118
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Reviewed-by: frank zago <fzago@cray.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6215 llite: file->f_dentry no longer exist 19/16119/2
James Simmons [Thu, 27 Aug 2015 22:19:55 +0000 (18:19 -0400)]
LU-6215 llite: file->f_dentry no longer exist

In newer kernels file->f_dentry no long exist.
Convert the recent changes that used file->f_dentry
to use the proper file_path.dentry. This time
add a checkpatch warning so this can be avoided
in the future.

Change-Id: I5b0c54f3fd80d548c5fa527a3edf95ef03f97122
Signed-off-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-on: http://review.whamcloud.com/16119
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Reviewed-by: frank zago <fzago@cray.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-7057 utils: use stronger flags when opening volatile files 26/16126/2
John L. Hammond [Fri, 28 Aug 2015 18:03:52 +0000 (13:03 -0500)]
LU-7057 utils: use stronger flags when opening volatile files

Existing files with volatile-ish names may be accidentally opened by
llapi_create_volatile(). This is not the intent so disallow this
behavior by adding O_EXCL and O_NOFOLLOW to the flags to open().

Signed-off-by: John L. Hammond <john.hammond@intel.com>
Change-Id: I4246ec7660b154ea2aeca6c28a4704ddd9d429f8
Reviewed-on: http://review.whamcloud.com/16126
Tested-by: Jenkins
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Jinshan Xiong <jinshan.xiong@intel.com>
4 years agoLU-7072 tests: disable sanityn test 78 64/16164/4
Oleg Drokin [Tue, 1 Sep 2015 18:23:18 +0000 (14:23 -0400)]
LU-7072 tests: disable sanityn test 78

It looks there is a race in this test that makes it to fail often.
The fix itself is useful so I am disabling the test for now
and hope for a quick fix to the test itself.

Change-Id: Iee70b59d0d2dc98bc8542b8e8848da9bd964c841
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Reviewed-on: http://review.whamcloud.com/16164
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
4 years agoLU-6968 llog: Only update necessary part of header 05/15905/6
wang di [Wed, 5 Aug 2015 08:03:42 +0000 (01:03 -0700)]
LU-6968 llog: Only update necessary part of header

During llog_cancel_rec(), only update the part of header,
instead of the whole header, otherwise it might need pack
the whole header (32KB) into the RPC for each record
cancellation.

Signed-off-by: wang di <di.wang@intel.com>
Change-Id: I1e6e04b5b725ca8ed500b6c4d767719d7ff5f658
Reviewed-on: http://review.whamcloud.com/15905
Tested-by: Jenkins
Reviewed-by: Mike Pershin <mike.pershin@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-7049 osp: Not attr_get for new OSP object 02/16102/2
wang di [Tue, 25 Aug 2015 11:42:46 +0000 (04:42 -0700)]
LU-7049 osp: Not attr_get for new OSP object

Do not do attr_get for new OSP object, to save
RPC between MDTs.

Signed-off-by: wang di <di.wang@intel.com>
Change-Id: Iecc0fde64f076b28c752294c8b403693fe26e43a
Reviewed-on: http://review.whamcloud.com/16102
Tested-by: Jenkins
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Lai Siyao <lai.siyao@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6215 client: cancel_dirty_page revival 69/16069/4
James Simmons [Tue, 25 Aug 2015 22:12:10 +0000 (18:12 -0400)]
LU-6215 client: cancel_dirty_page revival

For linux kernel version 4.2 we see the return of the
function cancel_dirty_page() except it does not take
the second argument anymore. This happened in linux
commit 11f81becca04bb7d2826a9b65bb8d27b0a1bb543.

Change-Id: If3156dddcc2f104f128ce5b76ed9839d97054448
Signed-off-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-on: http://review.whamcloud.com/16069
Reviewed-by: frank zago <fzago@cray.com>
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6356 ptlrpc: do not switch out-of-date context 08/15708/3
Sebastien Buisson [Thu, 23 Jul 2015 11:37:37 +0000 (13:37 +0200)]
LU-6356 ptlrpc: do not switch out-of-date context

When trying to replace a dead sec context with a new one, we must
ensure the new context is already up-to-date.
If it is not the case, just return from sptlrpc_req_replace_dead_ctx()
and come later when the new context has been updated.

Signed-off-by: Sebastien Buisson <sebastien.buisson@bull.net>
Change-Id: I3b0862f838b917b568e08d46a24581a39c9459c1
Reviewed-on: http://review.whamcloud.com/15708
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Mike Pershin <mike.pershin@intel.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6999 osp: disable xattr cache for mdt obj 74/15974/4
wang di [Tue, 11 Aug 2015 12:23:34 +0000 (05:23 -0700)]
LU-6999 osp: disable xattr cache for mdt obj

Because ldlm lock is missing for xattr cache on OSP obj,
let's Disable xattr cache for remote MDT object.

Signed-off-by: wang di <di.wang@intel.com>
Change-Id: I4a7fa5f13791d531309f380f9e9303d04816c6a9
Reviewed-on: http://review.whamcloud.com/15974
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Fan Yong <fan.yong@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Lai Siyao <lai.siyao@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoNew tag 2.7.59 2.7.59 v2_7_59 v2_7_59_0
Oleg Drokin [Tue, 1 Sep 2015 01:32:56 +0000 (21:32 -0400)]
New tag 2.7.59

Change-Id: I98e4ec8cc33ab31ab36e386884748770b0850fde
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6974 util: set max_sectors_kb properly 16/16116/5
Andreas Dilger [Fri, 28 Aug 2015 19:48:28 +0000 (13:48 -0600)]
LU-6974 util: set max_sectors_kb properly

Reduce max_sectors_kb to avoid crash on some special block devices.

Test-Parameters: alwaysuploadlogs envdefinitions=SLOW=yes,ENABLE_QUOTA=yes  mdtfilesystemtype=ldiskfs mdsfilesystemtype=ldiskfs  ostfilesystemtype=ldiskfs clientdistro=el7 ossdistro=el7  mdsdistro=el7 mdtcount=1 testlist=runtests
Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Change-Id: Ifc7efd169f0db0b54c3f727fc65716c203930e29
Reviewed-on: http://review.whamcloud.com/16116
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6903 lov: call lov_object_find_cbdata() inside lock 48/15748/3
Jinshan Xiong [Mon, 27 Jul 2015 17:52:13 +0000 (10:52 -0700)]
LU-6903 lov: call lov_object_find_cbdata() inside lock

It should be called inside layout type lock otherwise the layout may
change and hit assertion.

Signed-off-by: Jinshan Xiong <jinshan.xiong@intel.com>
Change-Id: I61d8c2a4f770ee0b05428ac763fc0d0db833f289
Reviewed-on: http://review.whamcloud.com/15748
Tested-by: Jenkins
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Henri Doreau <henri.doreau@cea.fr>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6749 lod: properly remove proc entry 11/16011/2
Bobi Jam [Tue, 18 Aug 2015 04:34:52 +0000 (12:34 +0800)]
LU-6749 lod: properly remove proc entry

After remove lod_device::lod_symlink proc entry, reset it to NULL.

Signed-off-by: Bobi Jam <bobijam.xu@intel.com>
Change-Id: I4b4a871a7c6d9b5b3913d18c8d392a9c0345f919
Reviewed-on: http://review.whamcloud.com/16011
Tested-by: Jenkins
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Fan Yong <fan.yong@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6667 llite: improve ll_getname 89/15089/11
Oleg Drokin [Mon, 24 Aug 2015 15:40:08 +0000 (11:40 -0400)]
LU-6667 llite: improve ll_getname

strncpy_from_user could return negative values on error,
so need to take those into account.
Since ll_getname is used to get a single component name from userspace
to transfer to server as-is, there's no need to allocate 4k buffer
as done by __getname. Allocate NAME_MAX+1 buffer instead to ensure
we have enough for a null terminated max valid length buffer.

Change-Id: I9ce50d33864c7efd6fd019b592199f4fcf75410c
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Reviewed-on: http://review.whamcloud.com/15089
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
4 years agoLU-6215 libcfs: handle topology_thread_cpumask rename 49/16049/3
James Simmons [Tue, 25 Aug 2015 19:24:56 +0000 (15:24 -0400)]
LU-6215 libcfs: handle topology_thread_cpumask rename

For linux kernel version 4.2 we see topology_thread_cpumask get
renamed in commit 06931e62246844c73fba24d7aeb4a5dc897a2739.
This patch handles this rename.

Change-Id: I7437be9a086a38762346e271b346059ccfa13a8c
Signed-off-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-on: http://review.whamcloud.com/16049
Reviewed-by: frank zago <fzago@cray.com>
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6245 libcfs: remove linux-utils.c 10/15910/5
James Simmons [Mon, 24 Aug 2015 20:49:25 +0000 (16:49 -0400)]
LU-6245 libcfs: remove linux-utils.c

The source file linux-utils.c contains only empty
functions of features that were never implemented.
We can delete this unused code.

Change-Id: Id5820a94d15b055096544120fb14b987604e733c
Signed-off-by: frank zago <fzago@cray.com>
Signed-off-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-on: http://review.whamcloud.com/15910
Tested-by: Jenkins
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6912 lnet: rework autoconf rules for external OFED 11/15811/4
Dmitry Eremin [Thu, 30 Jul 2015 20:44:38 +0000 (23:44 +0300)]
LU-6912 lnet: rework autoconf rules for external OFED

Remove extra checks for OFED development headers location because of
issue on Ubuntu.

Check for O2IBPATH/include/linux/compat_autoconf.h in modern OFEDs and
automatically generate CONFIG_COMPAT_RHEL_*_* for RHEL distributive if
it absent.

Signed-off-by: Dmitry Eremin <dmitry.eremin@intel.com>
Change-Id: I6d21266bceca61504c0cca2d981f55ba22a85451
Reviewed-on: http://review.whamcloud.com/15811
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Chris Horn <hornc@cray.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-5683 llite: Inform copytool of dataversion changes 77/14377/2
Henri Doreau [Tue, 7 Apr 2015 13:10:12 +0000 (15:10 +0200)]
LU-5683 llite: Inform copytool of dataversion changes

Notify copytool that a file could not be archived due to dataversion
change. This does not introduce any functional change but ensures
that errors are consistently reported in copytool logs.

Signed-off-by: Henri Doreau <henri.doreau@cea.fr>
Change-Id: I0608a0ed06cf5d45eb140ac3e32e2b58baafdf0e
Reviewed-on: http://review.whamcloud.com/14377
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Jinshan Xiong <jinshan.xiong@intel.com>
Reviewed-by: Robert Read <robert.read@intel.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6673 ptlrpc: Forbid too early NRS policy tunings 04/15104/9
Henri Doreau [Tue, 2 Jun 2015 15:48:32 +0000 (17:48 +0200)]
LU-6673 ptlrpc: Forbid too early NRS policy tunings

Wait for a NRS policy to be fully started before allowing
to apply related tunings, so that all fields are properly
initialized.

Add corresponding test to sanityn.

Signed-off-by: Henri Doreau <henri.doreau@cea.fr>
Change-Id: I92df8f55aebd173a26979e9a506c45f985107d8a
Reviewed-on: http://review.whamcloud.com/15104
Tested-by: Jenkins
Reviewed-by: Emoly Liu <emoly.liu@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6158 mdt: always shrink_capsule in getxattr_all 24/13524/9
Sergey Cheremencev [Fri, 23 Jan 2015 13:52:01 +0000 (17:52 +0400)]
LU-6158 mdt: always shrink_capsule in getxattr_all

When mdt_getxattr_one returns error, capsule should be
shrunk to zero before exit in mdt_getxattr_all.

Change-Id: I060fd74177b5d7647581bda9cdb83937ab6a74a8
Signed-off-by: Sergey Cheremencev <sergey.cheremencev@seagate.com>
Signed-off-by: Alexander Zarochentsev <alexander.zarochentsev@seagate.com>
Xyratex-bug-id: MRP-2340
Reviewed-on: http://review.whamcloud.com/13524
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Lai Siyao <lai.siyao@intel.com>
Reviewed-by: Niu Yawei <yawei.niu@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-4647 tests: clean up sanity-sec code style issues 69/14769/6
Andreas Dilger [Mon, 11 May 2015 23:54:26 +0000 (17:54 -0600)]
LU-4647 tests: clean up sanity-sec code style issues

Minor cleanups in sanity-sec coding style seen during code review:
- fix indentation to use tabs
- don't continue strings with open quotes (adds indent to string)
- remove unnecessary linefeed escapes
- replace subshells with backquotes `...` to use $(...)

Remove no-op test_3(), as it is superceded by nodemaps.

Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Change-Id: If96e3ddee723747987ca5309e982e36af202fb26
Reviewed-on: http://review.whamcloud.com/14769
Reviewed-by: Nathaniel Clark <nathaniel.l.clark@intel.com>
Tested-by: Jenkins
Reviewed-by: James Nunez <james.a.nunez@intel.com>
4 years agoLU-4340 tests: Correct conf-sanity test 69 66/15966/11
James Nunez [Wed, 12 Aug 2015 17:43:47 +0000 (11:43 -0600)]
LU-4340 tests: Correct conf-sanity test 69

conf-sanity test 69 can fail due to creating more files than
available inodes on the first OST. We need to create the same number
of files, but in small numbers and remove them after creation.
Removing the newly created files will help in small OST environments
like the conf-sanity environment. If the LAST_ID is already greater
than 5 * OST_MAX_PRECREATE, just perform the OST replacement.

Test-Parameters: envdefinitions=SLOW=yes testlist=conf-sanity

Signed-off-by: James Nunez <james.a.nunez@intel.com>
Change-Id: I565b7d81c1817e4ee14f85314990b85ba8c844f1
Reviewed-on: http://review.whamcloud.com/15966
Tested-by: Jenkins
Reviewed-by: Ashish Purkar <ashish.purkar@seagate.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Jian Yu <jian.yu@intel.com>
4 years agoLU-6873 lod: duplicate mutex unlock 67/16067/2
wang di [Sat, 22 Aug 2015 21:14:07 +0000 (14:14 -0700)]
LU-6873 lod: duplicate mutex unlock

Remove duplicate mutex unlock in lod_add_device().

Signed-off-by: wang di <di.wang@intel.com>
Change-Id: Ibe73bf39a18ef96ecab10605d479e7b6ed97b397
Reviewed-on: http://review.whamcloud.com/16067
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Jenkins
Reviewed-by: Fan Yong <fan.yong@intel.com>
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
4 years agoLU-6210 lnet: Use C99 initializers for struct netstrfns 88/15088/13
James Simmons [Mon, 24 Aug 2015 14:59:29 +0000 (10:59 -0400)]
LU-6210 lnet: Use C99 initializers for struct netstrfns

Update struct netstrfns to use C99 initializers.

Remove old LND types from the netstrfns table, as they are
long obsolete and shouldn't be needed even for interop anymore.

Signed-off-by: James Simmons <uja.ornl@yahoo.com>
Change-Id: I22cd2d770e0872de343af249d13bf0f56f8a4a7d
Reviewed-on: http://review.whamcloud.com/15088
Tested-by: Jenkins
Reviewed-by: frank zago <fzago@cray.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
4 years agoLU-6970 llog: free thandle if declare failed 51/15951/2
Hongchao Zhang [Tue, 19 May 2015 20:38:24 +0000 (04:38 +0800)]
LU-6970 llog: free thandle if declare failed

in llog_osd_put_cat_list, the "thandle" should be cleaned up
if the following "declare" operation failed.

Change-Id: I0befba0068cb91fe685502f1e833c2fb6d6477bd
Signed-off-by: Hongchao Zhang <hongchao.zhang@intel.com>
Reviewed-on: http://review.whamcloud.com/15951
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Niu Yawei <yawei.niu@intel.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-3534 tests: a few tests cases for async update. 63/15163/14
wang di [Fri, 31 Jul 2015 11:55:19 +0000 (04:55 -0700)]
LU-3534 tests: a few tests cases for async update.

1 Add update migrate test case in conf-sanity.sh 32c.
2. add replay-dual.sh 26 to failover during tar and dbench.

Signed-off-by: wang di <di.wang@intel.com>
Change-Id: I1431bfe8d076a16802d9bba7ca3a7b9d47745f5c
Reviewed-on: http://review.whamcloud.com/15163
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Jian Yu <jian.yu@intel.com>
Reviewed-by: Lai Siyao <lai.siyao@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6880 update: after reply move dtrq to finish list 82/15682/8
wang di [Mon, 20 Jul 2015 17:36:52 +0000 (10:36 -0700)]
LU-6880 update: after reply move dtrq to finish list

update replay request (dtrq) will be moved to a replay
finish list after update replay is finished, so if
client send the replay request with the same transno,
it can check if the request has been redone by update
replay.

And same as normal replay, update replay should also
update obd_next_recovery_transno.

Add 70c replay single test cases to verify this.

Signed-off-by: wang di <di.wang@intel.com>
Change-Id: I2fae2a6f8264f55d069997e23a50e71b6a9f39db
Reviewed-on: http://review.whamcloud.com/15682
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Lai Siyao <lai.siyao@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6840 target: update reply data after update replay 76/15576/13
wang di [Mon, 20 Jul 2015 17:45:58 +0000 (10:45 -0700)]
LU-6840 target: update reply data after update replay

Set correct value to tgt_session_info, so tgt_txn_stop_cb()->
tgt_last_rcvd_update() can be called during update replay, and
the reply and and last_rcvd can be updated during update
replay.

Signed-off-by: wang di <di.wang@intel.com>
Change-Id: I32e5b2a7d30aecfb1a20b8d31a0054a3c28ccd50
Reviewed-on: http://review.whamcloud.com/15576
Tested-by: Jenkins
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Lai Siyao <lai.siyao@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6947 ptlrpc: Remove stray comment in ptlrpc_start_pinger 38/15838/2
Oleg Drokin [Tue, 4 Aug 2015 01:05:17 +0000 (21:05 -0400)]
LU-6947 ptlrpc: Remove stray comment in ptlrpc_start_pinger

The comment references cfs_daemonize times when daemonize took
process clone flags. There's no such thing anymore, so
let's drop the comment to not to cause any additional confusion.

Change-Id: I9398f97f604cb70486f6a9b3f9d80360a66c1555
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Reviewed-on: http://review.whamcloud.com/15838
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: frank zago <fzago@cray.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
4 years agoLU-6356 ptlrpc: do not sleep if encpool reached max capacity 70/15070/4
Sebastien Buisson [Fri, 29 May 2015 13:20:41 +0000 (15:20 +0200)]
LU-6356 ptlrpc: do not sleep if encpool reached max capacity

When using krb5p Kerberos flavor, RPCs are encrypted just before being
sent. This encryption requires allocating memory in the encoding pool.
The current implementation in sptlrpc_enc_pool_get_pages() is
deadlock-prone. Indeed, if there is no more free pages in the pool,
all ptlrpcd threads can end up waiting in a queue, so there is no
thread available to process other requests. It means client is not
able to process replies from servers that yet contain last committed
transno useful to release memory allocated by previous requests,
including enc_pool pages.

To fix this, in sptlrpc_enc_pool_get_pages(), do not make ptlrpcd
threads wait in queue if encoding pool has already reached its maximum
capacity. Instead, return -ENOMEM. If functions calling ptl_send_rpc()
get -ENOMEM, then put back request in queue by moving it back to
RQ_PHASE_NEW phase.
As an optimization, do not call ptl_send_rpc() again for requests that
already failed to allocate in the enc_pool, as long as there is not
enough memory in the enc_pool to satisfy theirs needs.

In /proc/fs/lustre/sptlrpc/encrypt_page_pools, add a new 'out of mem'
stat to track how many requests fail to allocate memory in the
enc_pool.

Signed-off-by: Sebastien Buisson <sebastien.buisson@bull.net>
Change-Id: Ie4217bb15c8514d28d360e50a9be7716b52f5147
Reviewed-on: http://review.whamcloud.com/15070
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6400 osd: initialize variable before use 08/16008/4
Yang Sheng [Tue, 25 Aug 2015 08:35:36 +0000 (16:35 +0800)]
LU-6400 osd: initialize variable before use

ldisk_bread use a pointer return error value. But not
initialized it. So maybe return a random value even in
normal case.

Signed-off-by: Yang Sheng <yang.sheng@intel.com>
Change-Id: I2ab424b285003c85b63dbea0b787b606fc368245
Reviewed-on: http://review.whamcloud.com/16008
Reviewed-by: Bobi Jam <bobijam@hotmail.com>
Tested-by: Jenkins
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-7028 tgt: initialize spin lock in tgt_init() 45/16045/2
Ashish Purkar [Thu, 20 Aug 2015 20:17:24 +0000 (05:17 +0900)]
LU-7028 tgt: initialize spin lock in tgt_init()

The spin lock lut_client_bitmap_lock was not initialized in
tgt_init().

Signed-off-by: Ashish Purkar <ashish.purkar@seagate.com>
Change-Id: I3118bc1c007d0f2b9919be17f4a429ed164f7c6c
Reviewed-on: http://review.whamcloud.com/16045
Tested-by: Jenkins
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Emoly Liu <emoly.liu@intel.com>
Reviewed-by: Grégoire Pichon <gregoire.pichon@bull.net>
Tested-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6742 mdd: remove legacy compatibility code 95/13395/9
Alex Zhuravlev [Wed, 14 Jan 2015 06:30:14 +0000 (09:30 +0300)]
LU-6742 mdd: remove legacy compatibility code

that specific code was needed to upgrade from Orion-formatted
filesystem.

Change-Id: I2b01244a8d706f1acd6b32bcf69ffb2f0e498cd8
Signed-off-by: Alex Zhuravlev <alexey.zhuravlev@intel.com>
Reviewed-on: http://review.whamcloud.com/13395
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Mike Pershin <mike.pershin@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
4 years agoLU-5623 osd-ldiskfs: fix typo in lost+found repair item 25/16025/2
Andreas Dilger [Wed, 19 Aug 2015 03:00:40 +0000 (21:00 -0600)]
LU-5623 osd-ldiskfs: fix typo in lost+found repair item

Fix a typo in lr_repaired (was lr_reparied) and fix the test script
that checks it to allow both spellings for interop testing with
older servers.

Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Change-Id: If1c4c6246143f874a0d2de6434f5c89c67469053
Reviewed-on: http://review.whamcloud.com/16025
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Jian Yu <jian.yu@intel.com>
Reviewed-by: Fan Yong <fan.yong@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6990 lproc: set parameter nosquash_nids correctly 85/15985/2
Emoly Liu [Thu, 13 Aug 2015 12:23:59 +0000 (20:23 +0800)]
LU-6990 lproc: set parameter nosquash_nids correctly

Fix the code to set parameter nosquash_nids correctly by echo command,
no matter with "-n" option or not.

Signed-off-by: Emoly Liu <emoly.liu@intel.com>
Change-Id: Ia4bf1ce32d76d4acd90aab5b799780e5e256cc29
Reviewed-on: http://review.whamcloud.com/15985
Reviewed-by: Bobi Jam <bobijam@hotmail.com>
Reviewed-by: Jian Yu <jian.yu@intel.com>
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6962 lnet: remove old unsupported OFEDs checks 64/15864/4
Dmitry Eremin [Wed, 5 Aug 2015 15:41:50 +0000 (18:41 +0300)]
LU-6962 lnet: remove old unsupported OFEDs checks

remove checks that are always true for supported OFEDs.

Signed-off-by: Dmitry Eremin <dmitry.eremin@intel.com>
Change-Id: I904dca06f3136334bb317de1288852e6ac4f92c7
Reviewed-on: http://review.whamcloud.com/15864
Tested-by: Jenkins
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Chris Horn <hornc@cray.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6913 test: fix conf-sanity test_30b defect 72/15772/4
Elena Gryaznova [Tue, 28 Jul 2015 13:56:27 +0000 (16:56 +0300)]
LU-6913 test: fix conf-sanity test_30b defect

test_30b does not take into account a failover nid set
before test started, which leads test always fails
on the setup with $ost1failover_HOST != $ost1_HOST;
Patch fixes this defect.

Signed-off-by: Elena Gryaznova <elena.gryaznova@seagate.com>
Seagate-bug-id: MRP-2749
Reviewed-by: Andriy Skulysh <andriy.skulysh@seagate.com>
Change-Id: I2f7f163b84e4203ffa0ab12bc18b9d7ac535ec37
Reviewed-on: http://review.whamcloud.com/15772
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Jian Yu <jian.yu@intel.com>
Reviewed-by: Emoly Liu <emoly.liu@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6875 update: set st to NULL in error handler 91/15691/8
wang di [Tue, 21 Jul 2015 13:27:24 +0000 (06:27 -0700)]
LU-6875 update: set st to NULL in error handler

In thandle_get_sub_by_dt, if create sub thandle fails,
it should reset st to NULL, otherwise st, whose value
is ERR_PTR(rc), might be freeed incorrectly in the
following error handler path.

Signed-off-by: wang di <di.wang@intel.com>
Change-Id: I7262593fa5aa6bc3f0ed418aaa5637e84077088b
Reviewed-on: http://review.whamcloud.com/15691
Tested-by: Jenkins
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-5319 tests: testcases for multiple modify RPCs feature 61/14861/17
Gregoire Pichon [Thu, 30 Jul 2015 06:27:34 +0000 (23:27 -0700)]
LU-5319 tests: testcases for multiple modify RPCs feature

This patch creates new testcases in the Auster test suite to
test the support of multiple modify RPCs in flight feature.

Two new OBD_FAIL codes are added to allow several failure occurences
of the reint requests or replies. This is needed because the current
fail checks impose the OBD_FAIL_ONCE flag.

Added testcases are :
- sanity         245
- conf-sanity    90a 90b 90c 90d
- replay-single  102a 102b 102c 102d

This patch also removes replay-single tests 53a and 53b
from the ALWAYS_EXCEPT list.

Signed-off-by: Gregoire Pichon <gregoire.pichon@bull.net>
Change-Id: I3cd233d5ef67a696e830c77b154dcc01520bb3d2
Reviewed-on: http://review.whamcloud.com/14861
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Jian Yu <jian.yu@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
4 years agoLU-6480 o2iblnd: leak cmid in kiblnd_dev_need_failover 03/14603/2
Liang Zhen [Mon, 27 Apr 2015 02:49:41 +0000 (10:49 +0800)]
LU-6480 o2iblnd: leak cmid in kiblnd_dev_need_failover

cmid created by kiblnd_dev_need_failover should always be destroyed,
however it is not the case in current implementation and we will leak
cmid when this function detected a device failover.

Signed-off-by: Liang Zhen <liang.zhen@intel.com>
Change-Id: Icc567593f50fd557d5a7d1642a65d4fe49e8b4c2
Reviewed-on: http://review.whamcloud.com/14603
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Isaac Huang <he.huang@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6213 llite: add LL_IOC_FUTIMES_3 65/13665/5
John L. Hammond [Thu, 5 Feb 2015 23:35:08 +0000 (17:35 -0600)]
LU-6213 llite: add LL_IOC_FUTIMES_3

Add a new regular file ioctl LL_IOC_FUTIMES_3 similar to futimes() but
which allows setting of all three inode timestamps. Use this ioctl
during HSM restore to ensure that the volatile file has the same
timestamps as the file to be restored. Strengthen sanity-hsm test_24a
to check that archive, release, and restore do not change a file's
ctime. Add sanity-hsm test_24e to check that tar will succeed when it
encounters a HSM released file.

Signed-off-by: John L. Hammond <john.hammond@intel.com>
Change-Id: I98a4913048f902892fdafc514547bbe4d51523d7
Reviewed-on: http://review.whamcloud.com/13665
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Jinshan Xiong <jinshan.xiong@intel.com>
Reviewed-by: frank zago <fzago@cray.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-5149 utils: Create debug upcall to dump ldlm namespaces 17/10617/6
Ryan Haasken [Thu, 5 Jun 2014 21:51:59 +0000 (16:51 -0500)]
LU-5149 utils: Create debug upcall to dump ldlm namespaces

Created a script to be used as the debug_log_upcall which will dump
ldlm namespace information in raw/binary format and append it to the
given debug log file.

Signed-off-by: Ryan Haasken <haasken@cray.com>
Change-Id: I69f08f1b9563024c962f0213fd47a95b33b7da23
Reviewed-on: http://review.whamcloud.com/10617
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Chris Horn <hornc@cray.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6600 obdclass: race lustre_profile_list 96/14896/7
Hiroya Nozaki [Thu, 20 Aug 2015 05:37:23 +0000 (14:37 +0900)]
LU-6600 obdclass: race lustre_profile_list

running multiple mounts at the same time results in
lustre_profile_list corruption when adding a new profile.

This patch adds a new spin_lock to protect the list and
avoid the bug

Signed-off-by: Hiroya Nozaki <nozaki.hiroya@jp.fujitsu.com>
Change-Id: I0d6ef47e9fa3dd9de8bd33d426112242136a9e26
Reviewed-on: http://review.whamcloud.com/14896
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Jian Yu <jian.yu@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6819 update: update transno of replay properly 94/15594/9
wang di [Mon, 20 Jul 2015 18:19:33 +0000 (11:19 -0700)]
LU-6819 update: update transno of replay properly

Do not update master transno when the update request
in the replay list, otherwise it will affect the order
of the replay list.

Signed-off-by: wang di <di.wang@intel.com>
Change-Id: I73709be714724c36f34ff64f8eabf4c2bec1112d
Reviewed-on: http://review.whamcloud.com/15594
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Lai Siyao <lai.siyao@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-589 auster: Export 'CONFIG' environment variable. 51/2051/4
Chris Horn [Wed, 16 Apr 2014 14:39:01 +0000 (09:39 -0500)]
LU-589 auster: Export 'CONFIG' environment variable.

The 'CONFIG' variable defines the accsm configuration file. This
variable needs to be exported so that test-suite scripts use the
appropriate accsm configuration.

Change-Id: Ia0fdb4014d6eeefc3e08dced3d843427756c8587
Signed-off-by: Chris Horn <hornc@cray.com>
Reviewed-on: http://review.whamcloud.com/2051
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Jian Yu <jian.yu@intel.com>
4 years agoLU-4499 nrs: adjust the order of REQ NRS initilization 43/15943/5
Jinshan Xiong [Tue, 11 Aug 2015 02:14:21 +0000 (19:14 -0700)]
LU-4499 nrs: adjust the order of REQ NRS initilization

NRS block of ptlrpc_request must be initialized before it is added
into exp_{hp,reg}_list; otherwise ptlrpc_nrs_req_hp_move() may access
uninitialized NRS block. Code cleanup.

Signed-off-by: Jinshan Xiong <jinshan.xiong@intel.com>
Change-Id: Ide1d7edfa5e09bf498baaa60023dbccf3fb152dc
Reviewed-on: http://review.whamcloud.com/15943
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: wangdi <di.wang@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6757 ldiskfs: acquire i_mutex lock for ext4_update_i_disksize 12/16012/3
Jian Yu [Mon, 24 Aug 2015 06:03:02 +0000 (23:03 -0700)]
LU-6757 ldiskfs: acquire i_mutex lock for ext4_update_i_disksize

For RHEL 7.1 kernel version 3.10.0, i_mutex lock needs to be acquired
before calling ext4_update_i_disksize() to avoid races with truncate.

i_size_write() also needs locking around it (normally i_mutex), otherwise
on 32bit/SMP an update of i_size_seqcount can be lost, resulting in
subsequent i_size_read() calls spinning forever.

For large EA support, ext4_xattr_check_names() will return -EIO. This
patch fixes that by checking whether the large EA value is saved in an
external EA inode or not.

Signed-off-by: Jian Yu <jian.yu@intel.com>
Change-Id: I095246cc1f7457defe87ca246edf98bbc051bc29
Reviewed-on: http://review.whamcloud.com/16012
Tested-by: Jenkins
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Yang Sheng <yang.sheng@intel.com>
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
4 years agoLU-6894 kernel: new kernel RHEL6.7 [2.6.32-573.3.1.el6] 01/15701/11
Bob Glossman [Wed, 22 Jul 2015 18:45:13 +0000 (11:45 -0700)]
LU-6894 kernel: new kernel RHEL6.7 [2.6.32-573.3.1.el6]

Add target and config files for new kernel in RHEL 6.7
Revise lbuild to add RHEL 6.7
Add new ldiskfs patch series for RHEL 6.7,
similar to 6.6 but without the
ext4-drop-inode-from-orphan-list-if-ext4_delete_inode-fails.patch
That change is now already present in the 6.7 version of ext4.

Test-Parameters: mdsdistro=el6.7 ossdistro=el6.7 \
  clientdistro=el6.7 mdsfilesystemtype=ldiskfs \
  mdtfilesystemtype=ldiskfs ostfilesystemtype=ldiskfs \
  testgroup=review-ldiskfs

Signed-off-by: Bob Glossman <bob.glossman@intel.com>
Change-Id: I09496b03b030fc678422a8d027ee185b8a660611
Reviewed-on: http://review.whamcloud.com/15701
Tested-by: Jenkins
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Yang Sheng <yang.sheng@intel.com>
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-7033 utils: Add missing calls to wirecheck 59/16059/2
Henri Doreau [Mon, 24 Aug 2015 09:08:12 +0000 (11:08 +0200)]
LU-7033 utils: Add missing calls to wirecheck

The following functions were defined but never called:
    check_update_params
    check_update_op
    check_update_ops
    check_update_records
    check_llog_update_record

Change-Id: Ic1d12f5f422a01cf886432348d5c6c80ab19d1a5
Signed-off-by: Henri Doreau <henri.doreau@cea.fr>
Reviewed-on: http://review.whamcloud.com/16059
Tested-by: Jenkins
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: wangdi <di.wang@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-7025 lfsck: Invalid return value assignment 42/16042/2
Fan Yong [Wed, 15 Jul 2015 03:24:47 +0000 (11:24 +0800)]
LU-7025 lfsck: Invalid return value assignment

In lfsck_layout_scan_stripes(), the following code section:
                if (lso == NULL) {
                        struct lu_attr *attr = &info->lti_la;

                        rc = dt_attr_get(env, parent, attr);
                        if (rc != 0) {
                                rc = PTR_ERR(lso);
                                goto next;
                        }
                        ...
                }
When dt_attr_get() returns failure, we should NOT assign the
"rc" as "PTR_ERR(lso)", instead, just use the current "rc".

Signed-off-by: Fan Yong <fan.yong@intel.com>
Change-Id: I8237e1f79588b54c73398f20bd833e81787bf4a6
Reviewed-on: http://review.whamcloud.com/16042
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Lai Siyao <lai.siyao@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6997 mdt: enqueue nonblocking locks in migration 70/15970/4
wang di [Wed, 12 Aug 2015 06:37:20 +0000 (23:37 -0700)]
LU-6997 mdt: enqueue nonblocking locks in migration

During migration, it needs to lock all of parent objects
in the linkea of the migrating object, so these parent
objects can change the name entry after the migration.

But it is not easy to order these objects(in linkEA) in
parent-child order. To avoid deadlock, let's use
mdt_object_lock_try(), which will enqueue nonblocking
locks, i.e. once there are conflicting locks, the
migration will release all of locks then return -EBUSY.

Signed-off-by: wang di <di.wang@intel.com>
Change-Id: Id657cfd9d9caefaa7c699d5a5ca90604cf707ac0
Reviewed-on: http://review.whamcloud.com/15970
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6981 target: update obd_last_committed 71/15971/3
wang di [Tue, 11 Aug 2015 11:10:27 +0000 (04:10 -0700)]
LU-6981 target: update obd_last_committed

In tgt_reply_data_init(), it should update
last_committed after analyzing those reply_data,
similar as tgt_server_data_init(), otherwise
obd_last_committed might be smaller than the real
committed transno, and then cause recovery_thread
stuck in check_for_next_transno(), which rely on
the correct last committed transno.

Signed-off-by: wang di <di.wang@intel.com>
Change-Id: Id036c41028c5bc5bf45f6ad300756e0653929bb3
Reviewed-on: http://review.whamcloud.com/15971
Tested-by: Jenkins
Reviewed-by: Mike Pershin <mike.pershin@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Grégoire Pichon <gregoire.pichon@bull.net>
Reviewed-by: Lai Siyao <lai.siyao@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6977 lod: do_index_try should be called first 72/15972/3
wang di [Tue, 11 Aug 2015 11:19:43 +0000 (04:19 -0700)]
LU-6977 lod: do_index_try should be called first

In lod_striped_it_next do_index_try should be called first
to initialize do_index_ops, then checking do_index_ops.

Signed-off-by: wang di <di.wang@intel.com>
Change-Id: I477fb3c9ccd65c4e7721d78a3746f64acf8733ce
Reviewed-on: http://review.whamcloud.com/15972
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Alex Zhuravlev <alexey.zhuravlev@intel.com>
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6475 mdt: race between open and migrate 97/14497/19
wang di [Sun, 10 May 2015 23:40:46 +0000 (16:40 -0700)]
LU-6475 mdt: race between open and migrate

During intent open, if it founds the parent has been
migrated to another MDT, it should retry the open
request with the new object, so it needs to keep the
old object in the orphan list, which will be cleanup
during next recovery. Note: if the client still using
the old FID after next recovery, it will return -ENOENT
for the application.

Reset parent FID on OST object after migration, which
also make sanity-lfsck.sh 15c obsolete, because that
test suppose to fix the parent FID of the OST object
after migration.

And also enqueue the lease lock of the migrating file,
then compare the lease before migration to make sure
no other clients open the file at the same time.

Add sanityn.sh 80b to test race between open/stat and
migration.

Signed-off-by: wang di <di.wang@intel.com>
Change-Id: Iad3e5006079e9f72b338680e17448c39c6d1af98
Reviewed-on: http://review.whamcloud.com/14497
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-7029 osc: fix debug log message formatting 46/16046/2
Ashish Purkar [Thu, 20 Aug 2015 21:12:16 +0000 (06:12 +0900)]
LU-7029 osc: fix debug log message formatting

Corrected newline specifier in debug log message.

Signed-off-by: Ashish Purkar <ashish.purkar@seagate.com>
Change-Id: Id7928648bbe6d8e00d36a9f05a90aaf732b0595a
Reviewed-on: http://review.whamcloud.com/16046
Tested-by: Jenkins
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-2524 test: Clean up replay-ost-single test suite 85/14685/7
James Nunez [Tue, 5 May 2015 22:14:34 +0000 (16:14 -0600)]
LU-2524 test: Clean up replay-ost-single test suite

Miscellaneous cleanup of replay-ost-single including:
Replace `lfs setstripe` with $SETSTRIPE
Replace `lfs getstripe` with $GETSTRIPE
Replaced beginning of line space indent with tabs
Replaced ‘return’ with a call to ‘error’
Added call to `error` with error messages for a variety of common
routines ,like mkdir, or for functions that return a value.
Replace `…` with $(...)
Removed linefeed escape after |, ||, & and && operators.

Signed-off-by: James Nunez <james.a.nunez@intel.com>
Change-Id: I92bebb5db0b42d8e0fd23aa6c783d546a8fd6507
Reviewed-on: http://review.whamcloud.com/14685
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Jian Yu <jian.yu@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
4 years agoLU-4932 doc: update design doc for LFSCK 40/10040/7
Fan Yong [Tue, 23 Sep 2014 23:10:51 +0000 (07:10 +0800)]
LU-4932 doc: update design doc for LFSCK

Update the document for MDT-MDT consistency verification.

Signed-off-by: Fan Yong <fan.yong@intel.com>
Signed-off-by: Richard Henwood <richard.henwood@intel.com>
Change-Id: Idf36e9b9d1189ddf4062d96bcc647590d24e948f
Reviewed-on: http://review.whamcloud.com/10040
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
4 years agoLU-6846 llog: combine cancel rec and destroy 30/15730/7
wang di [Sat, 25 Jul 2015 16:21:46 +0000 (09:21 -0700)]
LU-6846 llog: combine cancel rec and destroy

Merge cancel llog record and llog object destroy in
a single transaction. Otherwise it will cause the
race between cancel record and llog object destroy,
especally when deleting remote record, i.e. if delete
record RPC arrives after destroy, then delete record
will not find the object, cause LBUG.

Signed-off-by: wang di <di.wang@intel.com>
Change-Id: I33773eeb859fffa871ce01689c5bf1b4196a6658
Reviewed-on: http://review.whamcloud.com/15730
Tested-by: Jenkins
Reviewed-by: Mike Pershin <mike.pershin@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6215 llite: handle backing_dev_info removal 82/15182/4
James Simmons [Tue, 11 Aug 2015 15:33:17 +0000 (11:33 -0400)]
LU-6215 llite: handle backing_dev_info removal

For kernels before 3.20 the struct address_space contained
a pointer to a struct backing_dev_info. This backing_dev_info
had to setup with the backing_dev_info that was contained
in the super block. Now in newer kernels that backing_dev_info
pointer has been removed from the address_space. If you want
to use the backing_dev_info you need to access it from the
super block data structure directly. Lustre upstream removed
all the backing_dev_info setup for the inode i_mapping which
is no longer needed. This patch makes Lustre handle the bdi
inode backing_dev_info only for per 3.20 kernels now. This
change was due to:

Linux-commit: 6bec0035286119eefc32a5b1102127e6a4032cb2

Another change in the 3.20 kernels is the removal of the mmap
functionaly for the backing device. This was removed in with

Linux-commit: b4caecd48005fbed3949dde6c1cb233142fd69e9

With this change the flag BDI_CAP_MAP_COPY was removed.

Signed-off-by: James Simmons <uja.ornl@yahoo.com>
Change-Id: Ic2cd9227c99e3f66001ea9470cdc6bfdbf4f1c2c
Reviewed-on: http://review.whamcloud.com/15182
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6119 test: Add testing for Lustre exported via Samba 02/13402/8
Elena Gryaznova [Thu, 23 Jul 2015 17:46:11 +0000 (20:46 +0300)]
LU-6119 test: Add testing for Lustre exported via Samba

Create a parallel-scale-cifs.sh test which exports
Lustre via Samba and runs concurrent load compilebench, dbench,
fsx, iozone on Samba clients.

The test assumes that Samba server and clients have necessary
packages installed.

Signed-off-by: Elena Gryaznova <elena.gryaznova@seagate.com>
Xyratex-bug-id: MRP-1374
Reviewed-by: Vladimir Saveliev <vladimir.saveliev@seagate.com>
Reviewed-by: Vitaly Fertman <vitaly.fertman@seagate.com>
Change-Id: Iace3b786bd34e42198a2ffdb35c436595fe2b8a5
Reviewed-on: http://review.whamcloud.com/13402
Reviewed-by: Jian Yu <jian.yu@intel.com>
Tested-by: Jian Yu <jian.yu@intel.com>
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Emoly Liu <emoly.liu@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6727 osd: auto locate BH_DXLock bit 61/15961/8
Yang Sheng [Wed, 12 Aug 2015 08:58:31 +0000 (16:58 +0800)]
LU-6727 osd: auto locate BH_DXLock bit

BH_DXLock use a fix code bit before. It may occupied by other one
silently. From lustre view, jdb2 & ext4 also use this defines, So
we use ext4's define to determine last value.

Signed-off-by: Yang Sheng <yang.sheng@intel.com>
Change-Id: I0fde8b461afec6acafe2708211761c3c60c529d7
Reviewed-on: http://review.whamcloud.com/15961
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Bobi Jam <bobijam@hotmail.com>
Reviewed-by: Alex Zhuravlev <alexey.zhuravlev@intel.com>
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
4 years agoLU-6911 ldiskfs: mds crash kernel at fs/inode.c:1358 68/15768/4
Bobi Jam [Tue, 28 Jul 2015 03:36:34 +0000 (11:36 +0800)]
LU-6911 ldiskfs: mds crash kernel at fs/inode.c:1358

A glitch exists in LU-4648 patch (commit
ed69a331b1e502643fe074c121f9a8b9d041fc49) which does not put ea
inodes to orphan list if no external ea is used.

Signed-off-by: Bobi Jam <bobijam.xu@intel.com>
Change-Id: I1c28b989d73d06317e4064b739d69fa9453c5deb
Reviewed-on: http://review.whamcloud.com/15768
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Yang Sheng <yang.sheng@intel.com>
Reviewed-by: Fan Yong <fan.yong@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6234 util: check fsname and pool name 42/13742/15
Bobi Jam [Thu, 12 Feb 2015 03:58:26 +0000 (11:58 +0800)]
LU-6234 util: check fsname and pool name

The pool name length check should not include its fsname. This patch
get rid of the possibly added fsname in the pool name argument.

Check lustre filesystem name (fsname) in mkfs.lustre, it can only
contains alphabetic, digital char and '_'/'-'.

Check pool name in lctl/lfs, its character also abides by the
constraint of the fsname.

Add test cases to check the pool names for length, with and without
a filesystem name prefix, and with invalid names.

Also fix pool_add in the test-framework so that it greps for the
poolname plus the filesystem name, so it doesn't match more lines than
necessary.

Signed-off-by: Bobi Jam <bobijam.xu@intel.com>
Signed-off-by: frank zago <fzago@cray.com>
Change-Id: I4f542e1bc7b3ea97b35ec60e51aa971e73da91eb
Reviewed-on: http://review.whamcloud.com/13742
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6714 llog: test plain llog more throughly 35/15835/6
Mikhail Pershin [Wed, 24 Jun 2015 06:49:38 +0000 (09:49 +0300)]
LU-6714 llog: test plain llog more throughly

Modify llog test 3 to check more aspects of its
functionality:
- search the record by index
- check all records are processed
- check modification in-place
- check that processing is seeing concurrently added
  new records
- check the correctness of lgh_cur_offset and lgh_cur_idx

Signed-off-by: Mikhail Pershin <mike.pershin@intel.com>
Change-Id: I11a7c6474a7420393987a964e9112d61263bdc81
Reviewed-on: http://review.whamcloud.com/15835
Tested-by: Jenkins
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6817 llite: lower message level for ll_setattr_raw() 41/15541/4
Bobi Jam [Thu, 9 Jul 2015 09:05:50 +0000 (17:05 +0800)]
LU-6817 llite: lower message level for ll_setattr_raw()

truncate and write can happen at the same time, so that a file can
be set modified even though the file is not restored from released
state, and ll_hsm_state_set() is not applicable for the file, and
it will return error in this case, we'd lower the error message level
in this case.

Signed-off-by: Bobi Jam <bobijam.xu@intel.com>
Change-Id: Iff5bc0a6cec990e4e9f6f8f4ef0faacc229b828b
Reviewed-on: http://review.whamcloud.com/15541
Tested-by: Jenkins
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6516 ofd: fix double spin_unlock 75/14875/3
Ulka Vaze [Thu, 6 Aug 2015 01:02:09 +0000 (18:02 -0700)]
LU-6516 ofd: fix double spin_unlock

In ofd_inconsistency_verification_main(), spin_unlock() would
be performed twice if OBD_ALLOC_PTR(lr) failed. This patch fixes
this by adding a new label to gain lock again before unlocking.

Signed-off-by: Ulka Vaze <ulka.vaze@yahoo.in>
Signed-off-by: Dmitry Eremin <dmitry.eremin@intel.com>
Change-Id: If9838d75b9bf6936b99c9d92e8ff0c9b36d783c3
Reviewed-on: http://review.whamcloud.com/14875
Tested-by: Jenkins
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6385 tests: Sync OSTs between tests in obdfilter-survey 43/14143/2
Nathaniel Clark [Mon, 23 Mar 2015 16:44:22 +0000 (12:44 -0400)]
LU-6385 tests: Sync OSTs between tests in obdfilter-survey

osd-ldiskfs and osd-zfs operate differently with regards to writeback
cache.  This adds a force sync between test runs so that a test list
of "write read" will have all writes finished before reads starts for
both ldiskfs and zfs.

Signed-off-by: Nathaniel Clark <nathaniel.l.clark@intel.com>
Change-Id: I3414a595220d9eb65145f8246ed5e243c112b866
Reviewed-on: http://review.whamcloud.com/14143
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Alex Zhuravlev <alexey.zhuravlev@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6305 osd-ldiskfs: buffer head leak in osd 09/13909/6
Andriy Skulysh [Wed, 15 Jul 2015 08:15:37 +0000 (11:15 +0300)]
LU-6305 osd-ldiskfs: buffer head leak in osd

iam_new_leaf() should release new_leaf
in case of an error

Change-Id: I48d358cb823d83b5412a1e4b88ab3ea13a0bee35
Xyratex-bug-id: MRP-2338
Signed-off-by: Andriy Skulysh <andriy.skulysh@seagate.com>
Reviewed-by: Alexey Lyashkov <alexey.lyashkov@seagate.com>
Reviewed-by: Andrew Perepechko <andrew.perepechko@seagate.com>
Reviewed-on: http://review.whamcloud.com/13909
Tested-by: Jenkins
Reviewed-by: Alex Zhuravlev <alexey.zhuravlev@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6245 libcfs: remove atomic cpt allocations 13/15913/4
James Simmons [Wed, 12 Aug 2015 14:29:03 +0000 (10:29 -0400)]
LU-6245 libcfs: remove atomic cpt allocations

libcfs contains functions to perform atomic memory
operations. These functions have never been used
so remove them.

Change-Id: I48dff483c4560700acbddff6268735837ed12b79
Signed-off-by: frank zago <fzago@cray.com>
Signed-off-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-on: http://review.whamcloud.com/15913
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6245 libcfs: remove err.h 09/15909/4
James Simmons [Wed, 12 Aug 2015 14:25:09 +0000 (10:25 -0400)]
LU-6245 libcfs: remove err.h

With the cleanup of userland with libcfs we no longer
need the special error handling macros.

Change-Id: I5a7a2e1df3beef548b74703b45052ce85166f3aa
Signed-off-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-on: http://review.whamcloud.com/15909
Reviewed-by: frank zago <fzago@cray.com>
Tested-by: Jenkins
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6245 libcfs: remove unused cfs_timer_done 17/13917/3
James Simmons [Mon, 10 Aug 2015 14:36:22 +0000 (10:36 -0400)]
LU-6245 libcfs: remove unused cfs_timer_done

Remove the cfs_timer_done function in the libcfs
kernel module since it is not used anywhere.

Signed-off-by: James Simmons <uja.ornl@yahoo.com>
Signed-off-by: frank zago <fzago@cray.com>
Change-Id: Ieb521b5b2ce4d3a66dfa0bafc3a866fc38fcd65f
Reviewed-on: http://review.whamcloud.com/13917
Tested-by: Jenkins
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-5108 osc: Performance tune for LRU 58/10458/18
Jinshan Xiong [Sat, 18 Jul 2015 13:10:09 +0000 (06:10 -0700)]
LU-5108 osc: Performance tune for LRU

Early launch page LRU work in osc_io_rw_iter_init();
Change the page LRU shrinking policy by OSC attributes;
Delete the contented lock osc_object::oo_seatbelt
Other tiny changes for LRU management

Signed-off-by: Jinshan Xiong <jinshan.xiong@intel.com>
Change-Id: I688c29a99a469ef74f929a0689596170c665b2ee
Reviewed-on: http://review.whamcloud.com/10458
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Bobi Jam <bobijam@hotmail.com>
Reviewed-by: Fan Yong <fan.yong@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-3031 ldlm: disconnect speedup 43/5843/31
Vitaly Fertman [Wed, 22 Jul 2015 14:52:03 +0000 (10:52 -0400)]
LU-3031 ldlm: disconnect speedup

disconnect takes too long time if there are many locks to cancel.
besides the amount of time spent on each lock cancel, there is a
resched() in cfs_hash_for_each_relax(), i.e. disconnect or eviction
may take unexpectedly long time.
- do not cancel locks on disconnect_export;
- export will be left in obd_unlinked_exports list pinned by live
  locks;
- new re-connects will created other non-conflicting exports;
- new locks will cancel obsolete locks on conflicts;
- once all the locks on the disconnected export will be cancelled,
  the export will be destroyed on the last ref put;
- do not cancel in small portions, cancel all together in just 1
  dedicated thread - use server side blocking thread for that;
- cancel blocked locks first so that waiting locks could proceed;
- take care about blocked waiting locks, so that they would get
  cancelled quickly too;
- do not remove lock from waiting list on AST error before moving
  it to elt_expired_locks list, because it removes it from export
  list too; otherwise this blocked lock will not be cancelled
  immediately on failed export;
- cancel lock instead of just destroy for failed export, to make
  full cleanup, i.e. remove it from export list.

also make the proper order of events on umount:
- disconnect export;
- cleanup namespace, to cancel all the locks before export barrier;
- exports barrier;
- lprocfs_free_per_client_stats (requires nid_exp_ref_count == 0);
- namespace_free_post is left in cleanup ensure will not get and
  segfault on an absent namespace.

Signed-off-by: Vitaly Fertman <vitaly_fertman@xyratex.com>
Change-Id: Ia39b09ce967237ed5078c8a71e760b1e103c6f55
Xyratex-bug-id: MRP-395 MRP-1366 MRP-1366
Reviewed-by: Andriy Skulysh <Andriy_Skulysh@xyratex.com>
Reviewed-by: Alexey Lyashkov <Alexey_Lyashkov@xyratex.com>
Tested-by: Elena Gryaznova <Elena_Gryaznova@xyratex.com>
Reviewed-on: http://review.whamcloud.com/5843
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6802 recovery: don't skip open replay on reconnect 71/15871/2
Niu Yawei [Thu, 6 Aug 2015 08:14:40 +0000 (04:14 -0400)]
LU-6802 recovery: don't skip open replay on reconnect

Once reconnect happened during replay, we'd continue the open
replay with the last failed replay, but not the next.

Signed-off-by: Niu Yawei <yawei.niu@intel.com>
Change-Id: I164c40db143ca860ab59f60582942614d5fb7925
Reviewed-on: http://review.whamcloud.com/15871
Tested-by: Jenkins
Reviewed-by: Jinshan Xiong <jinshan.xiong@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Hongchao Zhang <hongchao.zhang@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6929 libcfs: typo in cfs_hash_for_each_relax() 13/15813/3
Niu Yawei [Fri, 31 Jul 2015 02:06:37 +0000 (22:06 -0400)]
LU-6929 libcfs: typo in cfs_hash_for_each_relax()

In cfs_hash_for_each_relax(), rc != 0 means caller want to break
the iteration, so we should only continue the iteration when rc
is zero.

Signed-off-by: Niu Yawei <yawei.niu@intel.com>
Change-Id: I9666cd26ebe93627009bd03b7bbd341a65beaddf
Reviewed-on: http://review.whamcloud.com/15813
Reviewed-by: Bobi Jam <bobijam@hotmail.com>
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Lai Siyao <lai.siyao@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6122 lnet: Allocate the correct number of rtr buffers 19/13519/11
Amir Shehata [Fri, 23 Jan 2015 23:27:22 +0000 (15:27 -0800)]
LU-6122 lnet: Allocate the correct number of rtr buffers

This patch ensures that the correct number of router buffers are
allocated.  It keeps a count that keeps track of the number of
buffers allocated.  Another count keeps the number of buffers
requested. The number of buffers allocated is set when creating
new buffers and reduced when buffers are freed.

The number of requested buffer is set when the buffers are
allocated and is checked when credits are returned to determine
whether the buffer should be freed or kept.

In lnet_rtrpool_adjust_bufs() grab lnet_net_lock() before using
rbp_nbuffers to ensure that it doesn't change by
lnet_return_rx_credits_locked() during the process of allocating
new buffers.  All other access to rbp_nbuffers is already being
protected by lnet_net_lock().

This avoids the case where we allocate less than the desired
number of buffers.

Signed-off-by: Amir Shehata <amir.shehata@intel.com>
Change-Id: I96627cc8ba3d3d70a0bf581b21ccd3c9b2de327f
Reviewed-on: http://review.whamcloud.com/13519
Tested-by: Jenkins
Reviewed-by: Jinshan Xiong <jinshan.xiong@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Doug Oucharek <doug.s.oucharek@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6455 mdt: disable IMA support 28/14928/3
Hongchao Zhang [Thu, 23 Apr 2015 21:04:04 +0000 (05:04 +0800)]
LU-6455 mdt: disable IMA support

in IMA (Integrity Measurement Architecture), there are two xattr
"security.ima" and "security.evm" to protect the file to be modified
accidentally or maliciously, the two xattr are not compatible with
VBR, then disable it to workaround the problem currently and enable
it when the conditions are ready.

Change-Id: Ie3e30dcb0d4d605a17d301c6cda14818af40d7b0
Signed-off-by: Hongchao Zhang <hongchao.zhang@intel.com>
Reviewed-on: http://review.whamcloud.com/14928
Tested-by: Jenkins
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Mike Pershin <mike.pershin@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoNew tag 2.7.58 2.7.58 v2_7_58 v2_7_58_0
Oleg Drokin [Mon, 17 Aug 2015 23:21:37 +0000 (19:21 -0400)]
New tag 2.7.58

Change-Id: Ia373f99ab02b0ed713e7cc762782fd7ef2d6405d

4 years agoLU-6846 osd: reset do_body_ops after creation 95/15595/4
wang di [Tue, 21 Jul 2015 08:26:31 +0000 (01:26 -0700)]
LU-6846 osd: reset do_body_ops after creation

Reset the do_body_ops from osd_body_ops_new to
osd_body_ops after object creation succeeds.
Otherwise in OUT handler, if creation the llog object
and write records to the llog object are in the same
transaction(one updates handling process), the object
will not have create do_body_ops in write update.

Signed-off-by: wang di <di.wang@intel.com>
Change-Id: Id45f1a29572faadc381194f45a980eb58d193e93
Reviewed-on: http://review.whamcloud.com/15595
Tested-by: Jenkins
Reviewed-by: Alex Zhuravlev <alexey.zhuravlev@intel.com>
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6742 osd: remove legacy code 35/15335/7
Alex Zhuravlev [Thu, 18 Jun 2015 05:38:03 +0000 (08:38 +0300)]
LU-6742 osd: remove legacy code

osd_convert_root_to_new_seq() was introduced to convert
the filesystems created with pre-production Orion code.
we don't need this anymore.

Change-Id: Ib5657fc7a905bebacd4074878cc76365e1e3d8d9
Signed-off-by: Alex Zhuravlev <alexey.zhuravlev@intel.com>
Reviewed-on: http://review.whamcloud.com/15335
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Mike Pershin <mike.pershin@intel.com>
Reviewed-by: Nathaniel Clark <nathaniel.l.clark@intel.com>
4 years agoLU-7004 utils: defer conf_param deprecation 79/15979/2
Andreas Dilger [Thu, 13 Aug 2015 19:12:49 +0000 (13:12 -0600)]
LU-7004 utils: defer conf_param deprecation

Since there has been relatively little testing of "lctl set_param -P"
and the test scripts and documentation have not been converted from
using "lctl conf_param" yet, I'm deferring the conf_param deprecation
warning to 2.8.53 (essentially 2.9.0) to give time for this change.

Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Change-Id: I6e879aaf5f9c9e1434f52a7274c663096ceb35b5
Reviewed-on: http://review.whamcloud.com/15979
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Artem Blagodarenko <artem.blagodarenko@seagate.com>
Reviewed-by: James Nunez <james.a.nunez@intel.com>
4 years agoLU-6905 osp: rename ost_server(conn)_uuid 25/15725/4
wang di [Fri, 24 Jul 2015 11:26:58 +0000 (04:26 -0700)]
LU-6905 osp: rename ost_server(conn)_uuid

For OSP to MDT, rename ost_server(conn)_uuid(under /proc)
to mdt_server(conn)_uuid.

Signed-off-by: wang di <di.wang@intel.com>
Change-Id: Iae794b3fd9fd9c21e5b6f04f406ab5e504aab1eb
Reviewed-on: http://review.whamcloud.com/15725
Tested-by: Jenkins
Reviewed-by: Niu Yawei <yawei.niu@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-7005 tests: disable conf-sanity test_50i 80/15980/2
Andreas Dilger [Thu, 13 Aug 2015 19:24:03 +0000 (13:24 -0600)]
LU-7005 tests: disable conf-sanity test_50i

Skip new test for permanently disabling MDT because it is failing
about 50% of the time.

Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Change-Id: I39f71aa5fa880f95f024f74fbca6ef261a6e4dcd
Reviewed-on: http://review.whamcloud.com/15980

4 years agoLU-6924 ptlrpc: replay bulk request 93/15793/5
wang di [Tue, 28 Jul 2015 08:16:52 +0000 (01:16 -0700)]
LU-6924 ptlrpc: replay bulk request

Even though the server might already got the bulk
replay request, but bulk transfer timeout, let's
replay the bulk request, i.e. treat such replay as
same as no replied replay request (See
ptlrpc_replay_interpret()).

Signed-off-by: wang di <di.wang@intel.com>
Change-Id: I1f71eacc3a68941c00f16c9628342c662e7fe181
Reviewed-on: http://review.whamcloud.com/15793
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Alex Zhuravlev <alexey.zhuravlev@intel.com>
Reviewed-by: Niu Yawei <yawei.niu@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6881 update: add lock to protect commit check 90/15690/3
wang di [Tue, 21 Jul 2015 13:16:21 +0000 (06:16 -0700)]
LU-6881 update: add lock to protect commit check

In sub_trans_commit_cb(), the commit check should
be protected by lock, otherwise in some racy
scenarios, all committed will never be true,
even though all sub transaction has been committed.

Signed-off-by: wang di <di.wang@intel.com>
Change-Id: I8f43ca8083753ab6eef4f2be56ef77bb8640bb79
Reviewed-on: http://review.whamcloud.com/15690
Reviewed-by: Niu Yawei <yawei.niu@intel.com>
Tested-by: Jenkins
Reviewed-by: Alex Zhuravlev <alexey.zhuravlev@intel.com>
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6586 mgs: deactive MDT permanently 47/14747/11
wang di [Thu, 7 May 2015 13:40:51 +0000 (06:40 -0700)]
LU-6586 mgs: deactive MDT permanently

Deactivate/activate MDT in the config log, so
the user can permanently deactivate one MDT.

Add active proc entry for MDC, and mark MDC to
be inactive once the MDC is deactivated.

Add conf-sanity.sh 50i to verify activate
and deactivate MDT.

Signed-off-by: wang di <di.wang@intel.com>
Change-Id: Ia8d18f48f12fc180c32da777bde0902a774ddf93
Reviewed-on: http://review.whamcloud.com/14747
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Lai Siyao <lai.siyao@intel.com>
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6770 osc: use global osc_rq_pool to reduce memory usage 22/15422/13
Li Xi [Mon, 13 Jul 2015 14:29:54 +0000 (22:29 +0800)]
LU-6770 osc: use global osc_rq_pool to reduce memory usage

The per-osc request pools consume a lot of memory if there are
hundreds of OSCs on one client. This will be a critical problem
if the client doesn't have sufficient memory for both OSCs and
applications.

This patch replaces per-osc request pools with a global pool
osc_rq_pool. The total memory usage is 5MB by default. And it
can be set by a module parameter of OSC:
"options osc osc_reqpool_mem_max=POOL_SIZE". The unit of POOL_SIZE
is MB. If cl_max_rpcs_in_flight is the same for all OSCs, the
memory usage of the OSC pool can be calculated as:
Min(POOL_SIZE * 1M,
    (cl_max_rpcs_in_flight + 2) * OSC number * OST_IO_MAXREQSIZE)

Also, this patch changes the allocation logic of OSC write requests.
The allocation from osc_rq_pool will only be tried after normal
allocation failed.

Signed-off-by: Wu Libin <lwu@ddn.com>
Signed-off-by: Wang Shilong <wshilong@ddn.com>
Signed-off-by: Li Xi <lixi@ddn.com>
Change-Id: I1b0c522ade01dba11d860ab57f83af53619ce4ba
Reviewed-on: http://review.whamcloud.com/15422
Tested-by: Jenkins
Reviewed-by: Jinshan Xiong <jinshan.xiong@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6765 obdecho: don't copy lu_site 57/15657/4
Olaf Faaland [Mon, 20 Jul 2015 23:57:06 +0000 (16:57 -0700)]
LU-6765 obdecho: don't copy lu_site

While creating an echo device, echo_device_alloc() copies the lu_site
from MD stack, such kind of copy result in uninitialized mutex and
other potential issues.

Instead of copying the lu_site, we'd use the lu_site by pointer directly.

Test-Parameters: alwaysuploadlogs envdefinitions=SLOW=yes \
mdtfilesystemtype=zfs mdsfilesystemtype=zfs ostfilesystemtype=zfs \
clientdistro=el6.6 ossdistro=el6.6 mdsdistro=el6.6 \
mdtcount=1 testlist=mds-survey

Test-Parameters: alwaysuploadlogs envdefinitions=SLOW=yes \
mdtfilesystemtype=ldiskfs mdsfilesystemtype=ldiskfs ostfilesystemtype=ldiskfs \
clientdistro=el6.6 ossdistro=el6.6 mdsdistro=el6.6 \
mdtcount=1 testlist=mds-survey

Signed-off-by: Niu Yawei <yawei.niu@intel.com>
Signed-off-by: Olaf Faaland <faaland1@llnl.gov>
Change-Id: I00bd1a211cf0d556e427ba2f281fbcb1940d41f3
Reviewed-on: http://review.whamcloud.com/15657
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Bobi Jam <bobijam@hotmail.com>
Reviewed-by: Lai Siyao <lai.siyao@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6714 llog: fix the llog_cat_set_first_idx() 41/15841/4
Mikhail Pershin [Sat, 1 Aug 2015 16:10:58 +0000 (19:10 +0300)]
LU-6714 llog: fix the llog_cat_set_first_idx()

The bug was introduced in previous commit causing
wrong catalog index to be set.

Test-Parameters: alwaysuploadlogs envdefinitions=SLOW=yes mdtfilesystemtype=ldiskfs mdsfilesystemtype=ldiskfs ostfilesystemtype=ldiskfs clientdistro=el7 ossdistro=el6.6 mdsdistro=el6.6 mdtcount=1 testlist=performance-sanity
Signed-off-by: Mikhail Pershin <mike.pershin@intel.com>
Change-Id: Iaa0747c5f504109f3a265c7cdda91ebe7ba83b4f
Reviewed-on: http://review.whamcloud.com/15841
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Jenkins
Reviewed-by: Alex Zhuravlev <alexey.zhuravlev@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
4 years agoLU-6090 lnet: save errno between function calls 83/15783/5
Amir Shehata [Tue, 28 Jul 2015 22:55:05 +0000 (15:55 -0700)]
LU-6090 lnet: save errno between function calls

errno can be overwritten by functions like snprintf even if
it succeeded, so save the errno when needed.

Signed-off-by: Amir Shehata <amir.shehata@intel.com>
Change-Id: I9a47267851f7c102727f8653a3a3727047f33186
Reviewed-on: http://review.whamcloud.com/15783
Tested-by: Jenkins
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>