From: Arshad Hussain Date: Tue, 6 Aug 2019 12:23:42 +0000 (+0530) Subject: LU-6142 tests: Fix style issues for multifstat.c X-Git-Tag: 2.12.90~65 X-Git-Url: https://git.whamcloud.com/?p=fs%2Flustre-release.git;a=commitdiff_plain;h=7c852b8fd359a81addb8d68cbc8ebcd5e8782a45;hp=fe2300b2fb91cc321412a6e53335848741ea30cd LU-6142 tests: Fix style issues for multifstat.c This patch fixes issues reported by checkpatch for file lustre/tests/multifstat.c Test-Parameters: trivial Signed-off-by: Arshad Hussain Change-Id: Ief81a0fb80c5863ee92b5e6e602924e8ebdd0031 Reviewed-on: https://review.whamcloud.com/35905 Tested-by: jenkins Tested-by: Maloo Reviewed-by: Shaun Tancheff Reviewed-by: Petros Koutoupis Reviewed-by: Ben Evans Reviewed-by: Oleg Drokin --- diff --git a/lustre/tests/multifstat.c b/lustre/tests/multifstat.c index 6cf823a..cffa54b 100644 --- a/lustre/tests/multifstat.c +++ b/lustre/tests/multifstat.c @@ -38,62 +38,61 @@ int main(int argc, char **argv) { - int fd1, fd2; - struct stat st1, st2; + int fd1, fd2; + struct stat st1, st2; - if (argc != 3) { - printf("Usage %s file1 file2\n", argv[0]); - return 1; - } + if (argc != 3) { + printf("Usage %s file1 file2\n", argv[0]); + return 1; + } + fd1 = open(argv[1], O_CREAT | O_RDWR, 0666); + if (fd1 == -1) { + printf("Error opening %s: %s\n", argv[1], strerror(errno)); + return errno; + } - fd1 = open(argv[1], O_CREAT| O_RDWR, 0666); - if (fd1 == -1) { - printf("Error opening %s: %s\n", argv[1], strerror(errno)); - return errno; - } + fd2 = open(argv[2], O_RDONLY); + if (fd2 == -1) { + printf("Error opening %s: %s\n", argv[2], strerror(errno)); + return errno; + } - fd2 = open(argv[2], O_RDONLY); - if (fd2 == -1) { - printf("Error opening %s: %s\n", argv[2], strerror(errno)); - return errno; - } + sleep(1); - sleep(1); + if (write(fd1, "hello", strlen("hello")) != strlen("hello")) { + printf("Error writing: %s\n", strerror(errno)); + return errno; + } - if ( write(fd1, "hello", strlen("hello")) != strlen("hello")) { - printf("Error writing: %s\n", strerror(errno)); - return errno; - } + if (fstat(fd1, &st1)) { + printf("Error statting %s: %s\n", argv[1], strerror(errno)); + return errno; + } - if ( fstat(fd1, &st1) ) { - printf("Error statting %s: %s\n", argv[1], strerror(errno)); - return errno; - } + if (fstat(fd2, &st2)) { + printf("Error statting %s: %s\n", argv[2], strerror(errno)); + return errno; + } - if ( fstat(fd2, &st2) ) { - printf("Error statting %s: %s\n", argv[2], strerror(errno)); - return errno; - } - - if ( st1.st_size != st2.st_size ) { - printf("Sizes don't match %lu, %lu\n", - (unsigned long)st1.st_size, + if (st1.st_size != st2.st_size) { + printf("Sizes don't match %lu, %lu\n", + (unsigned long)st1.st_size, (unsigned long)st2.st_size); - return 1; - } + return 1; + } - if ( st1.st_mtime != st2.st_mtime ) { - printf("Mtimes don't match %ld, %ld\n", - st1.st_mtime, st2.st_mtime); - return 1; - } + if (st1.st_mtime != st2.st_mtime) { + printf("Mtimes don't match %ld, %ld\n", + st1.st_mtime, st2.st_mtime); + return 1; + } - if ( st1.st_blocks != st2.st_blocks ) { - printf("Blocks don't match %ld, %ld\n", - (long)st1.st_blocks, (long)st2.st_blocks); - return 1; - } + if (st1.st_blocks != st2.st_blocks) { + printf("Blocks don't match %ld, %ld\n", + (long)st1.st_blocks, (long)st2.st_blocks); + return 1; + } - return 0; + return 0; }