From: Alex Zhuravlev Date: Wed, 19 Jul 2017 04:59:13 +0000 (-0400) Subject: LU-9683 ptlrpc: fix argument misorder X-Git-Tag: 2.10.51~17 X-Git-Url: https://git.whamcloud.com/?p=fs%2Flustre-release.git;a=commitdiff_plain;h=61c48e79fdfb825ea1ab2649cdadaccfb863155c LU-9683 ptlrpc: fix argument misorder involved in timediffs calculation. Change-Id: Ib4a45dddb3866824b696aaeaa190f2ab9b1c71ac Signed-off-by: Alex Zhuravlev Reviewed-on: https://review.whamcloud.com/28027 Reviewed-by: James Simmons Reviewed-by: Niu Yawei Reviewed-by: Mike Pershin Tested-by: Jenkins Tested-by: Maloo Reviewed-by: Oleg Drokin --- diff --git a/lustre/ptlrpc/client.c b/lustre/ptlrpc/client.c index bac3301..4409de6 100644 --- a/lustre/ptlrpc/client.c +++ b/lustre/ptlrpc/client.c @@ -1361,7 +1361,7 @@ static int after_reply(struct ptlrpc_request *req) } work_start = ktime_get_real(); - timediff = ktime_us_delta(req->rq_sent_ns, work_start); + timediff = ktime_us_delta(work_start, req->rq_sent_ns); /* * NB Until this point, the whole of the incoming message, diff --git a/lustre/ptlrpc/service.c b/lustre/ptlrpc/service.c index 9e18d97..ecde6ab 100644 --- a/lustre/ptlrpc/service.c +++ b/lustre/ptlrpc/service.c @@ -2055,7 +2055,7 @@ ptlrpc_server_handle_request(struct ptlrpc_service_part *svcpt, work_start = ktime_get_real(); arrived = timespec64_to_ktime(request->rq_arrival_time); - timediff_usecs = ktime_us_delta(arrived, work_start); + timediff_usecs = ktime_us_delta(work_start, arrived); if (likely(svc->srv_stats != NULL)) { lprocfs_counter_add(svc->srv_stats, PTLRPC_REQWAIT_CNTR, timediff_usecs);