From: Dmitry Eremin Date: Fri, 14 Feb 2014 17:23:56 +0000 (+0400) Subject: LU-4629 liblustre: remove suspicious check X-Git-Tag: 2.5.57~52 X-Git-Url: https://git.whamcloud.com/?p=fs%2Flustre-release.git;a=commitdiff_plain;h=4ea6a7a00a71330e40fa41c97152b93a0cab0397 LU-4629 liblustre: remove suspicious check Suspicious dereference of pointer 'inode' by passing argument 1 to function 'llu_i2info' at line 387 before NULL check at line 391. The pointer 'inode' can not be NULL. This checked on upper layer. Signed-off-by: Dmitry Eremin Change-Id: Iea1e4d46f9faccf74a895002a8640959d63c395a Reviewed-on: http://review.whamcloud.com/9324 Tested-by: Jenkins Reviewed-by: Andreas Dilger Reviewed-by: James Simmons Tested-by: Maloo Reviewed-by: John L. Hammond --- diff --git a/lustre/liblustre/super.c b/lustre/liblustre/super.c index 3f3788a..726e141 100644 --- a/lustre/liblustre/super.c +++ b/lustre/liblustre/super.c @@ -388,11 +388,6 @@ static int llu_inode_revalidate(struct inode *inode) struct intnl_stat *st = llu_i2stat(inode); ENTRY; - if (!inode) { - CERROR("REPORT THIS LINE TO PETER\n"); - RETURN(0); - } - if (!llu_have_md_lock(inode, MDS_INODELOCK_UPDATE)) { struct lustre_md md; struct ptlrpc_request *req = NULL;