From: Andreas Dilger Date: Thu, 26 Jun 2014 23:53:52 +0000 (-0600) Subject: LU-10886 build: fix warnings during autoconf X-Git-Tag: 2.11.52~43 X-Git-Url: https://git.whamcloud.com/?p=fs%2Flustre-release.git;a=commitdiff_plain;h=457e36a2993fcefe18c571ff5b798e3ab4aec81a LU-10886 build: fix warnings during autoconf Quiet warnings in configure checks to avoid confusion when debugging autoconf/configure scripts, and to avoid potential errors during detection. Signed-off-by: Andreas Dilger Change-Id: I2916a120b57fb9fa529bf7050cf65511233ebbe5 Reviewed-on: https://review.whamcloud.com/31904 Tested-by: Jenkins Tested-by: Maloo Reviewed-by: Dmitry Eremin Reviewed-by: James Simmons Reviewed-by: Oleg Drokin --- diff --git a/libcfs/autoconf/lustre-libcfs.m4 b/libcfs/autoconf/lustre-libcfs.m4 index 21c8208..2df490a 100644 --- a/libcfs/autoconf/lustre-libcfs.m4 +++ b/libcfs/autoconf/lustre-libcfs.m4 @@ -316,7 +316,7 @@ ktime_get_ts64, [ # # Linux kernel 3.12 introduced struct kernel_param_ops # This has been backported to all lustre supported -# clients expect RHEL6. We have to handle the differences. +# clients except RHEL6. We have to handle the differences. # AC_DEFUN([LIBCFS_KERNEL_PARAM_OPS],[ LB_CHECK_COMPILE([does 'struct kernel_param_ops' exist], @@ -324,6 +324,8 @@ kernel_param_ops, [ #include ],[ struct kernel_param_ops ops; + + ops.set = NULL; ],[ AC_DEFINE(HAVE_KERNEL_PARAM_OPS, 1, ['struct kernel_param_ops' is available]) @@ -417,7 +419,9 @@ shrinker_count_objects, [ #include #include ],[ - ((struct shrinker*)0)->count_objects(NULL, NULL); + struct shrinker shrinker; + + shrinker.count_objects = NULL; ],[ AC_DEFINE(HAVE_SHRINKER_COUNT, 1, [shrinker has count_objects member]) @@ -539,7 +543,7 @@ ktime_to_timespec64, [ #include ],[ struct timespec64 ts; - ktime_t now; + ktime_t now = { }; ts = ktime_to_timespec64(now); ],[ @@ -556,7 +560,7 @@ LB_CHECK_COMPILE([does function 'timespec64_sub' exist], timespec64_sub, [ #include ],[ - struct timespec64 later,earlier,diff; + struct timespec64 later = { }, earlier = { }, diff; diff = timespec64_sub(later, earlier); ],[ @@ -845,6 +849,8 @@ wait_queue_entry, [ #include ],[ wait_queue_entry_t e; + + e.flags = 0; ],[ AC_DEFINE(HAVE_WAIT_QUEUE_ENTRY, 1, ['wait_queue_entry_t' is available]) diff --git a/lnet/autoconf/lustre-lnet.m4 b/lnet/autoconf/lustre-lnet.m4 index d3a302e..909cc7e 100644 --- a/lnet/autoconf/lustre-lnet.m4 +++ b/lnet/autoconf/lustre-lnet.m4 @@ -36,12 +36,9 @@ AS_IF([test "x$enable_affinity" = xyes], [ set_cpus_allowed_ptr, [ #include ],[ - struct task_struct *t; - #if HAVE_CPUMASK_T - cpumask_t m; - #else - unsigned long m; - #endif + struct task_struct *t = NULL; + cpumask_t m = { }; + set_cpus_allowed_ptr(t, &m); ],[ AC_DEFINE(CPU_AFFINITY, 1, @@ -281,7 +278,7 @@ AS_IF([test $ENABLEO2IB = "no"], [ #endif #include ],[ - struct kthread_work *kth_wrk __attribute__ ((unused)); + struct kthread_work *kth_wrk = NULL; flush_kthread_work(kth_wrk); ],[ AC_DEFINE(HAVE_KTHREAD_WORK, 1, [kthread_worker found]) @@ -690,8 +687,8 @@ EXTRA_KCFLAGS="$tmp_flags" # AC_DEFUN([LN_EXPORT_KMAP_TO_PAGE], [ LB_CHECK_EXPORT([kmap_to_page], [mm/highmem.c], - [AC_DEFINE(HAVE_KMAP_TO_PAGE, 1, - [kmap_to_page is exported by the kernel])]) + [AC_DEFINE(HAVE_KMAP_TO_PAGE, 1, + [kmap_to_page is exported by the kernel])]) ]) # LN_EXPORT_KMAP_TO_PAG # diff --git a/lustre/autoconf/lustre-core.m4 b/lustre/autoconf/lustre-core.m4 index 3836357..485cfbf 100644 --- a/lustre/autoconf/lustre-core.m4 +++ b/lustre/autoconf/lustre-core.m4 @@ -508,8 +508,8 @@ LB_CHECK_COMPILE([if '__add_wait_queue_exclusive' exists], __add_wait_queue_exclusive, [ #include ],[ - wait_queue_head_t queue; - wait_queue_t wait; + wait_queue_head_t queue = { }; + wait_queue_t wait = { }; __add_wait_queue_exclusive(&queue, &wait); ],[ @@ -530,7 +530,10 @@ fs_struct_rwlock, [ #include #include ],[ - ((struct fs_struct *)0)->lock = (rwlock_t){ 0 }; + struct fs_struct fss = { }; + rwlock_t rwl = { }; + + fss.lock = rwl; ],[ AC_DEFINE(HAVE_FS_STRUCT_RWLOCK, 1, [fs_struct.lock use rwlock]) ]) @@ -759,8 +762,10 @@ LB_CHECK_COMPILE([if 'file_system_type' has 'mount' field], file_system_type_mount, [ #include ],[ - struct file_system_type fst; - void *i = (void *) fst.mount; + struct file_system_type fst = { }; + void *mount; + + mount = (void *)fst.mount; ],[ AC_DEFINE(HAVE_FSTYPE_MOUNT, 1, [struct file_system_type has mount field]) @@ -809,7 +814,7 @@ LB_CHECK_COMPILE([if 'dirty_inode' super_operation takes flag], dirty_inode_super_operation_flag, [ #include ],[ - struct inode *inode; + struct inode *inode = NULL; inode->i_sb->s_op->dirty_inode(NULL, 0); ],[ AC_DEFINE(HAVE_DIRTY_INODE_HAS_FLAG, 1, @@ -1021,7 +1026,7 @@ address_space_ops_migratepage_4args, [ #include #endif ],[ - struct address_space_operations aops; + struct address_space_operations aops = { }; aops.migratepage(NULL, NULL, NULL, MIGRATE_ASYNC); ],[ AC_DEFINE(HAVE_MIGRATEPAGE_4ARGS, 1, @@ -1394,9 +1399,10 @@ LB_CHECK_COMPILE([if 'bio_end_sector' is defined], bio_end_sector, [ #include ],[ - struct bio bio; + struct bio bio = { }; + unsigned long long end; - bio_end_sector(&bio); + end = bio_end_sector(&bio); ],[ AC_DEFINE(HAVE_BIO_END_SECTOR, 1, [bio_end_sector is defined]) @@ -1411,7 +1417,7 @@ LB_CHECK_COMPILE([if 'is_sxid' is defined], is_sxid, [ #include ],[ - struct inode inode; + struct inode inode = { }; is_sxid(inode.i_mode); ],[ @@ -1456,9 +1462,10 @@ proc_remove, [ AC_DEFUN([LC_HAVE_PROJECT_QUOTA], [ LB_CHECK_COMPILE([if get_projid exists], get_projid, [ + struct inode; #include ],[ - struct dquot_operations ops; + struct dquot_operations ops = { }; ops.get_projid(NULL, NULL); ],[ @@ -1517,6 +1524,7 @@ dir_context, [ #error "back to use readdir in kabi_extand mode" #else struct dir_context ctx; + ctx.pos = 0; #endif ],[ @@ -1548,12 +1556,14 @@ d_compare_5args, [ # 3.11 need to access d_count to get dentry reference count # AC_DEFUN([LC_HAVE_DCOUNT], [ -LB_CHECK_COMPILE([if 'd_count' exist], +LB_CHECK_COMPILE([if 'd_count' exists], d_count, [ #include ],[ - struct dentry de; - d_count(&de); + struct dentry de = { }; + int count; + + count = d_count(&de); ],[ AC_DEFINE(HAVE_D_COUNT, 1, [d_count exist]) @@ -1731,6 +1741,7 @@ have_bvec_iter, [ #include ],[ struct bvec_iter iter; + iter.bi_bvec_done = 0; ], [ AC_DEFINE(HAVE_BVEC_ITER, 1, @@ -1768,7 +1779,7 @@ have_bi_cnt, [ #include #include ],[ - struct bio bio; + struct bio bio = { }; int cnt; cnt = atomic_read(&bio.bi_cnt); ], [ @@ -1788,7 +1799,8 @@ have_bi_rw, [ #include ],[ struct bio bio; - bio.bi_rw; + + bio.bi_rw = 0; ], [ AC_DEFINE(HAVE_BI_RW, 1, [struct bio has bi_rw]) @@ -1896,7 +1908,7 @@ LB_CHECK_COMPILE([if direct IO uses iov_iter], direct_io_iter, [ #include ],[ - struct address_space_operations ops; + struct address_space_operations ops = { }; struct iov_iter *iter = NULL; loff_t offset = 0; @@ -1986,6 +1998,8 @@ key_match, [ #include ],[ struct key_match_data data; + + data.raw_data = NULL; ],[ AC_DEFINE(HAVE_KEY_MATCH_DATA, 1, [struct key_match_data exist]) @@ -2051,7 +2065,7 @@ LB_CHECK_COMPILE([if struct kiocb has ki_nbytes field], ki_nbytes, [ #include ],[ - struct kiocb iocb; + struct kiocb iocb = { }; iocb.ki_nbytes = 0; ],[ @@ -2320,7 +2334,9 @@ LB_CHECK_COMPILE([if 'struct key' has 'payload.data' as an array], key_payload_data_array, [ #include ],[ - ((struct key *)0)->payload.data[0] = NULL; + struct key key = { }; + + key.payload.data[0] = NULL; ],[ AC_DEFINE(HAVE_KEY_PAYLOAD_DATA_ARRAY, 1, [payload.data is an array]) ]) @@ -2451,10 +2467,11 @@ LB_CHECK_COMPILE([if '->direct_IO()' taken 2 arguments], direct_io_2args, [ #include ],[ - struct address_space_operations ops; + struct address_space_operations ops = { }; struct iov_iter *iter = NULL; struct kiocb *iocb = NULL; int rc; + rc = ops.direct_IO(iocb, iter); ],[ AC_DEFINE(HAVE_DIRECTIO_2ARGS, 1, @@ -2475,6 +2492,7 @@ generic_write_sync_2args, [ ],[ struct kiocb *iocb = NULL; ssize_t rc; + rc = generic_write_sync(iocb, 0); ],[ AC_DEFINE(HAVE_GENERIC_WRITE_SYNC_2ARGS, 1,