From: Lai Siyao Date: Wed, 12 Apr 2017 21:56:50 +0000 (+0800) Subject: LU-8935 ptlrpc: missing barrier before wake_up X-Git-Tag: 2.10.51~33 X-Git-Url: https://git.whamcloud.com/?p=fs%2Flustre-release.git;a=commitdiff_plain;h=33033c27aae361069877d56d44714097a208aa76;ds=sidebyside LU-8935 ptlrpc: missing barrier before wake_up ptlrpc_client_wake_req() misses a memory barrier, which may cause strange errors. Signed-off-by: Lai Siyao Change-Id: Ic8e9cbaf8c07f503798b95c608477508204d9614 Reviewed-on: https://review.whamcloud.com/26583 Reviewed-by: Andreas Dilger Tested-by: Jenkins Tested-by: Maloo Reviewed-by: Wang Shilong Reviewed-by: Oleg Drokin --- diff --git a/lustre/include/lustre_net.h b/lustre/include/lustre_net.h index 6c9f530..f705ceb 100644 --- a/lustre/include/lustre_net.h +++ b/lustre/include/lustre_net.h @@ -2517,6 +2517,7 @@ ptlrpc_client_recv_or_unlink(struct ptlrpc_request *req) static inline void ptlrpc_client_wake_req(struct ptlrpc_request *req) { + smp_mb(); if (req->rq_set == NULL) wake_up(&req->rq_reply_waitq); else