From: NeilBrown Date: Sun, 11 Aug 2019 15:43:40 +0000 (-0400) Subject: LU-12503 vvp_dev: increment *pos in .next X-Git-Tag: 2.12.58~67 X-Git-Url: https://git.whamcloud.com/?p=fs%2Flustre-release.git;a=commitdiff_plain;h=02336a9a5d096dc9a603ed0e77e0c7cf7b41ffb3 LU-12503 vvp_dev: increment *pos in .next As described in Commit ec2e9995e4c5 ("lustre: llite: change how "dump_page_cache" walks a hash table") The .next function should increment *pos. For some reason it didn't, and this can trigger the warning in that function. Change-Id: If4ac748f455750d82712299b7915eb541a3ddc7e Signed-off-by: NeilBrown Reviewed-on: https://review.whamcloud.com/35765 Tested-by: jenkins Tested-by: Maloo Reviewed-by: Patrick Farrell Reviewed-by: Oleg Drokin --- diff --git a/lustre/llite/vvp_dev.c b/lustre/llite/vvp_dev.c index 3802bc7..d36aed3 100644 --- a/lustre/llite/vvp_dev.c +++ b/lustre/llite/vvp_dev.c @@ -558,7 +558,7 @@ static void *vvp_pgcache_next(struct seq_file *f, void *v, loff_t *pos) struct vvp_seq_private *priv = f->private; WARN_ON(*pos != priv->vvp_prev_pos); - + *pos += 1; priv->vvp_prev_pos = *pos; return vvp_pgcache_next_page(priv); }