LU-11848 tests: handle 4-digit version numbers properly

Allow version_code() to handle and compare 4-digit version numbers
properly.

Signed-off-by: Andreas Dilger <adilger@whamcloud.com>
Change-Id: I8f57537f87bb1c087def277d0d6192def43ebbe5
Reviewed-on: https://review.whamcloud.com/40897
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Bobi Jam <bobijam@hotmail.com>
Reviewed-by: James Nunez <jnunez@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>

diff --git a/lustre/tests/sanity.sh b/lustre/tests/sanity.sh
index a79e409..e8c0832 100755 (executable)
--- a/lustre/tests/sanity.sh
+++ b/lustre/tests/sanity.sh
@@ -241,12 +241,13 @@ test_0d() { # LU-3397
        [ "$exp_val" == "$imp_val" ] ||
                error "export flags '$exp_val' != import flags '$imp_val'"
 
-       # Compare the value of client version
+       # Compare client versions.  Only compare top-3 fields for compatibility
        exp_client_version=$(awk '/target_version:/ { print $2 }' $temp_exp)
-       exp_val=$(version_code $exp_client_version)
-       imp_val=$CLIENT_VERSION
+       exp_val=$(version_code $(cut -d. -f1,2,3 <<<$exp_client_version))
+       imp_val=$(version_code $(lustre_build_version client | cut -d. -f1,2,3))
        [ "$exp_val" == "$imp_val" ] ||
-               error "export client version '$exp_val' != '$imp_val'"
+               error "exp version '$exp_client_version'($exp_val) != " \
+                       "'$(lustre_build_version client)'($imp_val)"
 }
 run_test 0d "check export proc ============================="
 

diff --git a/lustre/tests/test-framework.sh b/lustre/tests/test-framework.sh
index 4bfec65..033e32a 100755 (executable)
--- a/lustre/tests/test-framework.sh
+++ b/lustre/tests/test-framework.sh
@@ -455,10 +455,10 @@ check_cpt_number() {
 # Return a numeric version code based on a version string.  The version
 # code is useful for comparison two version strings to see which is newer.
 version_code() {
-       # split arguments like "1.8.6-wc3" into "1", "8", "6", "wc3"
-       eval set -- $(tr "[:punct:]" " " <<< $*)
+       # split arguments like "1.8.6-wc3" into "1", "8", "6", "3"
+       eval set -- $(tr "[:punct:][a-z]" " " <<< $*)
 
-       echo -n $(((${1:-0} << 16) | (${2:-0} << 8) | ${3:-0}))
+       echo -n $(((${1:-0}<<24) | (${2:-0}<<16) | (${3:-0}<<8) | (${4:-0})))
 }
 
 export LINUX_VERSION=$(uname -r | sed -e "s/\([0-9]*\.[0-9]*\.[0-9]*\).*/\1/")