Whamcloud - gitweb
LU-13164 uapi: remove unused LUSTRE_DIRECTIO_FL 95/37295/2
authorAndreas Dilger <adilger@whamcloud.com>
Tue, 21 Jan 2020 09:32:54 +0000 (02:32 -0700)
committerOleg Drokin <green@whamcloud.com>
Tue, 28 Jan 2020 06:04:00 +0000 (06:04 +0000)
The LUSTRE_DIRECTIO_FL was added based on the upstream FS_DIRECTIO_FL
flag in the hopes that it might be useful, but it has since been
removed from the upstream in kernel commit v4.4-rc4-22-g68ce7bfcd995
and replaced by FS_VERITY_FL using the same value in kernel commit
v5.3-rc2-4-gfe9918d3b228, which we are much more likely to use.

Since LUSTRE_DIRECTIO_FL was unused, there is no risk to remove it.

Test-Parameters: trivial
Signed-off-by: Andreas Dilger <adilger@whamcloud.com>
Change-Id: I49e915612636a674a86d25be5d91a042693ebbe5
Reviewed-on: https://review.whamcloud.com/37295
Tested-by: jenkins <devops@whamcloud.com>
Reviewed-by: Shaun Tancheff <shaun.tancheff@hpe.com>
Reviewed-by: Arshad Hussain <arshad.super@gmail.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: James Simmons <jsimmons@infradead.org>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
lustre/include/uapi/linux/lustre/lustre_idl.h
lustre/ptlrpc/wiretest.c
lustre/utils/wirecheck.c
lustre/utils/wiretest.c

index ab3d045..df2ce2b 100644 (file)
@@ -1752,7 +1752,6 @@ enum {
        LUSTRE_INDEX_FL         = 0x00001000, /* hash-indexed directory */
        LUSTRE_DIRSYNC_FL       = 0x00010000, /* dirsync behaviour (dir only) */
        LUSTRE_TOPDIR_FL        = 0x00020000, /* Top of directory hierarchies*/
-       LUSTRE_DIRECTIO_FL      = 0x00100000, /* Use direct i/o */
        LUSTRE_INLINE_DATA_FL   = 0x10000000, /* Inode has inline data. */
        LUSTRE_PROJINHERIT_FL   = 0x20000000, /* Create with parents projid */
 
index fd14718..1968b84 100644 (file)
@@ -2516,8 +2516,6 @@ void lustre_assert_wire_constants(void)
                (unsigned)LUSTRE_DIRSYNC_FL);
        LASSERTF(LUSTRE_TOPDIR_FL == 0x00020000UL, "found 0x%.8xUL\n",
                (unsigned)LUSTRE_TOPDIR_FL);
-       LASSERTF(LUSTRE_DIRECTIO_FL == 0x00100000UL, "found 0x%.8xUL\n",
-               (unsigned)LUSTRE_DIRECTIO_FL);
        LASSERTF(LUSTRE_INLINE_DATA_FL == 0x10000000UL, "found 0x%.8xUL\n",
                (unsigned)LUSTRE_INLINE_DATA_FL);
        LASSERTF(MDS_INODELOCK_LOOKUP == 0x00000001UL, "found 0x%.8xUL\n",
index f6c9bad..ddbb7ce 100644 (file)
@@ -1139,7 +1139,6 @@ check_mdt_body(void)
        CHECK_VALUE_X(LUSTRE_ORPHAN_FL);
        CHECK_VALUE_X(LUSTRE_DIRSYNC_FL);
        CHECK_VALUE_X(LUSTRE_TOPDIR_FL);
-       CHECK_VALUE_X(LUSTRE_DIRECTIO_FL);
        CHECK_VALUE_X(LUSTRE_INLINE_DATA_FL);
 
        CHECK_VALUE_X(MDS_INODELOCK_LOOKUP);
index 391ca56..63c1ea9 100644 (file)
@@ -2546,8 +2546,6 @@ void lustre_assert_wire_constants(void)
                (unsigned)LUSTRE_DIRSYNC_FL);
        LASSERTF(LUSTRE_TOPDIR_FL == 0x00020000UL, "found 0x%.8xUL\n",
                (unsigned)LUSTRE_TOPDIR_FL);
-       LASSERTF(LUSTRE_DIRECTIO_FL == 0x00100000UL, "found 0x%.8xUL\n",
-               (unsigned)LUSTRE_DIRECTIO_FL);
        LASSERTF(LUSTRE_INLINE_DATA_FL == 0x10000000UL, "found 0x%.8xUL\n",
                (unsigned)LUSTRE_INLINE_DATA_FL);
        LASSERTF(MDS_INODELOCK_LOOKUP == 0x00000001UL, "found 0x%.8xUL\n",