Whamcloud - gitweb
LU-8014 hsm: remove invalid kuc_free in coordinator 69/19869/3
authorFrank Zago <fzago@cray.com>
Thu, 28 Apr 2016 21:07:16 +0000 (17:07 -0400)
committerOleg Drokin <oleg.drokin@intel.com>
Fri, 27 May 2016 00:58:06 +0000 (00:58 +0000)
Commit 9091a934fc ("LU-8014 hsm: remove kuc_ispayload") moved the KUC
allocation in mdt_hsm_agent_send() and I left a kuc_free in an error
path in mdt_coordinator(). The HAL is no longer a KUC and it is freed
outside the for loop. That kuc_free is incorrect.

Signed-off-by: frank zago <fzago@cray.com>
Change-Id: If0894d1a8bcbc7960b728e33a34bddb95806acf8
Reviewed-on: http://review.whamcloud.com/19869
Tested-by: Jenkins
Reviewed-by: Henri Doreau <henri.doreau@cea.fr>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
lustre/mdt/mdt_coordinator.c

index c02f6a1..caa57ca 100644 (file)
@@ -546,7 +546,6 @@ static int mdt_coordinator(void *data)
                                       "for cookies vector "LPX64"\n",
                                       mdt_obd_name(mdt), sz,
                                       hal->hal_compound_id);
-                               kuc_free(hal, hsd.request[i].hal_used_sz);
                                continue;
                        }
                        hai = hai_first(hal);