Whamcloud - gitweb
LU-2744 build: fix 'data race condition' issues 68/6568/4
authorSebastien Buisson <sebastien.buisson@bull.net>
Thu, 6 Jun 2013 12:35:51 +0000 (14:35 +0200)
committerOleg Drokin <oleg.drokin@intel.com>
Tue, 10 Sep 2013 16:55:32 +0000 (16:55 +0000)
Fix 'data race condition' defects found by Coverity version
6.5.0:
Data race condition (MISSING_LOCK)
Accessing variable without holding lock. Elsewhere,
this variable is accessed with lock held.

Signed-off-by: Sebastien Buisson <sebastien.buisson@bull.net>
Change-Id: I706e4facef8d29a3b072f977c7a903e6c1772b71
Reviewed-on: http://review.whamcloud.com/6568
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Tested-by: Hudson
Tested-by: Maloo <whamcloud.maloo@gmail.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
lnet/selftest/framework.c

index 305659e..2e32c3d 100644 (file)
@@ -1005,9 +1005,8 @@ sfw_run_test (swi_workitem_t *wi)
        cfs_list_add_tail(&rpc->crpc_list, &tsi->tsi_active_rpcs);
        spin_unlock(&tsi->tsi_lock);
 
-       rpc->crpc_timeout = rpc_timeout;
-
        spin_lock(&rpc->crpc_lock);
+       rpc->crpc_timeout = rpc_timeout;
        srpc_post_rpc(rpc);
        spin_unlock(&rpc->crpc_lock);
        return 0;