Whamcloud - gitweb
LU-15626 tests: Fix "error" reported by shellcheck for recovery-mds-scale 65/46865/12
authorArshad Hussain <arshad.hussain@aeoncomputing.com>
Fri, 18 Mar 2022 07:25:25 +0000 (12:55 +0530)
committerOleg Drokin <green@whamcloud.com>
Mon, 18 Jul 2022 05:34:55 +0000 (05:34 +0000)
This patch fixes "error" issues reported by shellcheck
for file lustre/tests/recovery-mds-scale.sh. This patch
also moves spaces to tabs.

Test-Parameters: trivial clientcount=6 mdtcount=2 mdscount=2 osscount=2 austeroptions=-R failover=true iscsi=1 env=FAILOVER_PERIOD=180,DURATION=600,SLOW=no testlist=recovery-mds-scale
Signed-off-by: Arshad Hussain <arshad.hussain@aeoncomputing.com>
Change-Id: I6c098809835950e1f781e04a6898895592407948
Reviewed-on: https://review.whamcloud.com/46865
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Reviewed-by: Jian Yu <yujian@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
lustre/tests/recovery-mds-scale.sh

index 34d9d51..c40c9f9 100644 (file)
@@ -11,7 +11,7 @@ ONLY=${ONLY:-"$*"}
 
 LUSTRE=${LUSTRE:-$(dirname $0)/..}
 . $LUSTRE/tests/test-framework.sh
-init_test_env $@
+init_test_env "$@"
 init_logging
 
 # bug number for skipped test:
@@ -20,24 +20,24 @@ ALWAYS_EXCEPT="$RECOVERY_MDS_SCALE_EXCEPT"
 
 build_test_filter
 
-remote_mds_nodsh && skip_env "remote MDS with nodsh" && exit 0
-remote_ost_nodsh && skip_env "remote OST with nodsh" && exit 0
+remote_mds_nodsh && skip_env "remote MDS with nodsh"
+remote_ost_nodsh && skip_env "remote OST with nodsh"
 
-[ $CLIENTCOUNT -lt 3 ] &&
-    skip_env "need three or more clients" && exit 0
+(( $CLIENTCOUNT < 3 )) &&
+       skip_env "need three or more clients"
 
+# SHARED_DIRECTORY should be specified with a shared directory which is
+# accessable on all of the nodes
 if [ -z "$SHARED_DIRECTORY" ] || ! check_shared_dir $SHARED_DIRECTORY; then
-    skip_env "SHARED_DIRECTORY should be specified with a shared directory \
-which is accessable on all of the nodes"
-    exit 0
+       skip_env "SHARED_DIRECTORY not set"
 fi
 
 ERRORS_OK=""    # No application failures should occur during this test.
 
 if [ "$SLOW" = "no" ]; then
-    DURATION=${DURATION:-$((60 * 30))}
+       DURATION=${DURATION:-$((60 * 30))}
 else
-    DURATION=${DURATION:-$((60 * 60 * 24))}
+       DURATION=${DURATION:-$((60 * 60 * 24))}
 fi
 SERVER_FAILOVER_PERIOD=${SERVER_FAILOVER_PERIOD:-$((60 * 10))} # 10 minutes
 
@@ -51,168 +51,194 @@ END_RUN_FILE=${END_RUN_FILE:-$SHARED_DIRECTORY/end_run_file}
 LOAD_PID_FILE=${LOAD_PID_FILE:-$TMP/client-load.pid}
 VMSTAT_PID_FILE=${VMSTAT_PID_FILE:-$TMP/vmstat.pid}
 
+run_info() {
+       local oput=echo
+
+       $oput "******* Run Information *******"
+       $oput "SERVER_FAILOVER_PERIOD:$1"
+       $oput "DURATION:$2"
+       $oput "MINSLEEP:$3"
+       $oput "SLOW:$4"
+       $oput "REQFAIL:$5"
+       $oput "SHARED_DIRECTORY:$6"
+       $oput "END_RUN_FILE:$7"
+       $oput "LOAD_PID_FILE:$8"
+       $oput "VMSTAT_PID_FILE:$9"
+       $oput "CLIENTCOUNT:$10"
+       $oput "MDTS:$11"
+       $oput "OSTS:$12"
+       $oput "*******************************"
+}
+
 server_numfailovers () {
-    local facet=$1
-    local var=${facet}_numfailovers
-    local val=0
+       local facet=$1
+       local var=${facet}_numfailovers
+       local val=0
 
-    [[ ${!var} ]] && val=${!var}
-    echo $val
+       [[ ${!var} ]] && val=${!var}
+       echo $val
 }
 
 servers_numfailovers () {
-    local facet
-    local var
+       local facet
+       local var
 
-    for facet in ${MDTS//,/ } ${OSTS//,/ }; do
-        echo "$facet: $(server_numfailovers $facet) times"
-    done
+       for facet in ${MDTS//,/ } ${OSTS//,/ }; do
+               echo "$facet: $(server_numfailovers $facet) times"
+       done
 }
 
 summary_and_cleanup () {
-    local rc=$?
-    trap 0
-
-    # Having not empty END_RUN_FILE means the failed loads only
-    if [ -s $END_RUN_FILE ]; then
-        print_end_run_file $END_RUN_FILE
-        rc=1
-    fi
-
-    echo $(date +'%F %H:%M:%S') Terminating clients loads ...
-    echo "$0" >> $END_RUN_FILE
-    local result=PASS
-    [ $rc -eq 0 ] || result=FAIL
-
-    log "Duration:               $DURATION
-Server failover period: $SERVER_FAILOVER_PERIOD seconds
-Exited after:           $ELAPSED seconds
-Number of failovers before exit:
-$(servers_numfailovers)
-Status: $result: rc=$rc"
-
-    # stop vmstat on OSS nodes
-    [ "$VMSTAT" ] && stop_process $(comma_list $(osts_nodes)) $VMSTAT_PID_FILE
-
-    # stop the client loads
-    stop_client_loads $NODES_TO_USE $LOAD_PID_FILE
-
-       if [ $rc -ne 0 ]; then
+       local rc=$?
+
+       # Having not empty END_RUN_FILE means the failed loads only
+       if [ -s $END_RUN_FILE ]; then
+               print_end_run_file $END_RUN_FILE
+               rc=1
+       fi
+
+       echo $(date +'%F %H:%M:%S') Terminating clients loads ...
+       echo "$0" >> $END_RUN_FILE
+       local result=PASS
+       (( $rc == 0 )) || result=FAIL
+
+       log "Duration:               $DURATION"
+       log "Server failover period: $SERVER_FAILOVER_PERIOD seconds"
+       log "Exited after:           $ELAPSED seconds"
+       log "Number of failovers before exit:"
+       log "$(servers_numfailovers)"
+       log "Status: $result: rc=$rc"
+
+       # stop vmstat on OSS nodes
+       [ "$VMSTAT" ] &&
+               stop_process $(comma_list $(osts_nodes)) $VMSTAT_PID_FILE
+
+       # stop the client loads
+       stop_client_loads $NODES_TO_USE $LOAD_PID_FILE
+
+       if (( $rc != 0 )); then
                # we are interested in only on failed clients and servers
                local failedclients=$(cat $END_RUN_FILE | grep -v $0)
                gather_logs $(comma_list $(all_server_nodes) $failedclients)
        fi
 
-    exit $rc
+       exit $rc
 }
 
 failover_target() {
-    local flavor=${1:-"MDS"}
-    local servers
-    local serverfacet
-    local var
-
-    [ "$flavor" = "MDS" ] && servers=$MDTS || servers=$OSTS
-
-    trap summary_and_cleanup EXIT INT
-
-    # start vmstat on OSS nodes
-    [ "$VMSTAT" ] && start_vmstat $(comma_list $(osts_nodes)) $VMSTAT_PID_FILE
-
-    # start client loads
-    rm -f $END_RUN_FILE
-    start_client_loads $NODES_TO_USE
-
-    echo client loads pids:
-    do_nodesv $NODES_TO_USE "cat $LOAD_PID_FILE" || exit 3
-
-    ELAPSED=0
-    local sleep=0
-    local reqfail=0
-    local it_time_start
-    local start_ts=$(date +%s)
-    local current_ts=$start_ts
-
-    while [ $ELAPSED -lt $DURATION -a ! -e $END_RUN_FILE ]; do
-        # In order to perform the
-        # expected number of failovers, we need to account the following:
-        # 1) the time that has elapsed during the client load checking
-        # 2) time takes for failover
-        it_time_start=$(date +%s)
-
-        serverfacet=$(get_random_entry $servers)
-        var=${serverfacet}_numfailovers
-
-        # Check that our client loads are still running. If any have died,
-        # that means they have died outside of recovery, which is unacceptable.
-        log "==== Checking the clients loads BEFORE failover -- failure NOT OK \
-             ELAPSED=$ELAPSED DURATION=$DURATION PERIOD=$SERVER_FAILOVER_PERIOD"
-        check_client_loads $NODES_TO_USE || exit 4
-
-        log "Wait $serverfacet recovery complete before doing next failover..."
-        if ! wait_recovery_complete $serverfacet; then
-            echo "$serverfacet recovery is not completed!"
-            exit 7
-        fi
+       local flavor=${1:-"MDS"}
+       local servers
+       local serverfacet
+       local var
+
+       [ "$flavor" = "MDS" ] && servers=$MDTS || servers=$OSTS
+
+       stack_trap summary_and_cleanup EXIT INT
+
+       # start vmstat on OSS nodes
+       [ "$VMSTAT" ] &&
+               start_vmstat $(comma_list $(osts_nodes)) $VMSTAT_PID_FILE
+
+       # start client loads
+       rm -f $END_RUN_FILE
+       start_client_loads $NODES_TO_USE
+
+       echo client loads pids:
+       do_nodesv $NODES_TO_USE "cat $LOAD_PID_FILE" || exit 3
+
+       ELAPSED=0
+       local sleep=0
+       local reqfail=0
+       local it_time_start
+       local start_ts=$(date +%s)
+       local current_ts=$start_ts
+
+       while [ $ELAPSED -lt $DURATION -a ! -e $END_RUN_FILE ]; do
+               # In order to perform the
+               # expected number of failovers, we need to account the
+               # following:
+               # 1) the time that has elapsed during the client load checking
+               # 2) time takes for failover
+               it_time_start=$(date +%s)
+
+               serverfacet=$(get_random_entry $servers)
+               var=${serverfacet}_numfailovers
+
+               # Check that our client loads are still running. If any have
+               # died, that means they have died outside of recovery, which
+               # is unacceptable.
+               log "==== Check clients loads BEFORE failover -- failure NOT OK \
+                    ELAPSED=$ELAPSED DURATION=$DURATION \
+                    PERIOD=$SERVER_FAILOVER_PERIOD"
+               check_client_loads $NODES_TO_USE || exit 4
+
+               log "Wait $serverfacet recovery complete before next failover"
+               if ! wait_recovery_complete $serverfacet; then
+                   echo "$serverfacet recovery is not completed!"
+                   exit 7
+               fi
 
                local want="FULL\|IDLE"
                log "Checking clients are in $want state before next failover"
                wait_clients_import_state $NODES_TO_USE $serverfacet "$want" ||
-                       echo "Client import not $want, please consider to increase SERVER_FAILOVER_PERIOD=$SERVER_FAILOVER_PERIOD!"
-
-        log "Starting failover on $serverfacet"
-        facet_failover "$serverfacet" || exit 1
-
-        # Check that our client loads are still running during failover.
-        # No application failures should occur.
-        log "==== Checking the clients loads AFTER failover -- failure NOT OK"
-        if ! check_client_loads $NODES_TO_USE; then
-            log "Client load failed during failover. Exiting..."
-            exit 5
-        fi
-
-        # Increment the number of failovers.
-        val=$((${!var} + 1))
-        eval $var=$val
-
-        current_ts=$(date +%s)
-        ELAPSED=$((current_ts - start_ts))
-
-        sleep=$((SERVER_FAILOVER_PERIOD - (current_ts - it_time_start)))
-
-        # Keep counting the number of iterations when
-        # time spent to failover and two client loads check exceeded
-        # the value ( SERVER_FAILOVER_PERIOD - MINSLEEP ).
-        if [ $sleep -lt $MINSLEEP ]; then
-            reqfail=$((reqfail + 1))
-            log "WARNING: failover and two check_client_loads time exceeded \
-SERVER_FAILOVER_PERIOD - MINSLEEP!
-Failed to load the filesystem with I/O for a minimum period of \
-$MINSLEEP $reqfail times ( REQFAIL=$REQFAIL ).
-This iteration, the load was only applied for sleep=$sleep seconds.
-Estimated max recovery time: $MAX_RECOV_TIME
-Probably the hardware is taking excessively long time to boot.
-Try to increase SERVER_FAILOVER_PERIOD (current is $SERVER_FAILOVER_PERIOD), \
-bug 20918"
-            [ $reqfail -gt $REQFAIL ] && exit 6
-        fi
-
-        log "$serverfacet has failed over ${!var} times, and counting..."
-
-        [ $((ELAPSED + sleep)) -ge $DURATION ] && break
-
-        if [ $sleep -gt 0 ]; then
-            echo "sleeping $sleep seconds... "
-            sleep $sleep
-        fi
-    done
-    exit 0
+                       echo "Client import not $want, please consider to" \
+                       "increase SERVER_FAILOVER_PERIOD=" \
+                       "$SERVER_FAILOVER_PERIOD!"
+
+               log "Starting failover on $serverfacet"
+               facet_failover "$serverfacet" || exit 1
+
+               # Check that our client loads are still running during failover.
+               # No application failures should occur.
+               log "==== Check clients loads AFTER failover -- failure NOT OK"
+               if ! check_client_loads $NODES_TO_USE; then
+                       log "Client load failed during failover. Exiting..."
+                       exit 5
+               fi
+
+               # Increment the number of failovers.
+               val=$((${!var} + 1))
+               eval $var=$val
+
+               current_ts=$(date +%s)
+               ELAPSED=$((current_ts - start_ts))
+
+               sleep=$((SERVER_FAILOVER_PERIOD - (current_ts - it_time_start)))
+
+               # Keep counting the number of iterations when
+               # time spent to failover and two client loads check exceeded
+               # the value ( SERVER_FAILOVER_PERIOD - MINSLEEP ).
+               if (( $sleep < $MINSLEEP )); then
+                       reqfail=$((reqfail + 1))
+
+                       cat <<- END_WARN
+                       WARNING: failover and two check_client_loads time exceeded: SERVER_FAILOVER_PERIOD - MINSLEEP!
+                       Failed loading I/O for a min period of $MINSLEEP $reqfail times (REQFAIL=$REQFAIL)
+                       This iteration, load only applied for sleep=$sleep seconds.
+                       Estimated max recovery time: $MAX_RECOV_TIME
+                       Probably hardware is taking excessively long time to boot.
+                       Try increasing SERVER_FAILOVER_PERIOD (current is $SERVER_FAILOVER_PERIOD), bug 20918
+                       END_WARN
+                       (( $reqfail > $REQFAIL )) && exit 6
+               fi
+
+               log "$serverfacet failed over ${!var} times, and counting..."
+
+               [ $((ELAPSED + sleep)) -ge $DURATION ] && break
+
+               if (( $sleep > 0 )); then
+                       echo "sleeping $sleep seconds... "
+                       sleep $sleep
+               fi
+       done
+       exit 0
 }
 
 ################################## Main Flow ###################################
 check_and_setup_lustre
 rm -rf $DIR/[Rdfs][0-9]*
 
+
 MAX_RECOV_TIME=$(max_recovery_time)
 
 # The test node needs to be insulated from a lustre failure as much as possible,
@@ -223,20 +249,25 @@ zconf_umount $HOSTNAME $MOUNT
 NODES_TO_USE=${NODES_TO_USE:-$CLIENTS}
 NODES_TO_USE=$(exclude_items_from_list $NODES_TO_USE $HOSTNAME)
 
-check_progs_installed $NODES_TO_USE ${CLIENT_LOADS[@]}
+check_progs_installed $NODES_TO_USE "${CLIENT_LOADS[@]}"
 
 MDTS=$(get_facets MDS)
 OSTS=$(get_facets OST)
 
+# Print informaiton about settings
+run_info $SERVER_FAILOVER_PERIOD $DURATION $MINSLEEP $SLOW $REQFAIL \
+       $SHARED_DIRECTORY $END_RUN_FILE $LOAD_PID_FILE $VMSTAT_PID_FILE \
+       $CLIENTCOUNT $MDTS $OSTS
+
 test_failover_mds() {
-    # failover a random MDS
-    failover_target MDS
+       # failover a random MDS
+       failover_target MDS
 }
 run_test failover_mds "failover MDS"
 
 test_failover_ost() {
-    # failover a random OST
-    failover_target OST
+       # failover a random OST
+       failover_target OST
 }
 run_test failover_ost "failover OST"