Whamcloud - gitweb
LU-12652 ldiskfs: disable credits check in 4.18 50/35750/19
authorAlexey Zhuravlev <bzzz@whamcloud.com>
Fri, 9 Aug 2019 10:55:24 +0000 (13:55 +0300)
committerOleg Drokin <green@whamcloud.com>
Thu, 14 May 2020 05:39:43 +0000 (05:39 +0000)
4.18 has a credits check in xattr_set path with different math
resulting in false ENOSPC and subsequent failure to update LMA.
as a result - many tests fail on 4.18, especially with DNE.

Signed-off-by: Alexey Zhuravlev <bzzz@whamcloud.com>
Change-Id: I82b19c0c24988aed66d74cf2323e93acffb14f31
Reviewed-on: https://review.whamcloud.com/35750
Tested-by: jenkins <devops@whamcloud.com>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Reviewed-by: Wang Shilong <wshilong@ddn.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Yang Sheng <ys@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
ldiskfs/kernel_patches/patches/rhel8/ext4-xattr-disable-credits-check.patch [new file with mode: 0644]
ldiskfs/kernel_patches/series/ldiskfs-4.18-rhel8.1.series
ldiskfs/kernel_patches/series/ldiskfs-4.18-rhel8.series

diff --git a/ldiskfs/kernel_patches/patches/rhel8/ext4-xattr-disable-credits-check.patch b/ldiskfs/kernel_patches/patches/rhel8/ext4-xattr-disable-credits-check.patch
new file mode 100644 (file)
index 0000000..86fee40
--- /dev/null
@@ -0,0 +1,15 @@
+Index: linux-4.18.0-32.el8.x86_64/fs/ext4/xattr.c
+===================================================================
+--- linux-4.18.0-32.el8.x86_64.orig/fs/ext4/xattr.c
++++ linux-4.18.0-32.el8.x86_64/fs/ext4/xattr.c
+@@ -655,10 +655,6 @@ enum {
+                                                  flags & XATTR_CREATE);
+               brelse(bh);
+
+-              if (!ext4_handle_has_enough_credits(handle, credits)) {
+-                      error = -ENOSPC;
+-                      goto cleanup;
+-              }
+       }
+
+       error = ext4_reserve_inode_write(handle, inode, &is.iloc);
index cb22107..14380d7 100644 (file)
@@ -24,3 +24,4 @@ rhel8/ext4-export-mb-stream-allocator-variables.patch
 rhel8/ext4-simple-blockalloc.patch
 rhel8/ext4-mballoc-skip-uninit-groups-cr0.patch
 rhel8.1/ext4-mballoc-prefetch.patch
+rhel8/ext4-xattr-disable-credits-check.patch
index a64a394..5d378bb 100644 (file)
@@ -25,3 +25,4 @@ rhel8/ext4-export-mb-stream-allocator-variables.patch
 rhel8/ext4-simple-blockalloc.patch
 rhel8/ext4-mballoc-skip-uninit-groups-cr0.patch
 rhel8/ext4-mballoc-prefetch.patch
+rhel8/ext4-xattr-disable-credits-check.patch