Whamcloud - gitweb
LU-4322 tests: re-enable 101a in dne config 27/35027/6
authorPatrick Farrell <pfarrell@whamcloud.com>
Sat, 1 Jun 2019 00:03:40 +0000 (20:03 -0400)
committerOleg Drokin <green@whamcloud.com>
Fri, 4 Oct 2019 03:44:09 +0000 (03:44 +0000)
We should re-enable 101a in the dne config, and also make
it more strict on discards.  This test should normally
result in 0 discards, because every page brought in by
readahead is used.

It is possible for randomness with the reads to lead to a
few discards, but no more than that.

Test-Parameters: trivial testlist=sanity,sanity,sanity,sanity
Signed-off-by: Patrick Farrell <pfarrell@whamcloud.com>
Change-Id: I53c6263c33c27d36b746c8fc56c8deebb4b713c7
Reviewed-on: https://review.whamcloud.com/35027
Reviewed-by: James Nunez <jnunez@whamcloud.com>
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: James Simmons <jsimmons@infradead.org>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
lustre/tests/sanity.sh

index b8ca080..2736f42 100644 (file)
@@ -8667,7 +8667,6 @@ cleanup_101a() {
 
 test_101a() {
        [ $PARALLEL == "yes" ] && skip "skip parallel run"
-       [ $MDSCOUNT -ge 2 ] && skip_env "needs < 2 MDTs" #LU-4322
 
        local s
        local discard
@@ -8692,9 +8691,12 @@ test_101a() {
        done
        cleanup_101a
 
-       if [[ $(($discard * 10)) -gt $nreads ]]; then
-               $LCTL get_param osc.*-osc*.rpc_stats
-               $LCTL get_param llite.*.read_ahead_stats
+       $LCTL get_param osc.*-osc*.rpc_stats
+       $LCTL get_param llite.*.read_ahead_stats
+
+       # Discard is generally zero, but sometimes a few random reads line up
+       # and trigger larger readahead, which is wasted & leads to discards.
+       if [[ $(($discard)) -gt $nreads ]]; then
                error "too many ($discard) discarded pages"
        fi
        rm -f $DIR/$tfile || true