Whamcloud - gitweb
LU-3306 mdt: Do not LBUG on double set of err_serious
authorOleg Drokin <green@whamcloud.com>
Sat, 18 May 2013 03:18:55 +0000 (23:18 -0400)
committerOleg Drokin <oleg.drokin@intel.com>
Tue, 21 May 2013 15:36:24 +0000 (11:36 -0400)
It seems the twisted code pathes in mdt could take strange routes
and it's quite hard to guarantee they won't pass through setting
err_serious twice, esp. since error handlers are traditionally
poorly tested.

Change-Id: I88fe880c22670263273bd79073efaecbe53d9215
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Reviewed-on: http://review.whamcloud.com/6383
Tested-by: Hudson
Tested-by: Maloo <whamcloud.maloo@gmail.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Mike Pershin <mike.pershin@intel.com>
lustre/include/lustre_mdt.h

index c8b39d4..81b69fc 100644 (file)
@@ -63,7 +63,6 @@ enum {
 static inline int err_serious(int rc)
 {
         LASSERT(rc < 0);
 static inline int err_serious(int rc)
 {
         LASSERT(rc < 0);
-        LASSERT(-rc < ESERIOUS);
         return -(-rc | ESERIOUS);
 }
 
         return -(-rc | ESERIOUS);
 }