Whamcloud - gitweb
LU-12542 handle: remove locking from class_handle2object() 61/35861/7
authorNeilBrown <neilb@suse.de>
Fri, 13 Dec 2019 15:46:15 +0000 (10:46 -0500)
committerOleg Drokin <green@whamcloud.com>
Tue, 28 Jan 2020 06:03:04 +0000 (06:03 +0000)
There is limited value in this locking and test on h_in.

If the lookup could have run in parallel with
class_handle_unhash_nolock() and seen "h_in == 0", then it could
equally well have run moments earlier and not seen it - no locking
would prevent that, so the caller much be prepared to have
an object returned which has already been unhashed by the time it
sees the object.

In other words, any interlock between unhash and lookup must be
provided at a higher level than where this code is trying
to handle it.

The locking *does* prevent the refcount from being incremented if the
object has already been removed from the list.  As the final reference
is always dropped after that removal, it indirectly stops the refcount
from being incremented after the final reference is dropped.
This can be more directly achieved by using refcount_inc_not_zero().

So remove the locking, and replace it with refcount_inc_not_zero().

Change-Id: Id29cee173ed0c3b060ea92e21af6e420970cfa18
Signed-off-by: Mr NeilBrown <neilb@suse.de>
Reviewed-on: https://review.whamcloud.com/35861
Tested-by: jenkins <devops@whamcloud.com>
Reviewed-by: Mike Pershin <mpershin@whamcloud.com>
Reviewed-by: Petros Koutoupis <pkoutoupis@cray.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>

index 7931442..8a6bd97 100644 (file)
@@ -155,15 +155,12 @@ void *class_handle2object(u64 cookie, const char *owner)
                if (h->h_cookie != cookie || h->h_owner != owner)
-               spin_lock(&h->h_lock);
-               if (likely(h->h_in != 0)) {
-                       refcount_inc(&h->h_ref);
+               if (refcount_inc_not_zero(&h->h_ref)) {
                        CDEBUG(D_INFO, "GET %s %p refcount=%d\n",
                               h->h_owner, h,
                        retval = h;
-               spin_unlock(&h->h_lock);