Whamcloud - gitweb
LU-2926 ldiskfs: crash in is_bad_inode()
authorAndriy Skulysh <Andriy_Skulysh@xyratex.com>
Thu, 7 Mar 2013 13:02:57 +0000 (15:02 +0200)
committerOleg Drokin <oleg.drokin@intel.com>
Wed, 13 Mar 2013 20:44:57 +0000 (16:44 -0400)
Fix error handling in ldiskfs_xattr_inode_iget

Xyratex-bug-id: MRP-883
Signed-off-by: Andriy Skulysh <Andriy_Skulysh@xyratex.com>
Change-Id: I9840b7bd32f2c96763cae402a7bcb51d5798ea6c
Reviewed-on: http://review.whamcloud.com/5631
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Hudson
Reviewed-by: Keith Mannthey <keith.mannthey@intel.com>
Reviewed-by: Jian Yu <jian.yu@intel.com>
Tested-by: Maloo <whamcloud.maloo@gmail.com>
ldiskfs/kernel_patches/patches/rhel6.3/ext4-large-eas.patch

index 0fc411a..6c7802c 100644 (file)
@@ -118,7 +118,7 @@ Index: linux-stage/fs/ext4/xattr.c
 +      struct inode *ea_inode = NULL;
 +
 +      ea_inode = ext4_iget(parent->i_sb, ea_ino);
-+      if (ea_inode == NULL || is_bad_inode(ea_inode)) {
++      if (IS_ERR(ea_inode) || is_bad_inode(ea_inode)) {
 +              ext4_error(parent->i_sb, "error while reading EA inode %d",
 +                         ea_ino);
 +              *err = -EIO;